Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi, Manajit. Why the test is OSX specific? It seems this functionality should be cross platform? It would be good to have a small delay between keypress/release(or autodelay in robot). On 09.03.16 16:43, Manajit Halder wrote: Hi All, Please review webrev.01 updated with Avik’s review comment

Re: [9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

+1 On 3/14/2016 12:10 PM, Avik Niyogi wrote: Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi On 14-Mar-2016, at 2:42 pm, Manajit Halder > wrote: Hi Semyon & Avik, Thanks to both of you for the review. Please review the modified the code. htt

Re: [9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi > On 14-Mar-2016, at 2:42 pm, Manajit Halder wrote: > > Hi Semyon & Avik, > > Thanks to both of you for the review. > > Please review the modified the code. > http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.02/ >

[9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Semyon & Avik, Thanks to both of you for the review. Please review the modified the code. http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.02/ Regards, Manajit > On 14-Mar-2016, at 11:38 am, Semyon Sadetsky > wrot

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, The fix itself looks good. Several minor remarks: - In the test setting GridBagLayout to the frame seems meaningless. - The year in the files header should be 2016. - For the future, add " [9]" in the beginning of review subject. --Semyon On 3/9/2016 4:43 PM, Manajit Halder wrote:

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi > On 09-Mar-2016, at 7:13 pm, Manajit Halder wrote: > > Hi All, > > Please review webrev.01 updated with Avik’s review comments. > > http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.01/ >

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi All, Please review webrev.01 updated with Avik’s review comments. http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.01/ Thanks, Manajit > On 09-Mar-2016, at 3:18 pm, Avik Niyogi wrote: > > Hi Manajit, > > Following are my inputs: > CRobot.m : Line 359 : retval not needed > alpha

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, Following are my inputs: CRobot.m : Line 359 : retval not needed alphabetical objC header list convention not followed. Line 36 should be placed at line 32 CRobotKeyCode.m : Line 171: retval not needed. use else block for cases undefined. Use non-Swing implementations for test case.

Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8149456 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.00/ Issue: