Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-10 Thread Phil Race
Looks fine (I just looked at the getFontPeer() this time around. Pls remember to do a CCC before pushing this ! -phil. On 03/05/2015 04:51 AM, Sergey Bylokhov wrote: The new version of the fix: http://cr.openjdk.java.net/~serb/8074028/webrev.06 Font.getPeer() was renamed to Font.getFontPeer().

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-06 Thread Anton Tarasov
Hi Sergey, Looks good to me. Thanks, Anton. On 04/03/15 15:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPeer() @deprecated 1.1 public

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-05 Thread Phil Race
Looks good to me. I like some of the clean up like : -if (getPeer() == null) { +if (!isDisplayable()) { which is the same as we've told other folks to do .. I was initially surprised at just using the field peer as it might be null, but getPeer() just returned peer anyway, so

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-05 Thread Alan Bateman
On 05/03/2015 12:51, Sergey Bylokhov wrote: The new version of the fix: http://cr.openjdk.java.net/~serb/8074028/webrev.06 Font.getPeer() was renamed to Font.getFontPeer(). This part looks good to me. I assume someone working in this area will give the rest of the changes a thorough review.

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-05 Thread Vadim Pakhnushev
On 04/03/15 15:37, Sergey Bylokhov wrote: http://cr.openjdk.java.net/~serb/8074028/webrev.05/src/java.desktop/share/classes/java/awt/MenuComponent.java.sdiff.html What's the point of ComponentPeer peer = this.peer; ? Why not just use peer as in other places in this file? Thanks, Vadim

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-05 Thread Sergey Bylokhov
The new version of the fix: http://cr.openjdk.java.net/~serb/8074028/webrev.06 Font.getPeer() was renamed to Font.getFontPeer(). On 04.03.2015 15:51, Alan Bateman wrote: On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-04 Thread Yuri Nesterenko
On 03/04/2015 04:35 PM, Sergey Bylokhov wrote: On 04.03.2015 15:51, Alan Bateman wrote: On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-04 Thread Alan Bateman
On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPeer() @deprecated 1.1 public java.awt.Font.getPeer() @deprecated 1.1 public

AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-04 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPeer() @deprecated 1.1 public java.awt.Font.getPeer() @deprecated 1.1 public java.awt.MenuComponent.getPeer() @deprecated 1.1 There is

Re: AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-04 Thread Sergey Bylokhov
On 04.03.2015 15:51, Alan Bateman wrote: On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPeer() @deprecated 1.1 public