Re: AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

2015-06-17 Thread Sergey Bylokhov
On 27.05.15 19:03, Sergey Bylokhov wrote: Hi, Alan. On 27.05.15 18:51, Alan Bateman wrote: A minor comment on the usage of ByteArrayOutputStream is that you should be able to replace this soon with: Image image = toolkit.createImage( in.readAllBytes() ); The readAllBytes method is

Re: AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

2015-06-17 Thread Alan Bateman
On 17/06/2015 18:47, Sergey Bylokhov wrote: On 27.05.15 19:03, Sergey Bylokhov wrote: Hi, Alan. On 27.05.15 18:51, Alan Bateman wrote: A minor comment on the usage of ByteArrayOutputStream is that you should be able to replace this soon with: Image image = toolkit.createImage(

Re: AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

2015-06-17 Thread Chris Hegarty
On 17 Jun 2015, at 18:58, Alan Bateman alan.bate...@oracle.com wrote: On 17/06/2015 18:47, Sergey Bylokhov wrote: On 27.05.15 19:03, Sergey Bylokhov wrote: Hi, Alan. On 27.05.15 18:51, Alan Bateman wrote: A minor comment on the usage of ByteArrayOutputStream is that you should be able to

AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

2015-05-27 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. The usage of getResource() was changed to getResourceAsStream(). Note that before the fix the toolkit.getImage() cached the image, but it should not be a problem in the new code, because cursor itself is cached in the Cursor.getSystemCustomCursor().

Re: AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

2015-05-27 Thread Alan Bateman
On 27/05/2015 14:48, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The usage of getResource() was changed to getResourceAsStream(). Note that before the fix the toolkit.getImage() cached the image, but it should not be a problem in the new code, because cursor itself is cached

Re: AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

2015-05-27 Thread Sergey Bylokhov
Hi, Alan. On 27.05.15 18:51, Alan Bateman wrote: A minor comment on the usage of ByteArrayOutputStream is that you should be able to replace this soon with: Image image = toolkit.createImage( in.readAllBytes() ); The readAllBytes method is currently in review on core-libs-dev. Thanks for