Re: AWT Dev [9] review request for 8066436: Minimize can cause window to disappear on osx

2015-03-10 Thread Alexander Zvegintsev
Hi Nakul, the fix looks good to me too. Thanks, Alexander. On 03/09/2015 09:48 PM, Nakul Natu wrote: Thank you Sergey! Can anyone else also review this please? Nakul On 3/9/15, 8:05 AM, Sergey Bylokhov wrote: Hi, Nakul. The fix looks good. 05.03.15 14:26, Nakul Natu wrote: Hi Sergey and

Re: AWT Dev [9] review request for 8066436: Minimize can cause window to disappear on osx

2015-03-09 Thread Sergey Bylokhov
Hi, Nakul. The fix looks good. 05.03.15 14:26, Nakul Natu wrote: Hi Sergey and all, Updated webrev with suggested changes and testcase. http://cr.openjdk.java.net/~van/8066436/webrev.01/ Regards, Nakul On 3/4/15, 5:17 AM, Sergey Bylokhov wrote: Hi, Nakul. Thanks for the fix. A few notes:

Re: AWT Dev [9] review request for 8066436: Minimize can cause window to disappear on osx

2015-03-09 Thread Nakul Natu
Thank you Sergey! Can anyone else also review this please? Nakul On 3/9/15, 8:05 AM, Sergey Bylokhov wrote: Hi, Nakul. The fix looks good. 05.03.15 14:26, Nakul Natu wrote: Hi Sergey and all, Updated webrev with suggested changes and testcase.

Re: AWT Dev [9] review request for 8066436: Minimize can cause window to disappear on osx

2015-03-05 Thread Nakul Natu
Hi Sergey and all, Updated webrev with suggested changes and testcase. http://cr.openjdk.java.net/~van/8066436/webrev.01/ Regards, Nakul On 3/4/15, 5:17 AM, Sergey Bylokhov wrote: Hi, Nakul. Thanks for the fix. A few notes: - Please remove the bugid information from the comment since we

Re: AWT Dev [9] review request for 8066436: Minimize can cause window to disappear on osx

2015-03-04 Thread Sergey Bylokhov
Hi, Nakul. Thanks for the fix. A few notes: - Please remove the bugid information from the comment since we have mercurial history for such notes. - I suppose that the comment can be shorter, like this: We need an up to date size of the peer, so we flush the native events to be sure that

AWT Dev [9] review request for 8066436: Minimize can cause window to disappear on osx

2015-03-02 Thread Nakul Natu
Hello, Please review the fix for JDK 9. CPlatformWindow set bounds using setBounds() which calls native function nativeNSSetWindowBounds() - calls the OSX function. After that ox callbacks to java using deliverMoveresizeEvent() where the peer or window associated with native window is