Re: AWT Dev Awt Dev [9] Review Request for 8130769: The new menu can't be shown on the menubar after clicking the Add button.

2015-07-22 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/22/2015 12:32 AM, Sergey Bylokhov wrote: Hi, Semyon. The fix looks good. On 16.07.15 19:08, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130769 webrev:

Re: AWT Dev Awt Dev [9] Review Request for 8130769: The new menu can't be shown on the menubar after clicking the Add button.

2015-07-22 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 07/22/2015 10:51 AM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/22/2015 12:32 AM, Sergey Bylokhov wrote: Hi, Semyon. The fix looks good. On 16.07.15 19:08, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug:

Re: AWT Dev Awt Dev [9] Review Request for 8130769: The new menu can't be shown on the menubar after clicking the Add button.

2015-07-21 Thread Sergey Bylokhov
Hi, Semyon. The fix looks good. On 16.07.15 19:08, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130769 webrev: http://cr.openjdk.java.net/~ssadetsky/8130769/webrev.00/ This is regression from JDK-7155957. Menu should be added to

AWT Dev Awt Dev [9] Review Request for 8130769: The new menu can't be shown on the menubar after clicking the Add button.

2015-07-16 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130769 webrev: http://cr.openjdk.java.net/~ssadetsky/8130769/webrev.00/ This is regression from JDK-7155957. Menu should be added to MenuBar collection before the adding it to MenuBar's peer otherwise it is not