Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-10-14 Thread Hohensee, Paul
Hi, Matthias, Kim. No problem opening a separate issue to fix CSystemColors.m. Thanks, Paul On 9/29/20, 4:23 AM, "hotspot-dev on behalf of Kim Barrett" wrote: > On Sep 29, 2020, at 3:14 AM, Matthias Baesken wrote: > > On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote: >

Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209) [v2]

2020-10-14 Thread Hohensee, Paul
Hmm. I'm running Xcode 12.0.1 on 10.15.6 and don't see it. Are you sure you have the '&' in front of locs_buf? I.e., buffer.insts()->initialize_shared_locs((relocInfo*)&locs_buf, sizeof(locs_buf) / sizeof(relocInfo));

Re: [OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-10-14 Thread Hohensee, Paul
I filed https://bugs.openjdk.java.net/browse/JDK-8253868: CodeSection::initialize_shared_locs buffer argument types and sizes are opaque Paul On 9/29/20, 9:35 AM, "Kim Barrett" wrote: > On Sep 29, 2020, at 10:18 AM, Hohensee, Paul wrote: > Code that calls initialize_shared_locs is in

Re: [OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-10-14 Thread Hohensee, Paul
Thanks for the reviews/discussion, and apologies for the delayed reply: I've been OOTO. Kim is correct, initialize_shared_locs specifically adjusts the alignment of its buffer argument, which is why short works. char would work as well, but short happens to be the size of a relocInfo. Maybe the

Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209) [v2]

2020-10-14 Thread Hohensee, Paul
Thanks, Lutz! On 9/29/20, 10:56 PM, "build-dev on behalf of Lutz Schmidt" wrote: On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote: >> Please review this small patch to enable the OSX build using Xcode 12.0. >> >> Thanks, >> Paul > > Paul Hohensee has updated

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Dalibor Topic
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 Hi, please send the details whose OCA you are covered under to [email protected] so that I can verify your account. Thanks! - PR: https://git.

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Andrii Rodionov
On Fri, 9 Oct 2020 17:20:38 GMT, Dalibor Topic wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 > > Hi, please send the details whose OCA you are covered under to > [email protected] so that I can verify your > account. Thanks! @robilad Hi Dalibor! Have

RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Andrii Rodionov
The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 - Commit messages: - 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image Changes: https://git.openjdk.java.net/jdk/pull/562/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Andrii Rodionov
On Fri, 9 Oct 2020 18:31:50 GMT, Andrii Rodionov wrote: >> Hi, please send the details whose OCA you are covered under to >> [email protected] so that I can verify your >> account. Thanks! > > @robilad Hi Dalibor! Have sent you email with details. > Thanks! @bobvandette Could you pleas

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Phil Race
On Wed, 14 Oct 2020 17:41:57 GMT, Andrii Rodionov wrote: >> @robilad Hi Dalibor! Have sent you email with details. >> Thanks! > > @bobvandette Could you please join to the review? It is generally not expected for such a proposed change to pop up out of nowhere from someone who is a new contrib

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Bob Vandette
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c line 820: > 818: > 819: JNIEXPORT void JNICALL > 820: Java_sun_xawt_motif_XsessionWMcommand(JNIEnv *env, jo

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Bob Vandette
On Wed, 14 Oct 2020 17:56:34 GMT, Phil Race wrote: > It is generally not expected for such a proposed change to pop up out of > nowhere from someone who is a new contributor > without prior discussion and so forth. > I have no idea where this change is coming from, why we would want it, and > h

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Phil Race
On Wed, 14 Oct 2020 18:26:35 GMT, Bob Vandette wrote: >> It is generally not expected for such a proposed change to pop up out of >> nowhere from someone who is a new contributor >> without prior discussion and so forth. >> I have no idea where this change is coming from, why we would want it,

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Bob Vandette
On Wed, 14 Oct 2020 18:31:28 GMT, Phil Race wrote: > Sorry I am not familiar with that work. Please provide more info. Here's the JEP for the work done in JDK8 to allow libraries to be built and used statically. https://bugs.openjdk.java.net/browse/JDK-8046168 Here's the changes done to allow