[ 
http://issues.apache.org/jira/browse/AXISCPP-815?page=comments#action_12320171 
] 

Denis Linine commented on AXISCPP-815:
--------------------------------------

Sorry, the original message was sent  by accident, should be:

in the following code pszMsg  leaks:

if( (iStatus = m_pSoapEnvelope->serialize( *this, (SOAP_VERSION) 
m_iSoapVersion)) == AXIS_FAIL)
{
char * pszMsg = new char[128];

strcpy( pszMsg, "The SOAP serialiser has detected errors in the header or 
envelope.  Transmission has been aborted.");

throw AxisSoapException( CLIENT_SOAP_MESSAGE_INCOMPLETE, pszMsg);
}



Could be written like this

if( (iStatus = m_pSoapEnvelope->serialize( *this, (SOAP_VERSION) 
m_iSoapVersion)) == AXIS_FAIL)
{
throw AxisSoapException( CLIENT_SOAP_MESSAGE_INCOMPLETE,   "The SOAP serializer 
has detected errors in the header or envelope.  Transmission has been 
aborted.");
}

A question regarding the message text: "serialiser"  or  "serializer"?







> possible memory leak in the int SoapSerializer::setOutputStream( 
> SOAPTransport * pStream) - SoapSerializer.cpp file
> -------------------------------------------------------------------------------------------------------------------
>
>          Key: AXISCPP-815
>          URL: http://issues.apache.org/jira/browse/AXISCPP-815
>      Project: Axis-C++
>         Type: Bug
>     Versions: current (nightly)
>     Reporter: Denis Linine
>     Priority: Minor

>
> if( (iStatus = m_pSoapEnvelope->serialize( *this, (SOAP_VERSION) 
> m_iSoapVersion)) == AXIS_FAIL)
> {
> char * pszMsg = new char[128];
>                               strcpy( pszMsg, "The SOAP serialiser has 
> detected errors in the header or envelope.  Transmission has been aborted.");
>                               throw AxisSoapException( 
> CLIENT_SOAP_MESSAGE_INCOMPLETE, pszMsg);
>                       }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to