Review: Approve
HAHA
--
https://code.launchpad.net/~ted/indicator-session/restart-icon-change/+merge/77090
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
The proposal to merge lp:~ted/indicator-session/restart-icon-change into
lp:indicator-session has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~ted/indicator-session/restart-icon-change/+merge/77090
--
The proposal to merge lp:~kelemeng/evolution-indicator/bug437963 into
lp:evolution-indicator has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~kelemeng/evolution-indicator/bug437963/+merge/67456
--
Review: Approve
--
https://code.launchpad.net/~kelemeng/evolution-indicator/bug437963/+merge/67456
Your team ayatana-commits is subscribed to branch lp:evolution-indicator.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Nice work!
--
https://code.launchpad.net/~cjcurran/indicator-session/udev-beginnings/+merge/70850
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
The proposal to merge lp:~cjcurran/indicator-session/udev-beginnings into
lp:indicator-session has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~cjcurran/indicator-session/udev-beginnings/+merge/70850
--
Neil J. Patel has proposed merging
lp:~njpatel/indicator-session/send-real-pointers into lp:indicator-session.
Requested reviews:
Conor Curran (cjcurran)
For more details, see:
https://code.launchpad.net/~njpatel/indicator-session/send-real-pointers/+merge/68669
This fixes the issue
Review: Approve
Looks good. One thing I'd tweak is that, when connecting to the notify signal,
your only interested in the parent property, so instead of doing:
g_signal_connect (object, notify,
You should do:
g_signal_connect (object, notify::parent,
The former connects to all
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/indicator-appmenu/one-more-xerror-fix into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Some uninitialized pointer fun.
--
https://code.launchpad.net/~indicator-applet
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
This catches xerrors properly
--
https://code.launchpad.net/~indicator-applet
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/indicator-appmenu/dont-use-gdk-window-foreign
into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#637108 Maximised windows are automatically closed
https
Review: Approve
Approved!
--
https://code.launchpad.net/~ted/indicator-appmenu/right-array-type/+merge/35745
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
approved pending changes discussed on IRC
--
https://code.launchpad.net/~cjcurran/indicator-sound/ui-polishing/+merge/33414
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing list:
Review: Approve
Wheee!
--
https://code.launchpad.net/~ted/dbusmenu/bigger-max-xml/+merge/33219
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
approved.
--
https://code.launchpad.net/~dbarth/appmenu-gtk/tb-crasher-fix/+merge/31254
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
makes sense, approved.
--
https://code.launchpad.net/~dbarth/appmenu-gtk/local-fallback/+merge/31311
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Looks good, approved!
--
https://code.launchpad.net/~cjcurran/indicator-sound/mprisv2/+merge/29583
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Review: Approve
_
--
https://code.launchpad.net/~cjcurran/indicator-sound/more-distcheckfixes/+merge/28379
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Needs Fixing
In addition to the comments about using the Value struct on IRC,
- gchar* symbol = transport_widget_toggle_play_label(d need to g_free
(symbol) afterwards?
- In signal callbacks like transport_widget_button_release_event, I'd suggest
doing a g_return_if_fail
Review: Approve
Approved.
--
https://code.edge.launchpad.net/~ted/indicator-messages/application-active-icon/+merge/19578
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
___
Mailing list: https://launchpad.net/~ayatana-commits
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/user-item/+merge/19577
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post
Review: Needs Fixing
- You could just send (GFunc)g_object_unref instead of having an explicit
func_unref function to the g_list_foreach (though I see why you may not want
to).
- I'd set priv-listener = NULL; after unreffing it, as you've done for the
other properties in dispose
- When
Review: Approve
- (desktop_file_from_keyfile) g_key_file_get_string returns a allocated string,
so should either free it or just return that
--
https://code.edge.launchpad.net/~ted/indicator-messages/static-commands/+merge/19528
Your team ayatana-commits is subscribed to branch
Review: Needs Fixing
Dammit, I meant to mark as need's fixing, you get what I mean :)
--
https://code.edge.launchpad.net/~ted/indicator-messages/static-commands/+merge/19528
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
___
Review: Approve
Log files are for wimps. Real men guess what errors happened.
--
https://code.edge.launchpad.net/~ted/indicator-applet/log-to-file/+merge/17695
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
___
Mailing list:
Review: Approve
Looks good + tests all pass. The --enable-massivedebugging fails compilation as
it's still expecting strings instead of values in some places. Approving so
your not blocked on that, though :)
--
https://code.edge.launchpad.net/~ted/dbusmenu/v2work/+merge/16323
Your team
Review: Approve
--
https://code.edge.launchpad.net/~ted/dbusmenu/v2work/+merge/16323
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/dbusmenu/xvfb/+merge/15071
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/better-locking/+merge/13010
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Review: Needs Fixing
8 + TREE
9 libdbusmenu-[0-9].[0-9].[0-9].tar.gz
10 libdbusmenu-[0-9].[0-9].[0-9].tar.gz.asc
11 +===
12 +tools/dbusmenu-dumper
13 + MERGE-SOURCE
Looks like a conflict, otherwise everything else looks good.
--
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/async-menu/+merge/12869
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Review: Approve
Approved.
--
https://code.edge.launchpad.net/~dbarth/indicator-session/no-close-button/+merge/12408
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Review: Approve
The latest changes look good. Approved.
--
https://code.edge.launchpad.net/~macslow/notify-osd/forced-shutdown/+merge/12296
Your team ayatana-commits is subscribed to branch lp:notify-osd.
___
Mailing list:
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-messages/path-change/+merge/12297
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
___
Mailing list: https://launchpad.net/~ayatana-commits
I'd suggest that, when you reach the threshold, add a idle handler or timeout
that recurs until the queue is exhausted. At that point it calls gtk_main_quit.
We don't want to lose notifications that are in the queue.
--
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-applet/python-v2work/+merge/11948
Your team ayatana-commits is subscribed to branch lp:indicator-applet/python0.2.
___
Mailing list:
Review: Approve
Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/available/+merge/11932
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
/me is karma whore? Approved.
--
https://code.edge.launchpad.net/~bratsche/xsplash/add-signal/+merge/11898
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Review: Approve
Looks good to me. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/designstuff/+merge/11893
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list:
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/evolution-indicator/multiple-mailbox-indication
into lp:evolution-indicator.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
So, this branch adds support for the latest indicator API
40 matches
Mail list logo
