Review: Abstain
> Looks good. Approved.
>
> Fwiw, G_PARAM_STATIC_STRINGS is also a useful param in addition to the one you
> use, it just means that the strings you used for the nick, blurb and
> description are static, so glib doesn't copy them, just reference.
>
> I normally always forget to us
The proposal to merge lp:~macslow/notify-osd/fix-375408 into lp:notify-osd has
been updated.
Status: Needs review => Approved
--
https://code.edge.launchpad.net/~macslow/notify-osd/fix-375408/+merge/11779
Your team ayatana-commits is subscribed to branch lp:notify-osd.
_
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/evolution-indicator/ignore-inactive-accounts
into lp:evolution-indicator.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixes two issues to do with showing accounts in the menu:
1. If the user
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/evolution-indicator/fix-message-count into
lp:evolution-indicator.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Just resets the message_count when evolution is shown or the user requests it
t
revno: 92
committer: Aurelien Gateau
branch nick: libindicate-qt
timestamp: Tue 2009-09-15 17:45:55 +0200
message:
Added a new indicator to show count
modified:
examples/qim-client.cpp
examples/qim-client.h
--
lp:libindicate-qt
h
revno: 93
committer: Aurelien Gateau
branch nick: libindicate-qt
timestamp: Wed 2009-09-16 10:38:45 +0200
message:
Added convenience methods for all known properties
modified:
examples/qim-client.cpp
src/qindicateindicator.cpp
sr
Ted Gould has proposed merging lp:~ted/indicator-messages/i18n into
lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adding in i18n support.
--
https://code.launchpad.net/~ted/indicator-messages/i18n/+merge/11828
Your team ayatana-commits i
Ted Gould has proposed merging lp:~ted/indicator-session/setlocale into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adding the calls to init gettext on the start of all the services and the
gtk-logout-helper.
--
https://code.launchpad.
revno: 87
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 17:45:44 +0200
message:
Show count
modified:
src/delegate.cpp
--
lp:plasma-indicatordisplay
https://code.launchpad.net/~agateau/pla
revno: 88
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 17:47:53 +0200
message:
Time should be presented if there is no count (not the reverse)
modified:
src/delegate.cpp
--
lp:plasma-ind
revno: 86
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 17:33:21 +0200
message:
Properly represent draw_attention indicator property.
modified:
src/indicatordisplay.cpp
src/indicatordispl
revno: 91
committer: Aurelien Gateau
branch nick: libindicate-qt
timestamp: Tue 2009-09-15 17:32:26 +0200
message:
Test 'draw attention'
modified:
examples/qim-client.cpp
--
lp:libindicate-qt
https://code.launchpad.net/~agateau/lib
revno: 90
committer: Aurelien Gateau
branch nick: libindicate-qt
timestamp: Tue 2009-09-15 17:15:24 +0200
message:
Show server
modified:
examples/qim-client.cpp
--
lp:libindicate-qt
https://code.launchpad.net/~agateau/libindicate-q
Cody Russell has proposed merging lp:~bratsche/xsplash/artwork-copyright into
lp:xsplash.
Requested reviews:
David Barth (dbarth)
--
https://code.launchpad.net/~bratsche/xsplash/artwork-copyright/+merge/11794
Your team ayatana-commits is subscribed to branch lp:xsplash.
=== added file 'COPYI
revno: 84
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 16:06:26 +0200
message:
Unbreak test
modified:
tests/listenermodeltest.cpp
--
lp:plasma-indicatordisplay
https://code.launchpad.net
revno: 83
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 15:56:48 +0200
message:
Implemented server-type filtering in ListenerModel.
Filter model does not work as it should.
modified:
src/
revno: 80
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 14:19:29 +0200
message:
debug--
modified:
src/filtermodel.cpp
--
lp:plasma-indicatordisplay
https://code.launchpad.net/~agateau/pla
revno: 85
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 16:42:06 +0200
message:
Fixed FilterModelTest
removed:
src/filtermodel.cpp
src/filtermodel.h
modified:
src/CMakeLists.txt
src/i
revno: 81
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 15:38:04 +0200
message:
Indicator count is not stored in server items anymore, no need to test this.
modified:
tests/listenermodeltes
revno: 139
author: Sebstien Bacher
committer: Ted Gould
branch nick: trunk
timestamp: Tue 2009-09-15 09:17:22 -0500
message:
Patch from Seb to init localization
modified:
src/messages-service.c
--
lp:indicator-messages
https://cod
Review: Approve
Looks good. Approved.
Fwiw, G_PARAM_STATIC_STRINGS is also a useful param in addition to the one you
use, it just means that the strings you used for the nick, blurb and
description are static, so glib doesn't copy them, just reference.
I normally always forget to use it, but I
revno: 79
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 14:16:56 +0200
message:
Reworked filter to filter out servers if they do not use the "messaging" type.
modified:
src/filtermodel.cpp
revno: 77
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 10:52:13 +0200
message:
Removed the "server indicator count" role
modified:
src/listenermodel.cpp
--
lp:plasma-indicatordisplay
htt
revno: 78
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 10:52:51 +0200
message:
Updated model dump code.
modified:
src/indicatordisplay.cpp
--
lp:plasma-indicatordisplay
https://code.laun
revno: 76
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Mon 2009-09-14 18:23:19 +0200
message:
Ported to latest changes in libindicate-qt
Added support for draw_attention and count to ListenerModel
modifi
Merge authors:
Mirco Müller (macslow)
Related merge proposals:
https://code.launchpad.net/~macslow/notify-osd/fix-375408/+merge/11779
proposed by: Mirco Müller (macslow)
review: Abstain - Mirco Müller (macslow)
review: Approve - Neil J. Patel (njpatel)
revno: 82
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Tue 2009-09-15 15:48:42 +0200
message:
Prettify model dump
modified:
src/indicatordisplay.cpp
src/modeldump.cpp
--
lp:plasma-indicatordisplay
ht
Mirco Müller has proposed merging lp:~macslow/notify-osd/fix-375408 into
lp:notify-osd.
Requested reviews:
Notify OSD Developers (notify-osd-developers)
Due to some people having huge multi-monitor setups the max. values for the
desktop-struts were to small causing bubbles being wrongly pos
Review: Approve
On Wed, 2009-09-16 at 11:00 +, Neil J. Patel wrote:
> Fixes two issues to do with showing accounts in the menu:
>
> 1. If the user has made an account inactive, make sure it doesn't show up, and
> 2. If an account doesn't have a configured way to receive email (i.e. its
> just
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-messages/i18n/+merge/11828
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Review: Approve
Looks good. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/setlocale/+merge/11825
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post
Review: Approve
On Wed, 2009-09-16 at 10:10 +, Neil J. Patel wrote:
> Just resets the message_count when evolution is shown or the
> user requests it to be shown, so the message count shown by
> the notification doesn't keep incrementing during a session.
Oh, a two line change! Did you run
Merge authors:
Sebastien Bacher (seb128)
Ted Gould (ted)
Related merge proposals:
https://code.launchpad.net/~ted/indicator-messages/i18n/+merge/11828
proposed by: Ted Gould (ted)
review: Approve - Neil J. Patel (njpatel)
revno:
The proposal to merge lp:~bratsche/xsplash/artwork-copyright into lp:xsplash
has been updated.
Status: Needs review => Superseded
--
https://code.launchpad.net/~bratsche/xsplash/artwork-copyright/+merge/11794
Your team ayatana-commits is subscribed to branch lp:xsplash.
Cody Russell has proposed merging lp:~bratsche/xsplash/artwork-copyright into
lp:xsplash.
--
https://code.launchpad.net/~bratsche/xsplash/artwork-copyright/+merge/11886
Your team ayatana-commits is subscribed to branch lp:xsplash.
=== added file 'COPYING.artwork'
--- COPYING.artwork 1970-01-01
Merge authors:
Neil J. Patel (njpatel)
Related merge proposals:
https://code.launchpad.net/~indicator-applet-developers/evolution-indicator/fix-message-count/+merge/11860
proposed by: Neil J. Patel (njpatel)
review: Approve - Ted Gould (ted)
Merge authors:
Neil J. Patel (njpatel)
Related merge proposals:
https://code.launchpad.net/~indicator-applet-developers/evolution-indicator/ignore-inactive-accounts/+merge/11864
proposed by: Neil J. Patel (njpatel)
review: Approve - Ted Gould (ted)
-
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/evolution-indicator/blacklist-support into
lp:evolution-indicator.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Creates/removes the blacklist file when appropriate.
--
https://code.launchpad.
revno: 95
tags: 0.2.1
committer: Aurelien Gateau
branch nick: libindicate-qt
timestamp: Wed 2009-09-16 16:58:25 +0200
message:
Added basic RELEASE_CHECK_LIST
added:
RELEASE_CHECK_LIST
--
lp:libindicate-qt
https://code.launchpad.net
revno: 94
committer: Aurelien Gateau
branch nick: libindicate-qt
timestamp: Wed 2009-09-16 16:58:15 +0200
message:
Updated
modified:
NEWS
--
lp:libindicate-qt
https://code.launchpad.net/~agateau/libindicate-qt/trunk
Your team ayat
On Wed, 2009-09-16 at 14:40 +, Neil J. Patel wrote:
> Creates/removes the blacklist file when appropriate.
You probably need to create USER_BLACKLIST_DIR as it won't always exist.
I don't think that build_filename will do that.
--
https://code.launchpad.net/~indicator-applet-developers/evolu
Ted Gould has proposed merging lp:~ted/indicator-session/designstuff into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Various changes recommend by the design team.
--
https://code.launchpad.net/~ted/indicator-session/designstuff/+merge/
revno: 90
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Wed 2009-09-16 17:20:43 +0200
message:
Fixed version number
modified:
NEWS
--
lp:plasma-indicatordisplay
https://code.launchpad.net/~agateau/plasm
revno: 89
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Wed 2009-09-16 17:20:02 +0200
message:
Updated
modified:
NEWS
--
lp:plasma-indicatordisplay
https://code.launchpad.net/~agateau/plasma-indicatordi
revno: 91
tags: 0.4.0
committer: Aurelien Gateau
branch nick: plasma-indicatordisplay
timestamp: Wed 2009-09-16 17:20:57 +0200
message:
Added RELEASE_CHECK_LIST doc
added:
RELEASE_CHECK_LIST
--
lp:plasma-indicatordisplay
https://co
Review: Approve
--
https://code.edge.launchpad.net/~bratsche/xsplash/daemon/+merge/11734
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpa
Merge authors:
Cody Russell (bratsche)
Related merge proposals:
https://code.launchpad.net/~bratsche/xsplash/daemon/+merge/11734
proposed by: Cody Russell (bratsche)
review: Approve - Ted Gould (ted)
review: Approve - Scott James Remnant (scott)
https://code.launchpad.net/~bratsche/xspl
David Barth has proposed merging lp:~dbarth/xsplash/artwork-licensing into
lp:xsplash.
Requested reviews:
Martin Pitt (pitti):
ayatana-commits (ayatana-commits)
--
https://code.launchpad.net/~dbarth/xsplash/artwork-licensing/+merge/11894
Your team ayatana-commits is subscribed to branch
David Barth has proposed merging lp:~dbarth/xsplash/timeout-option into
lp:xsplash.
Requested reviews:
Cody Russell (bratsche)
Timeout option to ease testing. May be a bit outdated with the new signal stuff.
--
https://code.launchpad.net/~dbarth/xsplash/timeout-option/+merge/11895
Your team
blacklist management should really be something done by the indicator-messages
itself then.
--
https://code.launchpad.net/~indicator-applet-developers/evolution-indicator/blacklist-support/+merge/11887
Your team ayatana-commits is subscribed to branch lp:evolution-indicator.
> On Wed, 2009-09-16 at 14:40 +, Neil J. Patel wrote:
> > Creates/removes the blacklist file when appropriate.
>
> You probably need to create USER_BLACKLIST_DIR as it won't always exist.
> I don't think that build_filename will do that.
Nice catch, I added support for that in rev 53. It seem
Review: Approve
/me is karma whore? Approved.
--
https://code.edge.launchpad.net/~bratsche/xsplash/add-signal/+merge/11898
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Review: Approve
--
https://code.launchpad.net/~dbarth/xsplash/timeout-option/+merge/11895
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchp
Cody Russell has proposed merging lp:~bratsche/xsplash/add-signal into
lp:xsplash.
Requested reviews:
Neil J. Patel (njpatel)
/me is karma whore? Approved.
--
https://code.launchpad.net/~bratsche/xsplash/add-signal/+merge/11898
Your team ayatana-commits is subscribed to branch lp:xsplash.
_
Merge authors:
Cody Russell (bratsche)
Related merge proposals:
https://code.launchpad.net/~bratsche/xsplash/add-signal/+merge/11898
proposed by: Cody Russell (bratsche)
review: Approve - Neil J. Patel (njpatel)
revno: 64 [merge]
The proposal to merge lp:~bratsche/xsplash/artwork-copyright into lp:xsplash
has been updated.
Status: Needs review => Superseded
--
https://code.launchpad.net/~bratsche/xsplash/artwork-copyright/+merge/11886
Your team ayatana-commits is subscribed to branch lp:xsplash.
Cody Russell has proposed merging lp:~bratsche/xsplash/artwork-copyright into
lp:xsplash.
--
https://code.launchpad.net/~bratsche/xsplash/artwork-copyright/+merge/11899
Your team ayatana-commits is subscribed to branch lp:xsplash.
=== added file 'COPYING.artwork'
--- COPYING.artwork 1970-01-01
Review: Approve
Looks good to me
--
https://code.launchpad.net/~bratsche/xsplash/artwork-copyright/+merge/11899
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-
Merge authors:
David Barth (dbarth)
Related merge proposals:
https://code.launchpad.net/~dbarth/xsplash/timeout-option/+merge/11895
proposed by: David Barth (dbarth)
review: Approve - Cody Russell (bratsche)
revno: 65 [merge]
comm
Review: Approve
Looks good to me. Approved.
--
https://code.edge.launchpad.net/~ted/indicator-session/designstuff/+merge/11893
Your team ayatana-commits is subscribed to branch lp:indicator-session.
___
Mailing list: https://launchpad.net/~ayatana-commi
Review: Approve
--
https://code.launchpad.net/~dbarth/xsplash/artwork-licensing/+merge/11894
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.laun
On Wed, 2009-09-16 at 15:53 +, David Barth wrote:
> blacklist management should really be something done by the
> indicator-messages itself then.
We've discussed making a utility to do it so there'd be something like:
$ indicator-messages-blacklist-add /path/to/my/desktopfile.desktop
and
Review: Approve
On Wed, 2009-09-16 at 15:55 +, Neil J. Patel wrote:
> Nice catch, I added support for that in rev 53. It seems to
> work fine when I remove any of the directories in the
> ~/.config/indicators/messages/applications-blacklist chain.
Looks good.
review approve
--
https://c
Review: Needs Fixing
Please add a line to point out to which files this license applies, since you
can't add that in a comment to the affected files (unlike *.c code files, which
usually have a header about the applicable license).
Otherwise it looks good, thanks!
--
https://code.edge.launchpad
revno: 66
committer: Ken VanDine
branch nick: xsplash
timestamp: Wed 2009-09-16 13:35:20 -0400
message:
version bump to 0.8.0
modified:
configure.ac
--
lp:xsplash
https://code.launchpad.net/~xsplash-team/xsplash/trunk
Your team ay
> Please add a line to point out to which files this license applies, since you
> can't add that in a comment to the affected files (unlike *.c code files,
> which usually have a header about the applicable license).
>
> Otherwise it looks good, thanks!
Ok, thanks for the comment. See rev. 64
--
Review: Approve
Thanks! Looks good
--
https://code.edge.launchpad.net/~dbarth/xsplash/artwork-licensing/+merge/11894
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : aya
Merge authors:
David Barth (dbarth)
Related merge proposals:
https://code.launchpad.net/~dbarth/xsplash/artwork-licensing/+merge/11894
proposed by: David Barth (dbarth)
review: Approve - Martin Pitt (pitti)
review: Approve - Cody Russell (bratsche)
revno: 68
tags: 0.8
committer: Ken VanDine
branch nick: xsplash
timestamp: Wed 2009-09-16 14:19:22 -0400
message:
0.8 instead of 0.8.0
modified:
configure.ac
--
lp:xsplash
https://code.launchpad.net/~xsplash-team/xsplash/trunk
You
revno: 69
committer: Ken VanDine
branch nick: xsplash
timestamp: Wed 2009-09-16 14:26:00 -0400
message:
Include COPYING.artwork in EXTRA_DIST
modified:
Makefile.am
--
lp:xsplash
https://code.launchpad.net/~xsplash-team/xsplash/trun
Ted Gould has proposed merging lp:~ted/indicator-session/available into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Changing the icon name to the proper one in the updated icon-naming spec.
--
https://code.launchpad.net/~ted/indicator-s
Cody Russell has proposed merging lp:~bratsche/xsplash/panel-above into
lp:xsplash.
Requested reviews:
Canonical Desktop Experience Team (canonical-dx-team)
--
https://code.launchpad.net/~bratsche/xsplash/panel-above/+merge/11944
Your team ayatana-commits is subscribed to branch lp:xsplash.
Review: Approve
--
https://code.edge.launchpad.net/~bratsche/xsplash/panel-above/+merge/11944
Your team ayatana-commits is subscribed to branch lp:xsplash.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.lau
Ted Gould has proposed merging lp:~ted/indicator-applet/python-v2work into
lp:indicator-applet/python0.2.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Making it so that the bindings work with libindicate v2
--
https://code.launchpad.net/~ted/indicator-applet/
Merge authors:
Cody Russell (bratsche)
Related merge proposals:
https://code.launchpad.net/~bratsche/xsplash/panel-above/+merge/11944
proposed by: Cody Russell (bratsche)
review: Approve - Ted Gould (ted)
revno: 70 [merge]
committ
75 matches
Mail list logo
