[Ayatana-commits] [Merge] lp:~mterry/dbusmenu/gtk3 into lp:dbusmenu

2010-06-22 Thread Ted Gould
The proposal to merge lp:~mterry/dbusmenu/gtk3 into lp:dbusmenu has been updated. Status: Needs review => Work in progress -- https://code.launchpad.net/~mterry/dbusmenu/gtk3/+merge/27992 Your team ayatana-commits is subscribed to branch lp:dbusmenu.

Re: [Ayatana-commits] [Merge] lp:~mterry/dbusmenu/gtk3 into lp:dbusmenu

2010-06-22 Thread Ted Gould
Hey, So while the patch looks fine I think we're going to have to make GTK 3 a conditional compile as we're in Ubuntu main, and GTK 3 will be in universe. Thank you for doing all this! Ted -- https://code.launchpad.net/~mterry/dbusmenu/gtk3/+merge/27992 Your team ayatana-commits is subscribed

[Ayatana-commits] [Branch ~dbusmenu-team/dbusmenu/trunk] Rev 119: Protect from unexpected arrays on the bus.

2010-06-22 Thread noreply
Merge authors: Ted Gould (ted) Related merge proposals: https://code.launchpad.net/~ted/dbusmenu/value-protection/+merge/28234 proposed by: Ted Gould (ted) review: Approve - Jason Smith (jassmith) review: Approve - David Barth (dbarth) -

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/value-protection into lp:dbusmenu

2010-06-22 Thread noreply
The proposal to merge lp:~ted/dbusmenu/value-protection into lp:dbusmenu has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~ted/dbusmenu/value-protection/+merge/28234 Your team ayatana-commits is subscribed to branch lp:dbusmenu.

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/value-protection into lp:dbusmenu

2010-06-22 Thread Jason Smith
Review: Approve +1 and appreciate the de-nesting of the code, makes it much easier to read. -- https://code.launchpad.net/~ted/dbusmenu/value-protection/+merge/28234 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https:

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/value-protection into lp:dbusmenu

2010-06-22 Thread David Barth
Review: Approve +1 -- https://code.launchpad.net/~ted/dbusmenu/value-protection/+merge/28234 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.laun

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/value-protection into lp:dbusmenu

2010-06-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/value-protection into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Not a fix, but stops it from crashing. -- https://code.launchpad.net/~ted/dbusmenu/value-protection/+merge/28234 Your team ayatana-commits is subscribed to bra

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/duplicate-separators into lp:appmenu-gtk

2010-06-22 Thread noreply
The proposal to merge lp:~bratsche/appmenu-gtk/duplicate-separators into lp:appmenu-gtk has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~bratsche/appmenu-gtk/duplicate-separators/+merge/28217 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. __

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/more-distcheckfixes into lp:indicator-sound

2010-06-22 Thread noreply
The proposal to merge lp:~cjcurran/indicator-sound/more-distcheckfixes into lp:indicator-sound has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~cjcurran/indicator-sound/more-distcheckfixes/+merge/28213 Your team ayatana-commits is subscribed to branch lp:indica

Re: [Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/duplicate-separators into lp:appmenu-gtk

2010-06-22 Thread Conor Curran
Review: Approve seems to do what it aims to -- https://code.launchpad.net/~bratsche/appmenu-gtk/duplicate-separators/+merge/28217 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/duplicate-separators into lp:appmenu-gtk

2010-06-22 Thread Cody Russell
Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/duplicate-separators into lp:appmenu-gtk. Requested reviews: Canonical Desktop Experience Team (canonical-dx-team) Related bugs: #594867 Duplicate separator items in app menus https://bugs.launchpad.net/bugs/594867 -- https://code

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/more-distcheckfixes into lp:indicator-sound

2010-06-22 Thread Cody Russell
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-sound/more-distcheckfixes/+merge/28213 Your team ayatana-commits is subscribed to branch lp:indicator-sound. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatan

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/more-distcheckfixes into lp:indicator-sound

2010-06-22 Thread Conor Curran
Conor Curran has proposed merging lp:~cjcurran/indicator-sound/more-distcheckfixes into lp:indicator-sound. Requested reviews: Indicator Applet Developers (indicator-applet-developers) make the vapi path in the makefile.am absolute and not relative -- https://code.launchpad.net/~cjcurran/ind

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk

2010-06-22 Thread noreply
The proposal to merge lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk has been updated. Status: Approved => Merged -- https://code.launchpad.net/~bratsche/appmenu-gtk/accelerators/+merge/28205 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. __

Re: [Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk

2010-06-22 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~bratsche/appmenu-gtk/accelerators/+merge/28205 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk

2010-06-22 Thread Ted Gould
The proposal to merge lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~bratsche/appmenu-gtk/accelerators/+merge/28205 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

Re: [Ayatana-commits] [Merge] lp:~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem into lp:dbusmenu

2010-06-22 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem/+merge/28204 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-co

Re: [Ayatana-commits] [Merge] lp:~bratsche/dbusmenu/fix-autogen into lp:dbusmenu

2010-06-22 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~bratsche/dbusmenu/fix-autogen/+merge/28200 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launch

[Ayatana-commits] [Branch ~dbusmenu-team/dbusmenu/trunk] Rev 118: Fixing the getting accel from a menu item.

2010-06-22 Thread noreply
Merge authors: Cody Russell (bratsche) Related merge proposals: https://code.launchpad.net/~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem/+merge/28204 proposed by: Cody Russell (bratsche) revno: 118 [merge] committer: Ted Gould

[Ayatana-commits] [Merge] lp:~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem into lp:dbusmenu

2010-06-22 Thread noreply
The proposal to merge lp:~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem into lp:dbusmenu has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem/+merge/28204 Your team ayatana-commits is subscribed to branch lp:dbusmen

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk

2010-06-22 Thread Cody Russell
Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk. Requested reviews: Canonical Desktop Experience Team (canonical-dx-team) Related bugs: #591293 Add support for keyboard shortcuts in menus https://bugs.launchpad.net/bugs/591293 -- https://code.la

[Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/accelerator-support into lp:indicator-appmenu

2010-06-22 Thread noreply
The proposal to merge lp:~ted/indicator-appmenu/accelerator-support into lp:indicator-appmenu has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~ted/indicator-appmenu/accelerator-support/+merge/28116 Your team ayatana-commits is subscribed to branch lp:indicator-

[Ayatana-commits] [Merge] lp:~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem into lp:dbusmenu

2010-06-22 Thread Cody Russell
Cody Russell has proposed merging lp:~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Related bugs: #591293 Add support for keyboard shortcuts in menus https://bugs.launchpad.net/bugs/591293 -- https://code.launchpad.net/

[Ayatana-commits] [Branch ~dbusmenu-team/dbusmenu/trunk] Rev 117: Autogen fix

2010-06-22 Thread noreply
Merge authors: Cody Russell (bratsche) Related merge proposals: https://code.launchpad.net/~bratsche/dbusmenu/fix-autogen/+merge/28200 proposed by: Cody Russell (bratsche) revno: 117 [merge] committer: Ted Gould branch nick: trunk

[Ayatana-commits] [Merge] lp:~bratsche/dbusmenu/fix-autogen into lp:dbusmenu

2010-06-22 Thread noreply
The proposal to merge lp:~bratsche/dbusmenu/fix-autogen into lp:dbusmenu has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~bratsche/dbusmenu/fix-autogen/+merge/28200 Your team ayatana-commits is subscribed to branch lp:dbusmenu.

[Ayatana-commits] [Merge] lp:~bratsche/dbusmenu/fix-autogen into lp:dbusmenu

2010-06-22 Thread Cody Russell
Cody Russell has proposed merging lp:~bratsche/dbusmenu/fix-autogen into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Related bugs: #597321 autogen.sh --prefix does not work. https://bugs.launchpad.net/bugs/597321 -- https://code.launchpad.net/~bratsche/dbusmenu/fix-auto

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/accelerator-support into lp:indicator-appmenu

2010-06-22 Thread Cody Russell
Review: Approve Hot! -- https://code.launchpad.net/~ted/indicator-appmenu/accelerator-support/+merge/28116 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : aya

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/refactoring_1 into lp:indicator-sound

2010-06-22 Thread noreply
The proposal to merge lp:~cjcurran/indicator-sound/refactoring_1 into lp:indicator-sound has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~cjcurran/indicator-sound/refactoring_1/+merge/28156 Your team ayatana-commits is subscribed to branch lp:indicator-sound.

[Ayatana-commits] [Branch ~indicator-applet-developers/evolution-indicator/trunk] Rev 63: merge evo 2.30 branch

2010-06-22 Thread noreply
Merge authors: Francesco Marella (francesco-marella) revno: 63 [merge] committer: Didier Roche branch nick: evolution-indicator timestamp: Tue 2010-06-22 15:06:22 +0200 message: merge evo 2.30 branch removed: src/e-shell.h modified

[Ayatana-commits] [Branch ~indicator-applet-developers/evolution-indicator/trunk] Rev 64: bump version for release

2010-06-22 Thread noreply
revno: 64 tags: 0.2.10 committer: Didier Roche branch nick: evolution-indicator timestamp: Tue 2010-06-22 15:08:42 +0200 message: bump version for release modified: configure.ac -- lp:evolution-indicator https://code.launchpad.net/

[Ayatana-commits] [Merge] lp:~dbarth/appmenu-gtk/check-property-existence into lp:appmenu-gtk

2010-06-22 Thread noreply
The proposal to merge lp:~dbarth/appmenu-gtk/check-property-existence into lp:appmenu-gtk has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~dbarth/appmenu-gtk/check-property-existence/+merge/28143 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/accelerator-support into lp:indicator-appmenu

2010-06-22 Thread David Barth
Maybe that works, but I haven't been able to see shortcuts displayed with the indicator-loader and the menu-pusher. I have the latest dbusmenu-gtk 0.3.2+r116+201006212038. -- https://code.launchpad.net/~ted/indicator-appmenu/accelerator-support/+merge/28116 Your team ayatana-commits is subscribe

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/refactoring_1 into lp:indicator-sound

2010-06-22 Thread Neil J. Patel
Review: Needs Fixing In addition to the comments about using the Value struct on IRC, - gchar* symbol = transport_widget_toggle_play_label(d need to g_free (symbol) afterwards? - In signal callbacks like transport_widget_button_release_event, I'd suggest doing a g_return_if_fail (FOO_IS_BAR

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/refactoring_1 into lp:indicator-sound

2010-06-22 Thread Conor Curran
Conor Curran has proposed merging lp:~cjcurran/indicator-sound/refactoring_1 into lp:indicator-sound. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Refactors the vala code base making it far more oop. -- https://code.launchpad.net/~cjcurran/indicator-sound/ref

Re: [Ayatana-commits] [Merge] lp:~dbarth/appmenu-gtk/check-property-existence into lp:appmenu-gtk

2010-06-22 Thread Mikkel Kamstrup Erlandsen
Review: Approve Looks good to me -- https://code.launchpad.net/~dbarth/appmenu-gtk/check-property-existence/+merge/28143 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~dbarth/appmenu-gtk/check-property-existence into lp:appmenu-gtk

2010-06-22 Thread David Barth
David Barth has proposed merging lp:~dbarth/appmenu-gtk/check-property-existence into lp:appmenu-gtk. Requested reviews: Canonical Desktop Experience Team (canonical-dx-team) Fixes GTK apps not sending their menu to the panel unless they have a ubuntu-no-proxy property in their window. -- h