Review: Approve
A bug in bamf, or simply a timing issue where events are not delivered in the
expected order.
The code chnages sound safe, so I'm ok to test it on trunk for a day or two for
consideration as a maverick fix.
--
https://code.launchpad.net/~ted/indicator-appmenu/bamf-window-refs/+m
Review: Approve
+1 for the change.
Getting a trace of the crash would help make the code even more robust. Can you
share that on a bug report please?
--
https://code.launchpad.net/~ted/indicator-appmenu/better-dbus-error-handling/+merge/35876
Your team ayatana-commits is subscribed to branch lp:i
Oh, also I would have tried factoring the dbus_proxy code into just one method,
to avoid duplication of the registration logic.
--
https://code.launchpad.net/~ted/indicator-appmenu/better-dbus-error-handling/+merge/35876
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Review: Approve
Moving on with the merge proposal: +1, as anyway it's a new feature, so the
submenu restriction doesn't impact existing code.
--
https://code.launchpad.net/~ted/dbusmenu/about-to-show-is-activate/+merge/35892
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
Review: Approve
LGTM
--
https://code.launchpad.net/~ted/indicator-appmenu/indicator-about-to-show/+merge/35888
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ted/indicator-applet/send-to-show/+merge/35960
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commit
Review: Approve
+1
--
https://code.launchpad.net/~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly/+merge/36062
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list: https://launchpad.net/~ayatana
The proposal to merge lp:~ted/indicator-appmenu/bamf-window-refs into
lp:indicator-appmenu has been updated.
Status: Needs review => Approved
--
https://code.launchpad.net/~ted/indicator-appmenu/bamf-window-refs/+merge/35874
Your team ayatana-commits is subscribed to branch lp:indicator-appm
The proposal to merge
lp:~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly into
lp:indicator-appmenu has been updated.
Status: Needs review => Approved
--
https://code.launchpad.net/~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly/+merge/36062
Your
The proposal to merge lp:~ted/indicator-appmenu/better-dbus-error-handling into
lp:indicator-appmenu has been updated.
Status: Needs review => Approved
--
https://code.launchpad.net/~ted/indicator-appmenu/better-dbus-error-handling/+merge/35876
Your team ayatana-commits is subscribed to bran
The proposal to merge lp:~ted/indicator-appmenu/better-dbus-error-handling into
lp:indicator-appmenu has been updated.
Status: Approved => Merged
--
https://code.launchpad.net/~ted/indicator-appmenu/better-dbus-error-handling/+merge/35876
Your team ayatana-commits is subscribed to branch lp:
The proposal to merge lp:~ted/indicator-appmenu/bamf-window-refs into
lp:indicator-appmenu has been updated.
Status: Approved => Merged
--
https://code.launchpad.net/~ted/indicator-appmenu/bamf-window-refs/+merge/35874
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
The proposal to merge
lp:~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly into
lp:indicator-appmenu has been updated.
Status: Approved => Merged
--
https://code.launchpad.net/~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly/+merge/36062
Your team
Neil J. Patel has proposed merging
lp:~indicator-applet-developers/indicator-appmenu/one-more-xerror-fix into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Some uninitialized pointer fun.
--
https://code.launchpad.net/~indicator-applet-de
Review: Approve
--
https://code.launchpad.net/~indicator-applet-developers/indicator-appmenu/one-more-xerror-fix/+merge/36149
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list: https://launchpad.net/~ayatana-commi
The proposal to merge
lp:~indicator-applet-developers/indicator-appmenu/one-more-xerror-fix into
lp:indicator-appmenu has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~indicator-applet-developers/indicator-appmenu/one-more-xerror-fix/+merge/36149
Your team ayat
The proposal to merge
lp:~directhex/indicator-application/gapi_is_a_pile_of_shit into
lp:indicator-application has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~directhex/indicator-application/gapi_is_a_pile_of_shit/+merge/35963
Your team ayatana-commits is sub
On Mon, 2010-09-20 at 15:51 +, David Barth wrote:
> What's the rational for not sending activate signals if there are no submenus?
Basically because GTK doesn't separate between "about to show" and
"activate." So it seems that some people (Shotwell) are using the
"activate" signal as about-to
On Tue, 2010-09-21 at 09:54 +, David Barth wrote:
> A bug in bamf, or simply a timing issue where events are not
> delivered in the expected order.
I don't think it actually happens, but Jason was concerned about it
after reviewing the code. No reason not to be safe.
--
https://code.launch
revno: 162
committer: Ted Gould
branch nick: trunk
timestamp: Tue 2010-09-21 11:42:28 -0500
message:
Adding in ChangeLog and AUTHORS dist-hooks
modified:
Makefile.am
--
lp:dbusmenu
https://code.launchpad.net/~dbusmenu-team/dbusmenu
David Barth has proposed merging lp:~dbarth/indicator-me/hint-fixes into
lp:indicator-me.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
- style the hint consistently, even across service restarts
- forgot to add me-service-gwibber.c for translations
--
https://
Review: Approve
Probably should drop some of teh debugging messages out of
"finalized_dbusmenuitem_cb" but otherwise it looks good.
--
https://code.launchpad.net/~dbarth/indicator-me/hint-fixes/+merge/36170
Your team ayatana-commits is subscribed to branch lp:indicator-me.
__
Ted Gould has proposed merging lp:~ted/indicator-appmenu/mnemonic-fix into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixes the issue where all the underscores show up from KDE apps. Annoying as
hell.
--
https://code.launchpad.net/~te
The line
'/usr/lib/cli/appindicator-sharp-0.1/policy.0.1.appindicator-sharp.dll' has to
be added to the 'libappindicator0.1-cil.installcligac' file in the /debian
directory to make this work for the packaging.
This is required to prevent applications depending on 'appindicator-sharp' from
havin
revno: 371
committer: Ted Gould
branch nick: applet
timestamp: Tue 2010-09-21 14:47:29 -0500
message:
Making ChangeLog and AUTHORS built at dist time
modified:
AUTHORS
ChangeLog
Makefile.am
--
lp:indicator-applet
https://code.l
Review: Approve
And there was much rejoicing!
--
https://code.launchpad.net/~ted/indicator-appmenu/mnemonic-fix/+merge/36176
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list: https://launchpad.net/~ayatana-commit
revno: 199
committer: Ted Gould
branch nick: trunk
timestamp: Tue 2010-09-21 16:10:56 -0500
message:
Building ChangeLog and AUTHORS from makefile
modified:
AUTHORS
ChangeLog
Makefile.am
--
lp:indicator-messages
https://code.lau
Merge authors:
Ted Gould (ted)
Related merge proposals:
https://code.launchpad.net/~ted/indicator-applet/send-to-show/+merge/35960
proposed by: Ted Gould (ted)
review: Approve - David Barth (dbarth)
revno: 372 [merge]
committer: T
The proposal to merge lp:~ted/indicator-applet/send-to-show into
lp:indicator-applet has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~ted/indicator-applet/send-to-show/+merge/35960
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
The proposal to merge lp:~ted/indicator-appmenu/indicator-about-to-show into
lp:indicator-appmenu has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~ted/indicator-appmenu/indicator-about-to-show/+merge/35888
Your team ayatana-commits is subscribed to branch lp:in
The proposal to merge lp:~ted/indicator-appmenu/mnemonic-fix into
lp:indicator-appmenu has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~ted/indicator-appmenu/mnemonic-fix/+merge/36176
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
The proposal to merge lp:~ted/dbusmenu/about-to-show-is-activate into
lp:dbusmenu has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~ted/dbusmenu/about-to-show-is-activate/+merge/35892
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
__
Merge authors:
Ted Gould (ted)
Related merge proposals:
https://code.launchpad.net/~ted/dbusmenu/about-to-show-is-activate/+merge/35892
proposed by: Ted Gould (ted)
review: Approve - David Barth (dbarth)
revno: 163 [merge]
commit
Jason Smith has proposed merging
lp:~jassmith/indicator-appmenu/ensure-non-closed-windows into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Requires latest bamf trunk
--
https://code.launchpad.net/~jassmith/indicator-appmenu/ensure-non-c
Cody Russell has proposed merging
lp:~bratsche/indicator-me/disconnect-some-signals into lp:indicator-me.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#643906 indicator-me may crash after service restart
https://bugs.launchpad.net/bugs/643906
-
35 matches
Mail list logo
