Conor Curran has proposed merging lp:~cjcurran/indicator-sound/ambiance-fix
into lp:indicator-sound.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Refactors the drawing of the transport controls
- collapse into one gtkmenuitem object
- Simplify design.
- ind
The proposal to merge lp:~cjcurran/indicator-sound/ambiance-fix into
lp:indicator-sound has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~cjcurran/indicator-sound/ambiance-fix/+merge/37149
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
__
Review: Approve
Looks good. One thing I'd tweak is that, when connecting to the notify signal,
your only interested in the "parent" property, so instead of doing:
g_signal_connect (object, "notify",
You should do:
g_signal_connect (object, "notify::parent",
The former connects to all
3 matches
Mail list logo
