Review: Needs Fixing
1. we don't appear to use error except for testing for failure, and on
failure list will be NULL anyway so that test is redundant. Let's remove the
error variable altogether.
2. g_slist_free() is NULL-safe, so there if (list != NULL) test before
g_slist_free(list) is
Review: Approve
Javier, I'm going to move your code into the standalone function to fix the
'evo' memory leak and merge. I hope you don't mind this -- I want to make sure
your fix gets in before the deadline.
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-836017/+merge/77932
Yeah, sure. I think is a good idea
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-836017/+merge/77932
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post
Review: Resubmit
Ok, lets be super-sure to free the possible returned list
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-836017/+merge/77932
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
___
Mailing list:
Javier Jardón has proposed merging lp:~jjardon/indicator-datetime/fix-836017
into lp:indicator-datetime.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
Bug #836017 in Indicator Date and Time: Add Event on Time Menu opens
Evolution Setup Assistant
Review: Needs Fixing
Hi Javier! You need to free the GSlist *accounts_list with:
if (accounts_list)
g_slist_free (accounts_list);
before setting it to NULL.
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-836017/+merge/77932
Your team ayatana-commits is subscribed to branch
Review: Resubmit
Thanks for the review Andrea, Could you take a look to this new patch?
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-836017/+merge/77932
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
___
Review: Needs Information
It depends... if error is != NULL it enters the first if but not the second, so
accounts_list is set to NULL and not free'd. Now, it could be that if error is
!= NULL then accounts_list is NULL and it does not need to be free'd, so your
code is not leaking.
However,
8 matches
Mail list logo
