Javier Jardón has proposed merging lp:~jjardon/indicator-datetime/fix-833325
into lp:indicator-datetime.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
Bug #833325 in Indicator Date and Time: "Timezones not in time order"
https://bugs.launchpad.ne
Review: Needs Information
Could you walk me through how that works? I'm not seeing the connection.
I believe the OP is referring to the menu items shown between"Add Event..." and
"Time & Date Settings..." in the indicator. I don't (yet) see their relation to
the locationsDialog treemodel...?
--
Sure
The cities are added in the datetime-prefs-locations.c dialog.
The list of cities are saved in the SETTINGS_LOCATIONS_S GSettings key, getting
the contents of the current treemodel, as you can see here:
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk/view/h
That wouldn't solve the issue for out-of-order keys that have already been
saved to GSettings, or the case when a timezone's offset changes due to DST or
other reasons.
Wouldn't it be better to sort these in datetime-service.c after loading them
from GSettings?
--
https://code.launchpad.net/~j
Review: Needs Fixing
This doesn't appear to address the OP's issue. Judging from the screenshot,
he's referring to the "Other Locations" times displayed in the indicator.
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-833325/+merge/78281
Your team ayatana-commits is subscribed to
Yeah, and the order of the "Other Locations" list is the order of the
locationsDialog treemodel
--
https://code.launchpad.net/~jjardon/indicator-datetime/fix-833325/+merge/78281
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
_
6 matches
Mail list logo
