[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix imbalanced locking in gw_node_update

2011-04-01 Thread Sven Eckelmann
8ffdea813e32cee3c60be36fb9e6a5e077e51ea0 used rcu_read_unlock without using rcu_read_lock when gw_get_selected_gw_node didn't return a valid gw_node. Signed-off-by: Sven Eckelmann s...@narfation.org --- gateway_client.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Add missing static for softif_neigh_deselect

2011-04-01 Thread Sven Eckelmann
053e6e6c30c161c218eacf2eb2eb4c7ecc0f387c forgot to mark the only locally used function softif_neigh_deselect as static. Signed-off-by: Sven Eckelmann s...@narfation.org --- soft-interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/soft-interface.c

[B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Fix imbalanced locking in gw_node_update

2011-04-01 Thread Sven Eckelmann
8ffdea813e32cee3c60be36fb9e6a5e077e51ea0 used rcu_read_unlock without using rcu_read_lock when gw_get_selected_gw_node didn't return a valid gw_node. Signed-off-by: Sven Eckelmann s...@narfation.org --- Maybe the other patch is useful in the future... but changing the goto to a return is less

Re: [B.A.T.M.A.N.] [PATCH 1/2] batctl: Remove obsolete creation of source packages

2011-04-01 Thread Marek Lindner
On Thursday 31 March 2011 18:11:37 Sven Eckelmann wrote: The creation of source packages is now either done by the release team using special scripts or through gitweb. It is not needed to provide the source target inside the Makefile and may not work in the future anyway. Applied in revision

Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: Remove subversion/svk revision information

2011-04-01 Thread Marek Lindner
On Thursday 31 March 2011 18:11:39 Sven Eckelmann wrote: The current version of batctl cannot be obtained from subversion or svk anymore. It is unnecessary to provide the functionality to retrieve the current revision using these tools. We only have to differenciate between git checkout and

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove subversion/svk revision information

2011-04-01 Thread Marek Lindner
On Thursday 31 March 2011 18:11:38 Sven Eckelmann wrote: The current version of batman-adv cannot be obtained from subversion or svk anymore. It is unnecessary to provide the functionality to retrieve the current revision using these tools. We only have to differenciate between git checkout

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Add missing static for softif_neigh_deselect

2011-04-01 Thread Marek Lindner
On Friday 01 April 2011 08:49:18 Sven Eckelmann wrote: 053e6e6c30c161c218eacf2eb2eb4c7ecc0f387c forgot to mark the only locally used function softif_neigh_deselect as static. Applied in revision ga9125b6. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix imbalanced locking in gw_node_update

2011-04-01 Thread Marek Lindner
On Friday 01 April 2011 08:49:19 Sven Eckelmann wrote: 8ffdea813e32cee3c60be36fb9e6a5e077e51ea0 used rcu_read_unlock without using rcu_read_lock when gw_get_selected_gw_node didn't return a valid gw_node. Applied a slightly modified variant in revision g76eab02. Thanks, Marek PS: I prefer