Re: [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful

2011-04-17 Thread Simon Wunderlich
Applied in eee3fc6, thanks Simon On Wed, Apr 13, 2011 at 05:27:00PM +0200, Marek Lindner wrote: Reported-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- sys.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[B.A.T.M.A.N.] pull request: batman-adv 2011-04-17

2011-04-17 Thread Sven Eckelmann
Hi, I would like to propose following patches for net-next-2.6/2.6.40. Most of the stuff is cleanup work to reduce the locking complexity. The only exception is Andrew Lunn's patch, which only adds the initialisation of tx_queue_len. thanks, Sven The following changes since commit

[B.A.T.M.A.N.] [PATCH 1/8] batman-adv: Move bonding / iface alternating router search to own functions

2011-04-17 Thread Sven Eckelmann
From: Linus Lüssing linus.luess...@web.de This decreases the size of find_router() by outsourcing the router search for the bonding and interface alternating modes to their own sub functions. This shall make it easier to keep track of the correct refcounting later. Signed-off-by: Linus Lüssing

[B.A.T.M.A.N.] [PATCH 3/8] batman-adv: Simplify gw_check_election(), use gw_get_selected()

2011-04-17 Thread Sven Eckelmann
From: Linus Lüssing linus.luess...@web.de gw_get_selected() can get us the desired orig_node directly, therefore reusing that function in gw_check_election(). Signed-off-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Make gateway_get_selected type safe

2011-04-17 Thread Sven Eckelmann
From: Linus Lüssing linus.luess...@web.de Make the return value explicit instead of (void *). Signed-off-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/gateway_client.c |2 +-

[B.A.T.M.A.N.] [PATCH 4/8] batman-adv: Make orig_node-router an rcu protected pointer

2011-04-17 Thread Sven Eckelmann
From: Linus Lüssing linus.luess...@web.de The rcu protected macros rcu_dereference() and rcu_assign_pointer() for the orig_node-router need to be used, as well as spin/rcu locking. Otherwise we might end up using a router pointer pointing to already freed memory. Therefore this commit introduces

[B.A.T.M.A.N.] [PATCH 5/8] batman-adv: Protect global TQ window with a spinlock

2011-04-17 Thread Sven Eckelmann
From: Linus Lüssing linus.luess...@web.de Signed-off-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/originator.c |1 + net/batman-adv/routing.c|4

[B.A.T.M.A.N.] [PATCH 6/8] batman-adv: concentrate all curr_gw related rcu operations in select/deselect functions

2011-04-17 Thread Sven Eckelmann
From: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/gateway_client.c | 176 ++- net/batman-adv/gateway_client.h |2 +- net/batman-adv/unicast.c

[B.A.T.M.A.N.] [PATCH 7/8] batman-adv: protect softif_neigh by rcu

2011-04-17 Thread Sven Eckelmann
From: Simon Wunderlich s...@hrz.tu-chemnitz.de Add get/set wrapper functions for softif_neigh and use rcu functions to manipulate the pointers. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCH 8/8] batman-adv: Set the txqueuelen to zero when creating soft interface

2011-04-17 Thread Sven Eckelmann
From: Andrew Lunn and...@lunn.ch Like other virtual interfaces, e.g. br0, we don't need a transmit queue. Packets should only be queued on real interfaces which are underneath. In practice this patch makes little difference since the virtual interfaces can accept packets as fast as they come, but

Re: [B.A.T.M.A.N.] pull request: batman-adv 2011-04-17

2011-04-17 Thread David Miller
From: Sven Eckelmann s...@narfation.org Date: Sun, 17 Apr 2011 21:30:10 +0200 I would like to propose following patches for net-next-2.6/2.6.40. Most of the stuff is cleanup work to reduce the locking complexity. The only exception is Andrew Lunn's patch, which only adds the initialisation of