Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: improved client announcement mechanismy

2011-04-30 Thread Andrew Lunn
On Wed, Apr 27, 2011 at 11:35:04PM +0200, Antonio Quartulli wrote: The old HNA mechanism has been totally rewritten from scratch. The new mechanism consists in announcing local translation-table changes only, reducing the protocol overhead. Hi Antonia For details, please visit:

Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: improved client announcement mechanismy

2011-04-30 Thread Antonio Quartulli
On sab, apr 30, 2011 at 10:42:26 +0200, Andrew Lunn wrote: Hi Antonia Hi Andrew, hi all (don't worry for the typo ;) ) For details, please visit: http://www.open-mesh.org/wiki/batman-adv/Hna-improvements This is a nice summary of the idea. The LaTeX document is also good. Great to see

[B.A.T.M.A.N.] [PATCHv2 1/3] batman-adv: Fix crash on module shutdown with multiple ifaces

2011-04-30 Thread Sven Eckelmann
From: Linus Lüssing linus.luess...@web.de hardif_remove_interfaces() removes all hard interfaces from the hardif_list before freeing and cleaning up any device. However the clean up procedures in orig_hash_del_if() (hardif_remove_interface()-hardif_disable_interface()- orig_hash_del_if()) need

[B.A.T.M.A.N.] [PATCHv2 2/3] batman-adv: Remove unnecessary hardif_list_lock

2011-04-30 Thread Sven Eckelmann
hardif_list_lock is unneccessary because we already ensure that no multiple admin operations can take place through rtnl_lock. hardif_list_lock only adds additional overhead and complexity. Critical functions now check whether they are called with rtnl_lock using ASSERT_RTNL. Signed-off-by: Sven

Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: improved client announcement mechanismy

2011-04-30 Thread Andrew Lunn
You indentation/wrapping is a bit strange. In the function declaration, i would of put the int tt_num_changes directly under int buff_pos. This is what I've done, but it seems that your mail client is messing up with the tabs (I think). Possibly. Or the list server. I use mutt, same as