[B.A.T.M.A.N.] B.A.T.M.A.N. Developer Meeting

2011-05-02 Thread Linus Lüssing
Hi everyone, During the last Wireless Battlemesh a lot of conceptual protocol discussions as well as batman-adv kernel-hacking took place. Therefore also the question came up where and when would be the best place and time to meet next. The first idea was to meet at the Wireless Community

[B.A.T.M.A.N.] [PATCH] batman-adv: remove misplaced comment

2011-05-02 Thread Marek Lindner
Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- originator.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/originator.c b/originator.c index ef4a9be..51af91b 100644 --- a/originator.c +++ b/originator.c @@ -19,8 +19,6 @@ * */ -/* increase the reference

[B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include

2011-05-02 Thread Marek Lindner
Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- compat.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/compat.h b/compat.h index 0c5ad82..bddf7e2 100644 --- a/compat.h +++ b/compat.h @@ -26,7 +26,6 @@ #define _NET_BATMAN_ADV_COMPAT_H_ #include

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove misplaced comment

2011-05-02 Thread Sven Eckelmann
On Monday 02 May 2011 16:38:17 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- originator.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/originator.c b/originator.c index ef4a9be..51af91b 100644 --- a/originator.c +++

Re: [B.A.T.M.A.N.] B.A.T.M.A.N. Developer Meeting

2011-05-02 Thread Linus Lüssing
On Mon, May 02, 2011 at 03:25:36PM +0200, Antonio Quartulli wrote: Hi all, On lun, mag 02, 2011 at 03:10:44 +0200, Linus Lüssing wrote: Therefore the second idea was to have a dedicated B.A.T.M.A.N. developer meeting between these two dates. Great ;) Place: Lübeck (near Hamburg,

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include

2011-05-02 Thread Sven Eckelmann
On Monday 02 May 2011 16:53:44 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de [] #include linux/version.h /* LINUX_VERSION_CODE */ -#include bat_sysfs.h /* struct bat_attribute */ This is necessary for kernels older than 2.6.24 make -C

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include

2011-05-02 Thread Marek Lindner
On Monday 02 May 2011 17:02:32 Sven Eckelmann wrote: On Monday 02 May 2011 16:53:44 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de [] #include linux/version.h /* LINUX_VERSION_CODE */ -#include bat_sysfs.h /* struct bat_attribute */

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include

2011-05-02 Thread Sven Eckelmann
On Monday 02 May 2011 17:09:31 Marek Lindner wrote: On Monday 02 May 2011 17:02:32 Sven Eckelmann wrote: On Monday 02 May 2011 16:53:44 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de [] #include linux/version.h /* LINUX_VERSION_CODE */

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include

2011-05-02 Thread Sven Eckelmann
On Monday 02 May 2011 17:09:31 Marek Lindner wrote: On Monday 02 May 2011 17:02:32 Sven Eckelmann wrote: On Monday 02 May 2011 16:53:44 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de [] #include linux/version.h /* LINUX_VERSION_CODE */

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include

2011-05-02 Thread Antonio Quartulli
On Mon, May 02, 2011 at 05:27:36PM +0200, Sven Eckelmann wrote: On Monday 02 May 2011 17:09:31 Marek Lindner wrote: On Monday 02 May 2011 17:02:32 Sven Eckelmann wrote: On Monday 02 May 2011 16:53:44 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de []

Re: [B.A.T.M.A.N.] [PATCHv3 2/3] batman-adv: Remove unnecessary hardif_list_lock

2011-05-02 Thread Linus Lüssing
Looks quite good and seems to make sense to avoid the double-locking. Tested it here and together with patch 1/3 fixes the initial issue, too. Just one minor thing: [58518.225154] batman_adv: bat0: The MTU of interface eth1 is too small (1500) to handle the transport of batman-adv packets.

Re: [B.A.T.M.A.N.] [PATCHv2 3/3] batman-adv: Avoid deadlock between rtnl_lock and s_active

2011-05-02 Thread Linus Lüssing
Looks good, seems to make sense and tried it. Works so far with no call traces or other uggly stuff. However I'm still trying to reproduce the initial issue of ticket #145 to confirm that this patch fixes it (used a different kernel and batman-adv version back then, of course... so somehow the

Re: [B.A.T.M.A.N.] [PATCHv2 3/3] batman-adv: Avoid deadlock between rtnl_lock and s_active

2011-05-02 Thread Linus Lüssing
Ok, could reproduce and verify it now (latest master branch _without_ patches 1/3 and 2/3, with that version I can still reproduce that issue reliably). Putting only patch 3/3 on top the master branch then fixes that locking dependancy. Thanks, Sven! Cheers, Linus On Mon, May 02, 2011 at

Re: [B.A.T.M.A.N.] [PATCHv2 1/3] batman-adv: Fix crash on module shutdown with multiple ifaces

2011-05-02 Thread Linus Lüssing
On Sat, Apr 30, 2011 at 06:56:58PM +0200, Sven Eckelmann wrote: From: Linus Lüssing linus.luess...@web.de hardif_remove_interfaces() removes all hard interfaces from the hardif_list before freeing and cleaning up any device. However the clean up procedures in orig_hash_del_if()

Re: [B.A.T.M.A.N.] [PATCHv3 2/3] batman-adv: Remove unnecessary hardif_list_lock

2011-05-02 Thread Sven Eckelmann
Linus Lüssing wrote: Looks quite good and seems to make sense to avoid the double-locking. Tested it here and together with patch 1/3 fixes the initial issue, too. Just one minor thing: [58518.225154] batman_adv: bat0: The MTU of interface eth1 is too small (1500) to handle the

[B.A.T.M.A.N.] [PATCHv4 1/2] batman-adv: Remove unnecessary hardif_list_lock

2011-05-02 Thread Sven Eckelmann
hardif_list_lock is unneccessary because we already ensure that no multiple admin operations can take place through rtnl_lock. hardif_list_lock only adds additional overhead and complexity. Critical functions now check whether they are called with rtnl_lock using ASSERT_RTNL. It indirectly fixes

[B.A.T.M.A.N.] [PATCHv4 2/2] batman-adv: Avoid deadlock between rtnl_lock and s_active

2011-05-02 Thread Sven Eckelmann
The hard_if_event is called by the notifier with rtnl_lock and tries to remove sysfs entries when a NETDEV_UNREGISTER event is received. This will automatically take the s_active lock. The s_active lock is also used when a new interface is added to a meshif through sysfs. In that situation we

Re: [B.A.T.M.A.N.] B.A.T.M.A.N. Developer Meeting

2011-05-02 Thread Simon Wunderlich
Hey Linus, this sounds great, I would really like to join. My preferred date would be June 30th to July 3rd, I already have tickets for an event on July 9th unfortunately. The weekends after July 9th (like 16th, 23th) are also available for me. :) Sounds like the others prefer the first date?

Re: [B.A.T.M.A.N.] pull request: batman-adv 2011-05-01

2011-05-02 Thread David Miller
From: Sven Eckelmann s...@narfation.org Date: Sun, 1 May 2011 23:10:30 +0200 I would like to propose following patches for net-next-2.6/2.6.40. Marek Lindner continued to convert different datastructures to use RCU. Antonio Quartulli fixed an important bug introduced in the last patchset