160dd1399c4d589c0c5678a759e8ac7a7eefe64e introduced a line over 80 and
can not be accepted according to the Linux Coding Style.
Signed-off-by: Sven Eckelmann s...@narfation.org
---
translation-table.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/translation-table.c
It is slightly irritating that comments after a long line span over
multiple lines without any code. It is easier to put them before the
actual code and reduce the number of lines which the eye has to read.
Signed-off-by: Sven Eckelmann s...@narfation.org
---
This patch makes batman-adv nearly
Signed-off-by: Sven Eckelmann s...@narfation.org
---
packet.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/packet.h b/packet.h
index c225c3a..eda9965 100644
--- a/packet.h
+++ b/packet.h
@@ -128,8 +128,7 @@ struct vis_packet {
uint8_t entries;/*
On Sunday 08 May 2011 09:39:55 Sven Eckelmann wrote:
160dd1399c4d589c0c5678a759e8ac7a7eefe64e introduced a line over 80 and
can not be accepted according to the Linux Coding Style.
Applied in revision 6ffb0a7.
Thanks,
Marek
On Saturday 07 May 2011 21:48:03 Sven Eckelmann wrote:
bat_sysfs.h is included in compat.h to provide bat_attribute which is
used in bat_wrapper_show and bat_wrapper_store. This could create a
include loop which prevents that functions or datastructures defined
elsewhere cannot be found in
On Saturday 07 May 2011 21:48:04 Sven Eckelmann wrote:
Signed-off-by: Sven Eckelmann s...@narfation.org
Applied in revision 7b1ce30.
Thanks,
Marek
On Sunday 08 May 2011 12:45:45 Sven Eckelmann wrote:
It is slightly irritating that comments after a long line span over
multiple lines without any code. It is easier to put them before the
actual code and reduce the number of lines which the eye has to read.
Applied in revision 4d910ca.
On Sunday 08 May 2011 12:45:46 Sven Eckelmann wrote:
Signed-off-by: Sven Eckelmann s...@narfation.org
Applied in revision 701e35a.
Thanks,
Marek
Hi Daniele
It is not a real Link State routing, the document maybe is not
completely clear. Every node before the OGM rebroadcast, attach its
current best path toward the originator node. I could do this
without adding an hop list, but simply substituting the TQ with PCE.
How you tried
On Saturday 07 May 2011 22:45:19 Sven Eckelmann wrote:
From: Daniele Furlan daniele.fur...@gmail.com
In function is_bidirectional_neigh the code that find out the one hop
neighbor is duplicated.
Applied in revision fea56a5.
Thanks,
Marek
Hi,
* The concept of attaching all hops and their information to the OGM
brings us dangerously close to the problems other routing protocols
suffer from (especially Link State): The more a node is away from the
source the more its information are outdated. Imagine a 10 hop path -
how
2011/5/8 Andrew Lunn and...@lunn.ch:
Hi Daniele
It is not a real Link State routing, the document maybe is not
completely clear. Every node before the OGM rebroadcast, attach its
current best path toward the originator node. I could do this
without adding an hop list, but simply
2011/5/8 Marek Lindner lindner_ma...@yahoo.de:
Hi,
* The concept of attaching all hops and their information to the OGM
brings us dangerously close to the problems other routing protocols
suffer from (especially Link State): The more a node is away from the
source the more its
Hi,
I would like to propose following patches for net-next-2.6/2.6.40. They
include minor cleanups of comments, a big rename patch s/hna/tt/, but
also a remove some duplicated code. The spinlock which protected the
list of possible interfaces for batman-adv was completely replaced by
rtnl_lock
From: Marek Lindner lindner_ma...@yahoo.de
The bridge loop detection for batman-adv allows the bat0 interface
to be bridged into an ethernet segment which other batman-adv nodes
are connected to. In order to also allow multiple VLANs on top of
the bat0 interface to be bridged into the ethernet
hardif_list_lock is unneccessary because we already ensure that no
multiple admin operations can take place through rtnl_lock.
hardif_list_lock only adds additional overhead and complexity.
Critical functions now check whether they are called with rtnl_lock
using ASSERT_RTNL.
It indirectly fixes
The hard_if_event is called by the notifier with rtnl_lock and tries to
remove sysfs entries when a NETDEV_UNREGISTER event is received. This
will automatically take the s_active lock.
The s_active lock is also used when a new interface is added to a meshif
through sysfs. In that situation we
From: Marek Lindner lindner_ma...@yahoo.de
Signed-off-by: Marek Lindner lindner_ma...@yahoo.de
Signed-off-by: Sven Eckelmann s...@narfation.org
---
net/batman-adv/routing.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/net/batman-adv/routing.c
From: Daniele Furlan daniele.fur...@gmail.com
In function is_bidirectional_neigh the code that find out the one hop
neighbor is duplicated.
Signed-off-by: Daniele Furlan daniele.fur...@gmail.com
Signed-off-by: Sven Eckelmann s...@narfation.org
---
net/batman-adv/routing.c | 74
On gio, mag 05, 2011 at 02:20:10 +0200, Marek Lindner wrote:
On Thursday 05 May 2011 10:21:42 Antonio Quartulli wrote:
return_router:
+ if (router router-if_incoming-if_status != IF_ACTIVE)
+ router = NULL;
+
rcu_read_unlock();
return router;
On gio, mag 05, 2011 at 03:34:24 +0200, Andrew Lunn wrote:
+ uevent_env[0] = kmalloc(strlen(BATTYPE=) +
+ strlen(uev_type_str[type]) + 1,
+ GFP_ATOMIC);
+ if (!uevent_env[0])
+ goto out;
+
+ sprintf(uevent_env[0],
I definitely agree. I thin that using a define like
#define UEV_TYPE_VAR BATTYPE=
would be more elegant.
In this case I can avoid to use snprintf. Do you agree on this?
Yes, that is safer.
+ if (ret)
+ bat_dbg(DBG_BATMAN, bat_priv, Impossible to send
+
On dom, mag 08, 2011 at 10:11:48 +0200, Andrew Lunn wrote:
I definitely agree. I thin that using a define like
#define UEV_TYPE_VAR BATTYPE=
would be more elegant.
In this case I can avoid to use snprintf. Do you agree on this?
Yes, that is safer.
+ if (ret)
+
On gio, mag 05, 2011 at 03:46:49 +0200, Andrew Lunn wrote:
On Thu, May 05, 2011 at 09:13:09AM +0200, Antonio Quartulli wrote:
+ /* If old_gw != NULL then this packet is unicast.
+* So, at this point it can only be a renewal packet (because it is the
+* only dhcp client message
From: Sven Eckelmann s...@narfation.org
Date: Sun, 8 May 2011 17:24:36 +0200
Hi,
I would like to propose following patches for net-next-2.6/2.6.40. They
include minor cleanups of comments, a big rename patch s/hna/tt/, but
also a remove some duplicated code. The spinlock which protected
25 matches
Mail list logo
