[B.A.T.M.A.N.] bug - unregister_netdevice: usage_count = 1

2011-05-10 Thread Antonio Quartulli
Hi all, I found a bug playing with my interfaces while bat0 was active. The bug is described here: http://www.open-mesh.org/issues/148 The steps to reproduce it are reported too. In a few words, when trying to unregister a device by unloading its module, the modprobe hangs and in the dmesg I can

[B.A.T.M.A.N.] [PATCH] batctl: added loglevel support for DBG_TT

2011-05-10 Thread Antonio Quartulli
DBG_TT log level has been added to batman-adv to collect all the messages related to Translation Table operations. This patch makes batctl able to select such level. Signed-off-by: Antonio Quartulli --- Patch "batman-adv: improved client announcement mechanism" introduces a new log "channel" call

[B.A.T.M.A.N.] [PATCHv4 3/3] batman-adv: protect the local and the global trans-tables with rcu

2011-05-10 Thread Antonio Quartulli
The local and the global translation-tables are now lock free and rcu protected. Signed-off-by: Antonio Quartulli --- Corrected orig_node_get_router() invokation main.c |2 - routing.c |2 - translation-table.c | 256 +-

[B.A.T.M.A.N.] [PATCHv4 2/3] batman-adv: improved roaming mechanism

2011-05-10 Thread Antonio Quartulli
Exploting the new announcement implementation, it has been possible to improve the roaming mechanism and reduce the number of packet drops. For details, please visit: http://www.open-mesh.org/wiki/batman-adv/Roaming-improvements Signed-off-by: Antonio Quartulli --- Corrected orig_node_get_router

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use kzalloc rather than kmalloc followed by memset with 0

2011-05-10 Thread Marek Lindner
On Tuesday 10 May 2011 11:17:40 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > gateway_client.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied in revision 4d4cd85. Thanks, Marek

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Ensure that we really have route changes in update_route

2011-05-10 Thread Sven Eckelmann
The debug output of update_route has tests for "route deleted" and "route added". All other situations are handled as "route changed". This is not true because neigh_node and curr_router could be both NULL. The function is not called in this situation, but the code might be interpreted wrong when

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unreachable code from gw_election

2011-05-10 Thread Sven Eckelmann
One of the first actions of gw_election is to check whether curr_gw is not NULL. In that case it will jumps to out. The rest of the code (before out) can now assume that gw_node is NULL. Therefore the router is only changed when curr_gw_tmp. This makes some printks in this block unnecessary which h

[B.A.T.M.A.N.] Random bat_dbg cleanup patches

2011-05-10 Thread Sven Eckelmann
Hi, I would like to propose following patches, but hadn't much time to check if they hide the real problem. Kind regards, Sven

[B.A.T.M.A.N.] [PATCH] batman-adv: Use kzalloc rather than kmalloc followed by memset with 0

2011-05-10 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann --- gateway_client.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/gateway_client.c b/gateway_client.c index 65f3953..e638841 100644 --- a/gateway_client.c +++ b/gateway_client.c @@ -281,11 +281,10 @@ static void gw_node_add(struct bat_pr

[B.A.T.M.A.N.] [PATCHv2 4/4] batman-adv: convert call_rcu(softif_neigh_free_rcu) to kfree_rcu

2011-05-10 Thread Sven Eckelmann
From: Paul E. McKenney The RCU callback softif_neigh_free_rcu() just calls kfree(), so we can use kfree_rcu() instead of call_rcu(). Signed-off-by: Paul E. McKenney Cc: Marek Lindner Cc: Simon Wunderlich Acked-by: David S. Miller Reviewed-by: Josh Triplett Signed-off-by: Sven Eckelmann ---

[B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: convert call_rcu(neigh_node_free_rcu) to kfree()

2011-05-10 Thread Sven Eckelmann
From: Paul E. McKenney The RCU callback neigh_node_free_rcu() just calls kfree(), so we can use kfree_rcu() instead of call_rcu(). Signed-off-by: Paul E. McKenney Cc: Marek Lindner Cc: Simon Wunderlich Acked-by: David S. Miller Reviewed-by: Josh Triplett Signed-off-by: Sven Eckelmann --- R

[B.A.T.M.A.N.] [PATCHv2 2/4] batman-adv: convert call_rcu(gw_node_free_rcu) to kfree_rcu

2011-05-10 Thread Sven Eckelmann
From: Paul E. McKenney The RCU callback gw_node_free_rcu() just calls kfree(), so we can use kfree_rcu() instead of call_rcu(). Signed-off-by: Paul E. McKenney Cc: Marek Lindner Cc: Simon Wunderlich Acked-by: David S. Miller Reviewed-by: Josh Triplett Signed-off-by: Sven Eckelmann --- Reba

[B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Add compatibility code for kfree_rcu

2011-05-10 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann --- Rebased on top of current master + newest version from Paul E. McKenney compat.c | 28 compat.h | 10 ++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/compat.c b/compat.c index 586898f..e040486 100644 --