[B.A.T.M.A.N.] [PATCH] batman-adv: a multiline comment should precede the variable it is describing

This comment has been wrongly put after the variable it refers to and was also bad indented Signed-off-by: Antonio Quartulli --- types.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/types.h b/types.h index fab70e8..65b3222 100644 --- a/types.h +++ b/types.h @

Re: [B.A.T.M.A.N.] [RFC/PATCH] net: add seq_before/seq_after functions

On Wednesday 18 May 2011 14:22:13 Antonio Quartulli wrote: > Introduce two operations to handle comparison between packet sequence > numbers taking into account overflow/wraparound. Batman-adv uses > these functions already to check for successor packet even in case of > overflow. > --- > > I adde

[B.A.T.M.A.N.] [RFC/PATCH] net: add seq_before/seq_after functions

Introduce two operations to handle comparison between packet sequence numbers taking into account overflow/wraparound. Batman-adv uses these functions already to check for successor packet even in case of overflow. --- I added this two functions in net.h because I didn't really know where best pla

Re: [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: Only use in up and down gw representation

On Saturday 14 May 2011 23:14:51 Sven Eckelmann wrote: > It is not save to provide memory for an int and then cast the pointer to > it to long*. It is better to standardize the up and down gateway > bandwith representation to simple ints and only use long inside > conversation routines. Applied in

Re: [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: Add const type qualifier for pointers

On Saturday 14 May 2011 23:14:50 Sven Eckelmann wrote: > batman-adv uses pointers which are marked as const and should not > violate that type qualifier by passing it to functions which force a > cast to the non-const version. Applied in revision 200df24. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: Don't do pointer arithmetic with void*

On Saturday 14 May 2011 23:14:49 Sven Eckelmann wrote: > The size of void is currently set by gcc to 1, but is not well defined > in general. Therefore it is more advisable to cast it to char* before > doing pointer arithmetic. Applied in revision f896bd9. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: Remove comparising < 0 for unsigned type

On Saturday 14 May 2011 23:14:48 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > bat_debugfs.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied in revision 960f86c. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: Print jiffies as unsigned long

On Saturday 14 May 2011 23:14:47 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > bat_debugfs.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied in revision 49524b5. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Annotate functions with format strings

On Saturday 14 May 2011 23:14:46 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > bat_debugfs.c |1 + > main.h|3 ++- > 2 files changed, 3 insertions(+), 1 deletions(-) Applied in revision 4560a65. Thanks, Marek

[B.A.T.M.A.N.] [PATCH] batman-adv: move smallest_signed_int(), seq_before() and seq_after() into main.h

smallest_signed_int(), seq_before() and seq_after() are very useful functions that help to handle comparisons between sequence numbers. However they were only defined in vis.c. With this patch every batman-adv function will be able to use them. Signed-off-by: Antonio Quartulli --- main.h | 16