[B.A.T.M.A.N.] [RFC next v2] batman-adv: ELP - use new ethtool_link_get_ksettings API

From: Antonio Quartulli The ethtool API is changing in linux-4.6 and the B.A.T.M.A.N. V code has to be changed accordingly. Fixes: 5c3245172c01 ("batman-adv: ELP - compute the metric based on the estimated throughput") Signed-off-by: Antonio Quartulli ---

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Check skb size before using encapsulated ETH+VLAN header

On Sunday 28 February 2016 08:49:02 Marek Lindner wrote: > On Friday, February 26, 2016 17:56:13 Sven Eckelmann wrote: > > --- a/net/batman-adv/soft-interface.c > > +++ b/net/batman-adv/soft-interface.c > > @@ -408,11 +408,17 @@ void batadv_interface_rx(struct net_device > > *soft_iface, */ > > >

Re: [B.A.T.M.A.N.] Patchwork on open-mesh.org

On Sunday 28 February 2016 12:43:27 Marek Lindner wrote: [...] > A few questions as to how this works: > > * [PATCH] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED > -> Manually marked as 'accepted' as it won't be easily detectable as > merged. Correct ? Correct. > * [B.A.T.M.A.N.,2/2]

Re: [B.A.T.M.A.N.] Patchwork on open-mesh.org

On Sunday, February 21, 2016 16:39:22 Sven Eckelmann wrote: > I've used my free time in the last week to look over the 5246 patches which > were sent to the B.A.T.M.A.N. mailing list. These patches were categorized > as > > * Accepted: >committed to the respective repository at

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq

On Tuesday, February 16, 2016 10:47:07 Sven Eckelmann wrote: > From: Sven Eckelmann > > The undefined behavior sanatizer detected an signed integer overflow in a > setup with near perfect link quality > > UBSAN: Undefined behaviour in

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Check skb size before using encapsulated ETH+VLAN header

On Friday, February 26, 2016 17:56:13 Sven Eckelmann wrote: > --- a/net/batman-adv/soft-interface.c > +++ b/net/batman-adv/soft-interface.c > @@ -408,11 +408,17 @@ void batadv_interface_rx(struct net_device > *soft_iface, */ > nf_reset(skb); > > + if (unlikely(!pskb_may_pull(skb,

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use bool as return type for boolean functions

On Monday, February 22, 2016 21:02:39 Sven Eckelmann wrote: > It is easier to understand that the returned value of a specific function > doesn't have to be 0 when the functions was successful when the actual > return type is bool. This is especially true when all surrounding functions > with

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix kerneldoc for batadv_compare_claim

On Monday, February 22, 2016 18:55:32 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > net/batman-adv/bridge_loop_avoidance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied in revision fb633a4. Thanks, Marek signature.asc Description: This is

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Split batadv_iv_ogm_orig_del_if function

On Monday, February 22, 2016 22:56:34 Sven Eckelmann wrote: > batadv_iv_ogm_orig_del_if handles two different buffers bcast_own and > bcast_own_sum which should be resized. The error handling two for > allocating these buffers causes the complexity of this function. This can > be avoided

[B.A.T.M.A.N.] batctl: page allocation failure

Hi all, I've got this error with # batctl -v batctl 2016.0-4-g7a3d563 [batman-adv: 2016.0-83-g884fb2d] on # uname -rmpio 3.4.107-01996-g67bdc52 armv7l ARMv7 Processor rev 4 (v7l) sun7i GNU/Linux I know the kernel is old, I can take a recent one if needed, but maybe this is not necessary.

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix unexpected free of bcast_own on add_if error

On Monday, February 22, 2016 22:56:33 Sven Eckelmann wrote: > The function batadv_iv_ogm_orig_add_if allocates new buffers for bcast_own > and bcast_own_sum. It is expected that these buffers are unchanged in case > either bcast_own or bcast_own_sum couldn't be resized. > > But the error handling

Re: [B.A.T.M.A.N.] [PATCH] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED

On Sun, Feb 21, 2016 at 04:40:55PM +0100, Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > Antonio, please add this to your tree for net-next.git Applied to my tree and ready to land in net-next. Thanks ! -- Antonio Quartulli signature.asc Description:

[B.A.T.M.A.N.] [RFC next] batman-adv: ELP - use new ethtool_link_get_ksettings API

The ethtool API is changing in linux-4.6 and the B.A.T.M.A.N. V code has to be changed accordingly. Fixes: 5c3245172c01 ("batman-adv: ELP - compute the metric based on the estimated throughput") Signed-off-by: Antonio Quartulli --- This patch contains some compat code which

Re: [B.A.T.M.A.N.] Antwort: Re: [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla

On Saturday 27 February 2016 12:33:54 Andreas Pape wrote: > Hi Sven, > > I just pressed the send button too early for my last mail ;-). > > First of all I want to thank you for your valuable review. Please be > patient as this is my first attempt > to contribute to a linux project and I am still

[B.A.T.M.A.N.] Antwort: Re: [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla

Hi Sven, I just pressed the send button too early for my last mail ;-). First of all I want to thank you for your valuable review. Please be patient as this is my first attempt to contribute to a linux project and I am still lacking some linux know how. Kind regards, Andreas Sven Eckelmann

Re: [B.A.T.M.A.N.] Antwort: Re: [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla

On Saturday 27 February 2016 12:10:00 Andreas Pape wrote: > Is there a way to generate the cover letter also with git send-email? As I > did > not know how to generate it, I used claws as a separate e-mail client. I've already explained this earlier [1]: git send-email --compose 0001-

[B.A.T.M.A.N.] Antwort: Re: [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla

Sven Eckelmann schrieb am 26.02.2016 17:20:54: > See my other comments directly to the patches. Please try to set the > in-reply-to of the patches to the message-id of the cover letter. Otherwise > the messages aren't correctly threaded on the mailinglist [1]. > Is there a