Re: [B.A.T.M.A.N.] [PATCHv3] batctl: Use netlink to replace some of debugfs

2016-05-04 Thread Sven Eckelmann
On Tuesday 03 May 2016 20:24:42 Andrew Lunn wrote: [...] > Where is netlink.h missing? The file is missing. Not the include. The includes fail because the file is not part of the patch. Kind regards, Sven signature.asc Description: This is a digitally signed message part.

[B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs

2016-05-04 Thread Andrew Lunn
The kernel has gained support for exporting some information via netlink. Use this when available, rather than debugfs. If netlink is not available, or the information is not yet available via netlink, batctl will fall back to debugfs. Signed-off-by: Andrew Lunn --- v2: Verify mandatory attribu

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: refactor batadv_neigh_node_* functions to follow common style

2016-05-04 Thread Marek Lindner
On Tuesday, May 03, 2016 01:52:08 Marek Lindner wrote: > Signed-off-by: Marek Lindner > --- > net/batman-adv/bat_iv_ogm.c | 3 ++- > net/batman-adv/bat_v_elp.c | 3 ++- > net/batman-adv/bat_v_ogm.c | 4 ++-- > net/batman-adv/originator.c | 35 +-- > net/batman

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused callback from batadv_algo_ops struct

2016-05-04 Thread Marek Lindner
On Monday, May 02, 2016 21:58:50 Marek Lindner wrote: > Signed-off-by: Marek Lindner > --- > net/batman-adv/originator.c | 5 - > net/batman-adv/types.h | 3 --- > 2 files changed, 8 deletions(-) Applied in revision ecd2334. Cheers, Marek signature.asc Description: This is a digitall

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove ogm_emit and ogm_schedule API calls

2016-05-04 Thread Marek Lindner
On Tuesday, May 03, 2016 01:45:34 Antonio Quartulli wrote: > The ogm_emit and ogm_schedule API calls were rather tight to the > B.A.T.M.A.N. IV logic and therefore rather difficult to use > with other algorithm implementations. > > Remove such calls and move the surrounding logic into the > B.A.T.

Re: [B.A.T.M.A.N.] [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Felipe Balbi
Hi, Florian Westphal writes: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc: user-mode-linux-de...@lists.sourceforge.net > Cc: li

Re: [B.A.T.M.A.N.] [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Mugunthan V N
On Tuesday 03 May 2016 08:03 PM, Florian Westphal wrote: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc: user-mode-linux-de...@li

Re: [B.A.T.M.A.N.] [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Antonio Quartulli
On Tue, May 03, 2016 at 04:33:13PM +0200, Florian Westphal wrote: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc: user-mode-linux

Re: [B.A.T.M.A.N.] pull request [net]: batman-adv 20160430

2016-05-04 Thread Antonio Quartulli
On Wed, May 04, 2016 at 02:13:50PM -0400, David Miller wrote: > > Just FYI I did this last night. Thanks a lot for letting me know David. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] pull request [net]: batman-adv 20160430

2016-05-04 Thread David Miller
From: David Miller Date: Tue, 03 May 2016 12:33:30 -0400 (EDT) > From: Antonio Quartulli > Date: Tue, 3 May 2016 22:42:29 +0800 > >> Do you have any plan on merging net into net-next in the following days ? >> >> I am asking because I'd prefer to avoid you the hassle of dealing with the >> con

[B.A.T.M.A.N.] [RFC v4] throughput meter on steroids^W netlink

2016-05-04 Thread Sven Eckelmann
Hi, I was asked by the batman-adv maintainers to port the tp_meter to netlink. And I shouldn't do it with the patches from Andrew/Matthias applied but with only a small part of patch 4. I know, this isn't the nicest move but it allowed me to restructure the first commit a little bit. I've extrac

[B.A.T.M.A.N.] [PATCH v4 3/5] batman-adv: add netlink command to query generic mesh information files

2016-05-04 Thread Sven Eckelmann
From: Matthias Schiffer BATADV_CMD_GET_MESH_INFO is used to query basic information about a batman-adv softif (name, index and MAC address for both the softif and the primary hardif; routing algorithm; batman-adv version). Signed-off-by: Matthias Schiffer Signed-off-by: Andrew Lunn [sven.eckel

[B.A.T.M.A.N.] [PATCH v4 1/5] batman-adv: Add stripped down version of MAINTAINERS file

2016-05-04 Thread Sven Eckelmann
From: Sven Eckelmann The MAINTAINERS file has to modified from time to time when either some URLs change or some new files are added. These changes can easily be lost when they actually should be part of a change adding/deleting a file. Reported-by: Marek Lindner Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCH v4 1/4] batctl: Split list of objects in Makefile into separate lines

2016-05-04 Thread Sven Eckelmann
From: Sven Eckelmann The line of objects which are required to compile batctl gets longer and becomes harder to read. Instead save each object on its own line to make it easier to edit and easier to solve conflicts when multiple patches modify the list of objects. Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCH v4 5/5] batman-adv: throughput meter implementation

2016-05-04 Thread Sven Eckelmann
From: Antonio Quartulli The throughput meter module is a simple, kernel-space replacement for throughtput measurements tool like iperf and netperf. It is intended to approximate TCP behaviour. It is invoked through batctl: the protocol is connection oriented, with cumulative acknowledgment and a

[B.A.T.M.A.N.] [PATCH v4 4/5] batman-adv: return netdev status in the TX path

2016-05-04 Thread Sven Eckelmann
From: Antonio Quartulli Return the proper netdev TX status along the TX path so that the tp_meter can understand when the queue is full and should stop sending packets. Signed-off-by: Antonio Quartulli Signed-off-by: Sven Eckelmann --- net/batman-adv/fragmentation.c | 41 +

[B.A.T.M.A.N.] [PATCH v4 3/4] batctl: Add attributes/command for BATADV_CMD_GET_MESH_INFO

2016-05-04 Thread Sven Eckelmann
From: Sven Eckelmann BATADV_CMD_GET_MESH_INFO will be used as common function to retrieve information from the kernel. This information can be used to display a header for debugfs tables. Signed-off-by: Sven Eckelmann --- batman_adv.h | 18 ++ netlink.c| 14 ++

[B.A.T.M.A.N.] [PATCH v4 2/5] batman-adv: add generic netlink family for batman-adv

2016-05-04 Thread Sven Eckelmann
From: Matthias Schiffer debugfs is currently severely broken virtually everywhere in the kernel where files are dynamically added and removed (see http://lkml.iu.edu/hypermail/linux/kernel/1506.1/02196.html for some details). In addition to that, debugfs is not namespace-aware. Instead of adding

[B.A.T.M.A.N.] [PATCH v4 2/4] batctl: Add basic infrastructure to integrate netlink

2016-05-04 Thread Sven Eckelmann
From: Sven Eckelmann Netlink can be used to add new communication functionality to the kernel module. It can also be used to replace the old debugfs files. The binary interface used for this will be defined in the added files. Signed-off-by: Sven Eckelmann --- Makefile | 12 b

[B.A.T.M.A.N.] [PATCH v4 4/4] batctl: introduce throughput meter support

2016-05-04 Thread Sven Eckelmann
From: Antonio Quartulli Add command to launch the throughput meter test. The throughput meter is a batman kernelspace tool for throughput measurements. The syntax is: batctl tp The test is interruptible with SIGINT or SIGTERM; if the test succeeds with no error the throughput and the elaps

Re: [B.A.T.M.A.N.] pull request: batman-adv 20160504

2016-05-04 Thread David Miller
From: Antonio Quartulli Date: Wed, 4 May 2016 06:23:35 +0800 > this is a pull request intended for net-next. > > In this batch you don't have any patch that depends on our fixes, > therefore you can safely merge it even if the net tree has not been > merged yet. > > In this patchset you basica