On Mon, Jun 13, 2016 at 07:36:37PM +0100, Ben Hutchings wrote:
> 3.16.36-rc1 review patch. If anyone has any objections, please let me know.
>
Hi Ben,
This one looks weird. The version you added for 3.2.81-rc1 looked
better.
Cheers, Linus
> --
>
> From: Linus Lüssing
On Mon, Jun 13, 2016 at 12:45:17PM +0200, Sven Eckelmann wrote:
> On Sunday 12 June 2016 12:14:23 Antonio Quartulli wrote:
> [...]
> > + if (bat_priv->algo_ops->gw.show_sel_class)
> > + return bat_priv->algo_ops->gw.show_sel_class(bat_priv, buff);
> [...]
> > + if
On Sunday 12 June 2016 12:14:24 Antonio Quartulli wrote:
> +static void batadv_iv_gw_print(struct batadv_priv *bat_priv,
> + struct seq_file *seq)
> +{
> + struct batadv_gw_node *gw_node;
> + int gw_count = 0;
> +
> + seq_printf(seq,
> +
On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote:
> + if (orig_throughput < (gw_throughput + threshold))
> + goto out;
Possible overflow problem in batadv_v_gw_is_eligible. We don't
know what the user will add here and what the gw_throughput is.
We already had a
On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote:
> --- a/net/batman-adv/gateway_client.c
> +++ b/net/batman-adv/gateway_client.c
> @@ -215,6 +215,10 @@ void batadv_gw_election(struct batadv_priv *bat_priv)
> if (!batadv_atomic_dec_not_zero(_priv->gw.reselect) && curr_gw)
>
On Sunday 12 June 2016 12:14:26 Antonio Quartulli wrote:
> Now that the GW-mode code is algorithm specific, batman-adv expects the
> routing algorithm to implement some APIs to make it work.
>
> However, such APIs are not mandatory, therefore we might have algorithms
> not providing them. In this
On Sunday 12 June 2016 12:14:23 Antonio Quartulli wrote:
[...]
> + if (bat_priv->algo_ops->gw.show_sel_class)
> + return bat_priv->algo_ops->gw.show_sel_class(bat_priv, buff);
[...]
> + if (bat_priv->algo_ops->gw.store_sel_class)
> + return
Hi,
it looks like this patch is incorrect and has to be rewritten. TQ is only
available in BATMAN_IV and BATMAN_V will have to use THROUGHPUT. Thus this
patch should be rewritten on top of the gw patchset from Antonio.
I will therefore mark this patch and all following patches as "changes
Hi Sven,
thanks for the feedback. I just realized that I forgot to rebase the
patchset before sending it. Could this be the cause?
When I try to apply the patches locally to a fresh cloned batman-adv
repository, the patches succeeded but some hunks succeed with some
offset or fuzz only due to the
