Re: [B.A.T.M.A.N.] Mesh speed comparison between Atheros and MediaTek

2016-07-15 Thread Sven Eckelmann
On Freitag, 15. Juli 2016 21:41:53 CEST Dirk van der Walt wrote: > Hi list, > > This is not strictly a Batman question, but I figured that it would be > a good place to ask. Is this device only using rt2x00? Then a good place to ask would be linux- wirel...@vger.kernel.org + Stanislaw Gruszka , H

[B.A.T.M.A.N.] Mesh speed comparison between Atheros and MediaTek

2016-07-15 Thread Dirk van der Walt
Hi list, This is not strictly a Batman question, but I figured that it would be a good place to ask. I've always in the past used Atheros based hardware for the mesh nodes and the results have been stable and with acceptable speeds. Recently in my search for cheap and open hardware I got a few M

[B.A.T.M.A.N.] [PATCH v2 12/18] batman-adv: Place kref_get for gw_node near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 17/18] batman-adv: Place kref_get for tvlv_container near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 18/18] batman-adv: Place kref_get for tvlv_container near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 15/18] batman-adv: Place kref_get for nc_node near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 16/18] batman-adv: Place kref_get for nc_path near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 07/18] batman-adv: Place kref_get for tt_local_entry near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 14/18] batman-adv: Place kref_get for softif_vlan near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 13/18] batman-adv: Place kref_get for hard_iface near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 10/18] batman-adv: Place kref_get for bla_backbone_gw near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 09/18] batman-adv: Place kref_get for bla_claim near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 11/18] batman-adv: Place kref_get for dat_entry near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 08/18] batman-adv: Place kref_get for tt_common near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 06/18] batman-adv: Place kref_get for orig_node near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 05/18] batman-adv: Place kref_get for neigh_node near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 04/18] batman-adv: Place kref_get for neigh_ifinfo near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 03/18] batman-adv: Place kref_get for tt_orig_list_entry near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 02/18] batman-adv: Place kref_get for orig_ifinfo near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

[B.A.T.M.A.N.] [PATCH v2 01/18] batman-adv: Place kref_get for orig_node_vlan near use

2016-07-15 Thread Sven Eckelmann
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting. Signed-of

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Place kref_get near use of reference

2016-07-15 Thread Sven Eckelmann
On Freitag, 15. Juli 2016 16:38:09 CEST Marek Lindner wrote: > On Wednesday, June 29, 2016 23:44:54 Sven Eckelmann wrote: > > net/batman-adv/bat_iv_ogm.c| 7 --- > > net/batman-adv/bat_v_ogm.c | 5 ++--- > > net/batman-adv/bridge_loop_avoidance.c | 9 - > > net/

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Allow to disable debugfs support

2016-07-15 Thread Sven Eckelmann
On Freitag, 15. Juli 2016 11:13:37 CEST Sven Eckelmann wrote: > The files provided by batman-adv via debugfs are currently converted to > netlink. Tools which are not yet converted to use the netlink interface may > still rely on the old debugfs files. But systems which already upgraded > their too

[B.A.T.M.A.N.] [PATCH] batman-adv: Allow to disable debugfs support

2016-07-15 Thread Sven Eckelmann
The files provided by batman-adv via debugfs are currently converted to netlink. Tools which are not yet converted to use the netlink interface may still rely on the old debugfs files. But systems which already upgraded their tools can save some space by disabling this feature. The default configur

Re: [B.A.T.M.A.N.] [RFC 1/2] batman-adv: Allow to disable debugfs support

2016-07-15 Thread Marek Lindner
On Sunday, July 10, 2016 12:59:28 Sven Eckelmann wrote: > The files provided by batman-adv via debugfs are currently converted to > netlink. Tools which are not yet converted to use the netlink interface may > still rely on the old debugfs files. But systems which already upgraded > their tools can

Re: [B.A.T.M.A.N.] [PATCH v10 05/16] batman-adv: netlink: add translation table query

2016-07-15 Thread Marek Lindner
On Sunday, July 03, 2016 13:31:37 Sven Eckelmann wrote: > From: Matthias Schiffer > > This adds the commands BATADV_CMD_GET_TRANSTABLE_LOCAL and > BATADV_CMD_GET_TRANSTABLE_GLOBAL, which correspond to the transtable_local > and transtable_global debugfs files. > > The batadv_tt_client_flags enum

Re: [B.A.T.M.A.N.] [PATCH v10 04/16] batman-adv: netlink: hardif query

2016-07-15 Thread Marek Lindner
On Sunday, July 03, 2016 13:31:36 Sven Eckelmann wrote: > From: Matthias Schiffer > > BATADV_CMD_GET_HARDIFS will return the list of hardifs (including index, > name and MAC address) of all hardifs for a given softif. > > Signed-off-by: Matthias Schiffer > Signed-off-by: Andrew Lunn > [sven.ec

Re: [B.A.T.M.A.N.] [PATCH v10 03/16] batman-adv: netlink: add routing_algo query

2016-07-15 Thread Marek Lindner
On Sunday, July 03, 2016 13:31:35 Sven Eckelmann wrote: > From: Matthias Schiffer > > BATADV_CMD_GET_ROUTING_ALGOS is used to get the list of supported routing > algorithms. > > Signed-off-by: Matthias Schiffer > Signed-off-by: Andrew Lunn > [sven.eckelm...@open-mesh.com: Reduce the number of

Re: [B.A.T.M.A.N.] [PATCH v10 02/16] batman-adv: Suppress debugfs entries for netns's

2016-07-15 Thread Marek Lindner
On Sunday, July 03, 2016 13:31:34 Sven Eckelmann wrote: > From: Andrew Lunn > > Debugfs is not netns aware. It thus has problems when the same > interface name exists in multiple network name spaces. > > Work around this by not creating entries for interfaces in name spaces > other than the defa

Re: [B.A.T.M.A.N.] [PATCH v10 01/16] batman-adv: Handle parent interfaces in a different netns

2016-07-15 Thread Marek Lindner
On Sunday, July 03, 2016 13:31:33 Sven Eckelmann wrote: > From: Andrew Lunn > > batman-adv tries to prevent the user from placing a batX soft > interface into another batman mesh as a hard interface. It does this > by walking up the devices list of parents and ensures they are all > none batX int

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix consistency of update route messages

2016-07-15 Thread Marek Lindner
On Wednesday, June 29, 2016 23:45:57 Sven Eckelmann wrote: > The debug messages of _batadv_update_route were printed before the actual > route change is done. At this point it is not really known which > curr_router will be replaced. Thus the messages could print the wrong > operation. > > Printin

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Place kref_get near use of reference

2016-07-15 Thread Marek Lindner
On Wednesday, June 29, 2016 23:44:54 Sven Eckelmann wrote: > net/batman-adv/bat_iv_ogm.c| 7 --- > net/batman-adv/bat_v_ogm.c | 5 ++--- > net/batman-adv/bridge_loop_avoidance.c | 9 - > net/batman-adv/distributed-arp-table.c | 2 +- > net/batman-adv/gateway_cli

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use bitwise instead of arithmetic operator for flags

2016-07-15 Thread Marek Lindner
On Monday, July 11, 2016 11:38:19 Sven Eckelmann wrote: > On Montag, 11. Juli 2016 11:16:36 CEST Linus Lüssing wrote: > > This silences the following coccinelle warning: > > > > "WARNING: sum of probable bitmasks, consider |" > > > > Signed-off-by: Linus Lüssing > > --- > > > > net/batman-adv/