Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function

On Sonntag, 25. September 2016 08:46:36 CEST Antonio Quartulli wrote: > The argument "type" passed to the batadv_dbg_arp() function is > never used. Remove it. > > Signed-off-by: Antonio Quartulli > --- Reviewed-by: Sven Eckelmann Kind regards,

[B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function

The argument "type" passed to the batadv_dbg_arp() function is never used. Remove it. Signed-off-by: Antonio Quartulli --- net/batman-adv/distributed-arp-table.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git

[B.A.T.M.A.N.] [PATCH v2 4/7] batctl: Parse interface arguments relative to last parsed option

Arguments may be added between "interface" and the subcommands "add" and "del". Thus is should not be hardcoded which positions of argv the subcommands start and instead the information from getopt should be used to calculate the correct position. Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCH v2 6/7] batctl: Move interface command to extra file

The interface command has nothing to do anymore more with all the other configuration in sysfs. Thus all the "interface" command functions should be placed in a separate file. Signed-off-by: Sven Eckelmann --- v2: - rename "new" command to "create" as requested by Linus

[B.A.T.M.A.N.] [PATCH v2 3/7] batctl: Use rtnl to add/remove interfaces

The sysfs interface to add/remove interfaces to/from a batman-adv soft-interface was downgraded in batman-adv master to a second-class citizen. This was done because it has conceptional problems (for example locking of sysfs vs. locking of the network core code). The only direct way to modify

[B.A.T.M.A.N.] [PATCH v2 7/7] batctl: Move check_mesh_iface* to functions.c

The check_mesh_iface* functions are not used to modify anything in sysfs. So they are better placed in the common/shared functions file than in sys.c. Signed-off-by: Sven Eckelmann --- v2: - no change functions.c | 59

[B.A.T.M.A.N.] [PATCH v2 2/7] batctl: Add command to create/destroy batman-adv interface

The command "create" can be used to create a batman-adv interface without any interface attached. This is helpful when the interfaces should be configured independently of the first attached interface. The command "destroy" can be used to destroy a batman-adv interface without going through all

[B.A.T.M.A.N.] [PATCH v2 5/7] batctl: Allow to disable automatic interface create/destroy

Users may not want to lose their configured batman-adv soft-interface when they remove a single interface from it. The default configuration may not working well enough in the network setup of the user and thus it should be possible to avoid that it gets reset to it when a new interface is added

[B.A.T.M.A.N.] [PATCH v2 1/7] batctl: Use rtnl to query list of softif devices

The normal way of network related programs to query the state of interfaces is to use the rtnetlink. Most of these data can also be queried via sysfs but it is easier to use the same way for both retrieving the list of interfaces and modifying the list of interfaces. Signed-off-by: Sven Eckelmann