[B.A.T.M.A.N.] [PATCH] batman-adv: Print correct function names in dbg messages

2017-05-19 Thread Sven Eckelmann
The function names in batman-adv changed slightly in the past. But some of the debug messages were not updated correctly and therefore some messages were incorrect. To avoid this in the future, these kind of messages should use __func__ to automatically print the correct function name.

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix rx packet/bytes stats on local ARP reply

2017-05-19 Thread Sven Eckelmann
On Mittwoch, 5. April 2017 16:26:17 CEST Sven Eckelmann wrote: > The stats are generated by batadv_interface_stats and must not be stored > directly in the net_device stats member variable. The batadv_priv > bat_counters information is assembled when ndo_get_stats is called. The > stats previously

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix memory leak when dropping packet from other gateway

2017-05-19 Thread Sven Eckelmann
On Freitag, 19. Mai 2017 10:01:42 CEST Sven Eckelmann wrote: > From: Andreas Pape > > This patch fixes a memory leak introduced with commit "batman-adv: > drop unicast packets from other backbone gw". > > Fixes: bfe2a1971f43 ("batman-adv: drop unicast packets from

[B.A.T.M.A.N.] [PATCH] batman-adv: fix memory leak when dropping packet from other gateway

2017-05-19 Thread Sven Eckelmann
From: Andreas Pape This patch fixes a memory leak introduced with commit "batman-adv: drop unicast packets from other backbone gw". Fixes: bfe2a1971f43 ("batman-adv: drop unicast packets from other backbone gw") Signed-off-by: Andreas Pape

Re: [B.A.T.M.A.N.] Memory leakage

2017-05-19 Thread Sven Eckelmann
On Freitag, 19. Mai 2017 08:29:29 CEST Andreas Pape wrote: [...] > I think the line with the "return NET_RX_DROP;" needs to be replaced by > "goto skb_free;". Yes > How is the correct procedure to change this? As this patch has already > been committed to > the git repo I guess I should send a

[B.A.T.M.A.N.] Memory leakage

2017-05-19 Thread Andreas Pape
Hi, as far as I could figure out via bisect commit [1] causes a memory leakage as the way how skbs are consumed / freed has been changed since I first developed this patch. This happens in a setup using bla and when the mesh links between mesh nodes sharing a common backbone become very weak and