[B.A.T.M.A.N.] [batman-adv] one edge case with 40+ neighbors

Hi Simon, Sven, Thanks for your excellent help. We have 50+ sites (and a total of 1000+ nodes running in the field) for over a month, and batman-adv works perfectly, maybe I wasn't notified, but I did not hear a single failure. We have an edge case: Our nodes are relatively closely placed, wh

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: handle race condition for claims also in batadv_bla_rx

On Thursday, June 1, 2017 5:11:25 PM CEST Simon Wunderlich wrote: > From: Andreas Pape > > Like in the case of the patch for batadv_bla_tx to handle a race > condition when claiming a mac address for bla, a similar situation > can occur when claiming is triggered via batadv_bla_rx. This patch > s

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: simplify return handling in some TT functions

Signed-off-by: Simon Wunderlich --- net/batman-adv/translation-table.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 4b64a9a6..e1133bc6 100644 --- a/net/batman-adv/translation-t

[B.A.T.M.A.N.] [PATCH] batman-adv: handle race condition for claims also in batadv_bla_rx

From: Andreas Pape Like in the case of the patch for batadv_bla_tx to handle a race condition when claiming a mac address for bla, a similar situation can occur when claiming is triggered via batadv_bla_rx. This patch solves this with a similar approach as for batadv_bla_tx. Signed-off-by: Andre

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: do not add loop detection mac addresses to global tt

This change has been made for local TT already, add another one for global TT - but only for temporary entries (aka speedy join), to prevent inconsistencies between local and global tables in case an older batman-adv version is still announcing those entries from its local table. Signed-off-by: Si

[B.A.T.M.A.N.] Antwort: Re: [PATCH] batman-adv: prevent adding of loop detection mac addresses to global tt

Hi Simon, > > I was thinking, if we implement it like this we may still have problems if an > older batman-adv version is adding the ba:be mac addresses locally. > This could > create a problem, because the transmitted tt table is not added completely, > thus the CRC will not match and will lead t

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: prevent adding of loop detection mac addresses to global tt

On Thursday, June 1, 2017 10:58:04 AM CEST Andreas Pape wrote: > This patch prevents that entries in the global translation table are > generated for mac addresses used by loop detection frames. > > Signed-off-by: Andreas Pape > --- > net/batman-adv/translation-table.c |6 -- > 1 files c

[B.A.T.M.A.N.] [PATCH] batman-adv: prevent adding of loop detection mac addresses to global tt

This patch prevents that entries in the global translation table are generated for mac addresses used by loop detection frames. Signed-off-by: Andreas Pape --- net/batman-adv/translation-table.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/translat

Re: [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings

On Monday, May 29, 2017 7:09:09 PM CEST Philipp Psurek wrote: > Hi all, > > it's nothing to worry about but since 2011 I always noticed a clean > compile run of your code. Now with gcc 7.1.0 there are some warnings > and notes that might interest you: > > ~ LANG=C make > CC bat-hosts.o >

Re: [B.A.T.M.A.N.] [PATCH 1/3] alfred: Check if tg hash was really initialized

On Donnerstag, 1. Juni 2017 10:15:20 CEST Simon Wunderlich wrote: > Thanks a lot for fixing that thing I missed and the initialization problems. > I > guess this also takes of the covery splats. I've picked all patches as they > are. Can you please also push patches 2 + 3. Thanks, Sven

Re: [B.A.T.M.A.N.] Antwort: Re: MAC addresses of loop detect frames in global translation-table

On Thursday, June 1, 2017 8:12:51 AM CEST Andreas Pape wrote: > > Von: Linus Lüssing > > An: The list for a Better Approach To Mobile Ad-hoc Networking > > > > Datum: 31.05.2017 16:20 > > Betreff: Re: [B.A.T.M.A.N.] MAC addresses of loop detect frames in > > global translation-table > > Gesendet

Re: [B.A.T.M.A.N.] [PATCH 1/3] alfred: Check if tg hash was really initialized

Thanks a lot for fixing that thing I missed and the initialization problems. I guess this also takes of the covery splats. I've picked all patches as they are. Thanks, Simon On Thursday, June 1, 2017 8:26:30 AM CEST Sven Eckelmann wrote: > The return value check after the tg_hash_new call

Re: [B.A.T.M.A.N.] MAC addresses of loop detect frames in global translation-table

On Wednesday, May 31, 2017 5:56:31 PM CEST Linus Lüssing wrote: > On Wed, May 31, 2017 at 04:40:56PM +0200, Simon Wunderlich wrote: > Although, sending these mesh wide sounds like it could create quite > some overhead? Is this new to BLA2? Yes, it's new in BLA2. Actually it wasn't in the first BLA

[B.A.T.M.A.N.] [PATCH 2/3] alfred: Always initialize orig cache hash pointer

The initialization of the cache can be disabled when mesh interface is "none". We must therefore make sure that the remaining code is not accessing the uninitialized pointer to the originator cache. Fixes: e50d18c39f92 ("alfred: Cache the TQ values for each originator") Signed-off-by: Sven Eckelma

[B.A.T.M.A.N.] [PATCH 3/3] alfred: Always initialize translation cache hash pointer

The initialization of the cache can be disabled when mesh interface is "none". We must therefore make sure that the remaining code is not accessing the uninitialized pointer to the translation cache. Fixes: a7bc3d9a2b3f ("alfred: Cache the global translation table entries") Signed-off-by: Sven Eck

Re: [B.A.T.M.A.N.] [PATCH 0/5] alfred: TQ query optimizations

On Mittwoch, 31. Mai 2017 17:24:45 CEST Simon Wunderlich wrote: [] > I've applied this patch series with some fixes in patch 4 and 5 regarding the > hash initialization. > > Thank you, > Simon It looks like you haven't actually changed it. I will post fixes for it. Kind regards,

[B.A.T.M.A.N.] Antwort: Re: MAC addresses of loop detect frames in global translation-table

> Von: Linus Lüssing > An: The list for a Better Approach To Mobile Ad-hoc Networking > > Datum: 31.05.2017 16:20 > Betreff: Re: [B.A.T.M.A.N.] MAC addresses of loop detect frames in > global translation-table > Gesendet von: "B.A.T.M.A.N" > > On Wed, May 31, 2017 at 03:39:23PM +0200, Simon Wund

[B.A.T.M.A.N.] [PATCH 1/3] alfred: Check if tg hash was really initialized

The return value check after the tg_hash_new call must actually check the return value and not some other datastructure. Fixes: a7bc3d9a2b3f ("alfred: Cache the global translation table entries") Signed-off-by: Sven Eckelmann --- server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di