Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Add extack to ndo_add_slave

2017-10-16 Thread Sven Eckelmann
On Montag, 16. Oktober 2017 19:07:25 CEST Sven Eckelmann wrote: > On Samstag, 7. Oktober 2017 14:18:52 CEST Sven Eckelmann wrote: > > From: David Ahern > > > > Pass extack to do_set_master and down to ndo_add_slave > > > > Signed-off-by: David Ahern > > Signed-off-by: David S. Miller > > [s...

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

2017-10-16 Thread Sven Eckelmann
On Montag, 16. Oktober 2017 09:48:03 CEST Sven Eckelmann wrote: > The neighbor compare API implementation for B.A.T.M.A.N. V checks whether > the neigh_ifinfo for this neighbor on a specific interface exists. A > warning is printed when it isn't found. > > But it is not called inside a lock which

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Add extack to ndo_add_slave

2017-10-16 Thread Sven Eckelmann
On Samstag, 7. Oktober 2017 14:18:52 CEST Sven Eckelmann wrote: > From: David Ahern > > Pass extack to do_set_master and down to ndo_add_slave > > Signed-off-by: David Ahern > Signed-off-by: David S. Miller > [s...@narfation.org: Add compat code] > Signed-off-by: Sven Eckelmann > --- > compa

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

2017-10-16 Thread Antonio Quartulli
On 16/10/17 15:48, Sven Eckelmann wrote: > The neighbor compare API implementation for B.A.T.M.A.N. V checks whether > the neigh_ifinfo for this neighbor on a specific interface exists. A > warning is printed when it isn't found. > > But it is not called inside a lock which would prevent that th

[B.A.T.M.A.N.] [PATCH] batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

2017-10-16 Thread Sven Eckelmann
The neighbor compare API implementation for B.A.T.M.A.N. V checks whether the neigh_ifinfo for this neighbor on a specific interface exists. A warning is printed when it isn't found. But it is not called inside a lock which would prevent that this information is lost right before batadv_neigh_ifin