general protection fault in smack_socket_sendmsg (2)

2019-11-28 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:0be0ee71 vfs: properly and reliably lock f_pos in fdget_po.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12c49ef2e0 kernel config: https://syzkaller.appspot.com/x/.config?x=330a1f54d1edb817 da

Re: [PATCH maint] batman-adv: Fix DAT candidate selection on little endian systems

2019-11-28 Thread Antonio Quartulli
Hi, On 28/11/2019 12:43, Sven Eckelmann wrote: > The distributed arp table is using a DHT to store and retrieve MAC address > information for an IP address. This is done using unicast messages to > selected peers. The potential peers are looked up using the IP address and > the VID. > > While the

[PATCH] batman-adv: Annotate bitwise integer pointer casts

2019-11-28 Thread Sven Eckelmann
The sparse commit 6002ded74587 ("add a flag to warn on casts to/from bitwise pointers") introduced a check for non-direct casts from/to restricted datatypes (when -Wbitwise-pointer is enabled). This triggered various warnings in batman-adv when some (already big endian) buffer content was casted t

[PATCH maint] batman-adv: Fix DAT candidate selection on little endian systems

2019-11-28 Thread Sven Eckelmann
The distributed arp table is using a DHT to store and retrieve MAC address information for an IP address. This is done using unicast messages to selected peers. The potential peers are looked up using the IP address and the VID. While the IP address is always stored in big endian byte order, it is

Re: Host endianness dependent DHT lookup

2019-11-28 Thread Sven Eckelmann
On Thursday, 28 November 2019 11:13:21 CET Antonio Quartulli wrote: [...] > Will you send a patch? > I guess converting the VID into network order before accessing it should > be enough, no? Yes, I will prepare a patch. Just want to finish debugging another problem before doing this. Kind regard

Re: Host endianness dependent DHT lookup

2019-11-28 Thread Antonio Quartulli
Hi, On 28/11/2019 11:01, Sven Eckelmann wrote: > Hi, > > I just saw following in batadv_hash_dat(): > > key = (const unsigned char *)&dat->vid; > for (i = 0; i < sizeof(dat->vid); i++) { > hash += key[i]; > hash += (hash << 10); > hash ^= (ha

Host endianness dependent DHT lookup

2019-11-28 Thread Sven Eckelmann
Hi, I just saw following in batadv_hash_dat(): key = (const unsigned char *)&dat->vid; for (i = 0; i < sizeof(dat->vid); i++) { hash += key[i]; hash += (hash << 10); hash ^= (hash >> 6); } But the vid is in host order - not

[no subject]

2019-11-28 Thread Dmitry Vyukov via B.A.T.M.A.N
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- On Thu, Nov 28, 2019 at 9:46 AM Sv

Re: WARNING in mark_lock (3)

2019-11-28 Thread Sven Eckelmann
On Thursday, 28 November 2019 09:54:15 CET Dmitry Vyukov wrote: [...] > > I was thinking more about rerunning the same bisect but tell it to assume > > "crashed: general protection fault in batadv_iv_ogm_queue_add" as OK instead > > of assuming that it is a crashed like the previous "crashed: WARNI

Re: WARNING in mark_lock (3)

2019-11-28 Thread Sven Eckelmann
On Thursday, 28 November 2019 09:40:32 CET Dmitry Vyukov wrote: > On Thu, Nov 28, 2019 at 8:25 AM Sven Eckelmann wrote: > > > > On Thursday, 28 November 2019 03:00:01 CET syzbot wrote: > > [...] > > > bisection log: > > > https://syzkaller.appspot.com/x/bisect.txt?x=132ee536e0 > > > start co

[no subject]

2019-11-28 Thread Dmitry Vyukov via B.A.T.M.A.N
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- On Thu, Nov 28, 2019 at 8:25 AM Sv