Re: [PATCH] batman-adv: mcast: add option to forward MLD reports only to mcast routers

2024-10-07 Thread Linus Lüssing
On Sat, Oct 05, 2024 at 05:37:19PM +0200, Sven Eckelmann wrote: > On Saturday, 31 August 2024 21:45:28 CEST Linus Lüssing wrote: > > In most setups it is sufficient for us to only send MLD reports to nodes > > which have a multicast router attached. Which reduces overall overhead,

Re: [PATCH v5 1/2] batman-adv: split DAT cache into DAT cache and DAT DHT

2024-09-17 Thread Linus Lüssing
On Thu, Sep 12, 2024 at 01:28:16PM +0200, Antonio Quartulli wrote: > I feel you need to answer the above questions even with two tables. No? > The difference is that with two tables you have more information and don't > need overwrite a DHT entry with a local one (and viceversa). Right. Though the

Re: [PATCH v5 1/2] batman-adv: split DAT cache into DAT cache and DAT DHT

2024-09-12 Thread Linus Lüssing
Hi Antonio, Thanks for the feedback! > I haven't followed previous discussions, therefore my question may just > sound redundant, but if "cache_hash" is for ARP what is the "DAT DHT"? (the > A in DAT stands for ARP). The dht_hash would just store what was pushed to it from remote nodes through t

[PATCH v2] batctl: add dat_dht command

2024-09-10 Thread Linus Lüssing
This adds a dat_dht command to query the DHT part of DAT in batman-adv. Signed-off-by: Linus Lüssing --- Changelog v2: - rebased to current main branch: -> removed now obsolete debugfs code Makefile| 2 + README.rst | 27 +- batadv_packet.h | 4 +- batman_ad

[PATCH v5 2/2] batman-adv: increase DAT DHT timeout

2024-09-10 Thread Linus Lüssing
patch the purge timeout for DAT DHT entries is increased to 30min to reduce the number of DAT ARP broadcast fallbacks. Signed-off-by: Linus Lüssing --- net/batman-adv/distributed-arp-table.c | 22 +- net/batman-adv/main.h | 3 ++- 2 files changed, 19 insertions

[PATCH v5 1/2] batman-adv: split DAT cache into DAT cache and DAT DHT

2024-09-10 Thread Linus Lüssing
and DAT DHT in the future. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 4 +- include/uapi/linux/batman_adv.h| 5 + net/batman-adv/distributed-arp-table.c | 360 ++--- net/batman-adv/distributed-arp-table.h | 13 +- net/batman-adv

[PATCH v5 0/2] batman-adv: increase DAT DHT timeout

2024-09-10 Thread Linus Lüssing
Hi, This is the fifth itereation to increase the DAT DHT timeout to reduce the amount of broadcasted ARP Replies. To increase the timeout only for DAT DHT entries added via DHT-PUT but not for any other entry in the DAT cache the DAT cache and DAT DHT concepts are first split into two separate ha

[PATCH] batctl: add switch for setting multicast_mld_rtr_only

2024-08-31 Thread Linus Lüssing
This patch adds an option for the new multicast_mld_rtr_only setting in batman-adv. Signed-off-by: Linus Lüssing --- Makefile | 1 + README.rst | 10 + batman_adv.h | 9 + event.c | 4 ++ man/batctl.8 | 18

[PATCH] batman-adv: mcast: add option to forward MLD reports only to mcast routers

2024-08-31 Thread Linus Lüssing
for this can then in turn be to set multicast_router=2 on the bat0 bridge port on the node with the IGMP/MLD querier.) Therefore MLD report flooding is kept the default and MLD report to multicast routers only forwarding is considered experimental and warned about. Signed-off-by: Linus Lüssing

Re: [PATCH v2] batman-adv: add dynamic, bridged-in TT VID detection support

2024-07-12 Thread Linus Lüssing
And one more thought/idea that just came to my mind: Maybe after adding dynamic VLAN detection from traffic we could then also exclude the annoying, actually typically unused VID 0 from the static addition? That way we would save quite a bit of overhead as each VLAN currently quite significantly i

Re: configuration for mobile nodes

2024-06-28 Thread Linus Lüssing
I'd be careful with just reducing timeouts... A 2 seconds purge timeout together with a default 1 second OGM interval seems to me like asking for a lot of route flapping in the best case. And potential, temporary routing loops in the worst case. What we typically do is decrease the batman-adv orig

Re: [PATCH v2] batman-adv: add dynamic, bridged-in TT VID detection support

2024-06-16 Thread Linus Lüssing
On Wed, Jun 12, 2024 at 11:39:44PM +0200, Linus Lüssing wrote: > So far, if we wanted to bridge VLAN tagged frames into the mesh one would > need to manually create an according VLAN interface on top of bat0 > first, to trigger batman-adv to create the according structures > for a VI

[PATCH v2] batman-adv: add dynamic, bridged-in TT VID detection support

2024-06-12 Thread Linus Lüssing
and added to the translation table on the fly. Signed-off-by: Linus Lüssing --- v2: fix a typo, a missing "to" in the commit message net/batman-adv/hard-interface.c| 2 +- net/batman-adv/multicast.c | 8 +- net/batman-adv/soft-interface.

[PATCH] batman-adv: add dynamic, bridged-in TT VID detection support

2024-06-12 Thread Linus Lüssing
added to the translation table on the fly. Signed-off-by: Linus Lüssing --- net/batman-adv/hard-interface.c| 2 +- net/batman-adv/multicast.c | 8 +- net/batman-adv/soft-interface.c| 121 - net/batman-adv/soft-interface.h| 6 +- net/batman-adv

Re: [PATCH] Revert "batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks"

2024-06-12 Thread Linus Lüssing
On Wed, Jun 12, 2024 at 09:06:25AM -0700, Paul E. McKenney wrote: > We are looking into nice ways of solving this, but in the meantime, > yes, if you are RCU-freeing slab objects into a slab that is destroyed > at module-unload time, you currently need to stick with call_rcu() > and rcu_barrier().

Re: [PATCH] Revert "batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks"

2024-06-12 Thread Linus Lüssing
On Wed, Jun 12, 2024 at 04:39:15PM +0200, Linus Lüssing wrote: > On Wed, Jun 12, 2024 at 07:06:04AM -0700, Paul E. McKenney wrote: > > Let me make sure that I understand... > > > > You need rcu_barrier() to wait for any memory passed to kfree_rcu() > > to actually be fr

Re: [PATCH] Revert "batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks"

2024-06-12 Thread Linus Lüssing
On Wed, Jun 12, 2024 at 07:06:04AM -0700, Paul E. McKenney wrote: > Let me make sure that I understand... > > You need rcu_barrier() to wait for any memory passed to kfree_rcu() > to actually be freed? If so, please explain why you need this, as > in what bad thing happens if the actual kfree() h

[PATCH] Revert "batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks"

2024-06-12 Thread Linus Lüssing
this for now until the underlying issue can be found and better understood. Some additional debugging information and discussions can be found on our Redmine bugtracker, linked below. Link: https://www.open-mesh.org/issues/428 Signed-off-by: Linus Lüssing --- Some help / guidance for further deb

Re: Problem starting A.L.F.R.E.D on batman-adv?

2024-01-28 Thread Linus Lüssing
On Sun, Jan 28, 2024 at 10:29:00PM -, doug.faja...@gmail.com wrote: > I cant seem to get A.L.F.R.E.D. to start: > doug@dougwork:~/sdshome/alfred$ sudo alfred -b bat0 > Can't start server: interface missing I think it's complaining because the "-i" parameter is missing. Try using "alfread -i ba

[PATCH net v2] bridge: mcast: fix disabled snooping after long uptime

2024-01-27 Thread Linus Lüssing
have this ULONG_MAX/2 difference limitation. Fixes: b00589af3b04 ("bridge: disable snooping if there is no querier") Signed-off-by: Linus Lüssing --- Changelog v2: * removed "inline" from br_multicast_query_delay_expired() net/bridge/br_multicast.c | 20 +++-

[PATCH net] bridge: mcast: fix disabled snooping after long uptime

2024-01-26 Thread Linus Lüssing
have this ULONG_MAX/2 difference limitation. Fixes: b00589af3b04 ("bridge: disable snooping if there is no querier") Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 20 +++- net/bridge/br_private.h | 4 ++-- 2 files changed, 17 insertions(+), 7 deletions(

[PATCH] batman-adv: mcast: fix memory leak on deleting a batman-adv interface

2024-01-16 Thread Linus Lüssing
00beadc4060f0cb...@google.com/ Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index c8620905c2dc..38fab5e46ae2 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-

[PATCH] batman-adv: mcast: fix mcast packet type counter on timeouted nodes

2024-01-09 Thread Linus Lüssing
by reducing the according counter when such a node times out. Fixes: be9b0169c840 ("batman-adv: mcast: implement multicast packet generation") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/multicast.c b/

Re: [PATCH RFC 2/2] batman-adv: Better half duplex penalty estimation

2023-10-13 Thread Linus Lüssing
On Thu, Sep 28, 2023 at 02:39:36PM +0200, Remi Pommarel wrote: > diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c > index 27597f4cdf3e..9b7d4de182d0 100644 > --- a/net/batman-adv/bat_v_ogm.c > +++ b/net/batman-adv/bat_v_ogm.c > @@ -866,10 +866,12 @@ static u32 batadv_v_get_throu

Re: [PATCH RFC 2/2] batman-adv: Better half duplex penalty estimation

2023-10-13 Thread Linus Lüssing
On Sat, Oct 14, 2023 at 07:10:28AM +0200, Linus Lüssing wrote: > In the following scenario: > > +---+ ch.1 +---+ ch.2 +---+ ch.2 +---+ > | Orig0 | <- | Orig1 | <-- | Orig2 | <-- | Orig3 | > +---+ 300 +---+

Re: [PATCH RFC 2/2] batman-adv: Better half duplex penalty estimation

2023-10-13 Thread Linus Lüssing
Hi, Thanks for taking your time to look into this and the detailed explanations! Generally, the issues both patches try to address make sense to me. On Thu, Sep 28, 2023 at 02:39:36PM +0200, Remi Pommarel wrote: > Let's consider the below topology [...] > However the following formula seems to

Re: Fwd: Possibility of dual-licensing to ease bringing into FreeBSD

2023-09-15 Thread Linus Lüssing
Hi Aymetric, Nice work! For my part, I'd be a bit reluctant. We've had requests for batman-adv from big companies in the past for an extra license, which we turned down. So there might unfortunately be vultures out there who'd like to build on top of batman-adv without giving back. And I'd feel a

[PATCH v7 3/3] batman-adv: mcast: shrink tracker packet after scrubbing

2023-09-06 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 207 1 file changed, 207 insertions(+) diff --git a/net/batma

[PATCH v7 2/3] batman-adv: mcast: implement multicast packet generation

2023-09-06 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 +++- net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 732 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v7 1/3] batman-adv: mcast: implement multicast packet reception and forwarding

2023-09-06 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 45

[PATCH v7 0/3] Implementation of a Stateless Multicast Packet Type

2023-09-06 Thread Linus Lüssing
In-Reply-To: Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicas

[PATCH 1/2] batctl: mcast_flags: update to current state

2023-07-31 Thread Linus Lüssing
Add the new "P" flag, which signals support for the new batman-adv multicast packet type, to the "batctl mcast_flags" and "batctl tcpdump" outputs. The examples in the README.rst are updated, too, including a description for the R4 and R6 flags. Signed-off-by:

[PATCH 2/2] batctl: tcpdump: parse batman-adv mcast packet type

2023-07-31 Thread Linus Lüssing
Implement a batctl tcpdump parsing of the new batman-adv multicast packet type, including its multicast tracker TVLV and encapsulated payload data. Signed-off-by: Linus Lüssing --- tcpdump.c | 134 +++--- tcpdump.h | 1 + 2 files changed, 119

[PATCH v6 3/3] batman-adv: mcast: shrink tracker packet after scrubbing

2023-07-19 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 195 1 file changed, 195 insertions(+) diff --git a/net/batma

[PATCH v6 2/3] batman-adv: mcast: implement multicast packet generation

2023-07-19 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 +++- net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 727 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v6 1/3] batman-adv: mcast: implement multicast packet reception and forwarding

2023-07-19 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 45

[PATCH v6 0/3] Implementation of a Stateless Multicast Packet Type

2023-07-19 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and ad

[PATCH v5 3/3] batman-adv: mcast: shrink tracker packet after scrubbing

2023-07-08 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 194 1 file changed, 194 insertions(+) diff --git a/net/batma

[PATCH v5 2/3] batman-adv: mcast: implement multicast packet generation

2023-07-08 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 +++- net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 715 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v5 1/3] batman-adv: mcast: implement multicast packet reception and forwarding

2023-07-08 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 45

[PATCH v5 0/3] Implementation of a Stateless Multicast Packet Type

2023-07-08 Thread Linus Lüssing
[PATCH v5 0/3] Implementation of a Stateless Multicast Packet Type Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on t

Re: forwarding works fine with 802.1ad vlans

2023-07-04 Thread Linus Lüssing
Hi pony, Thanks for the feedback! I've added a comment to this Wiki entry, that you should not rely on packets being filtered. I'm not sure if this filtering is 100% intentional or just a byproduct of the early VLAN awareness implementation. So far we typically advertised batman-adv as "it just w

Re: [PATCH 1/5] batman-adv: Start new development cycle

2023-02-02 Thread Linus Lüssing
On Mon, Jan 30, 2023 at 03:55:08PM +0100, Jiri Pirko wrote: > Fri, Jan 27, 2023 at 11:21:29AM CET, s...@simonwunderlich.de wrote: > >This version will contain all the (major or even only minor) changes for > >Linux 6.3. > > > >The version number isn't a semantic version number with major and minor

Re: [PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2023-01-21 Thread Linus Lüssing
On Thu, Jan 19, 2023 at 01:47:25PM +0100, Simon Wunderlich wrote: > On Tuesday, December 27, 2022 8:34:07 PM CET Linus Lüssing wrote: > > +/** > > + * struct batadv_tvlv_mcast_tracker - payload of a multicast tracker tvlv > > + * @num_dests: number of subsequent desti

Re: [PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2023-01-16 Thread Linus Lüssing
On Sun, Jan 15, 2023 at 06:56:37PM +0100, Sven Eckelmann wrote: > [...] > > +static void > > +batadv_mcast_forw_scrub_dests(struct batadv_priv *bat_priv, > > + struct batadv_neigh_node *comp_neigh, u8 *dest, > > + u8 *next_dest, u16 num_dests) > > +{

[PATCH v4 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-27 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 212 1 file changed, 212 insertions(+) diff --git a/net/batma

[PATCH v4 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-27 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 513 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-27 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH v4 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-27 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 +

[PATCH v4 0/5] Implementation of a Stateless Multicast Packet Type

2022-12-27 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and ad

[PATCH v4 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-27 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 249 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 26 ++-- 3 files changed, 33 insertions(+), 280

[PATCH] build_test: don't warn about "Macro argument reuse" in multicast_forw.c

2022-12-27 Thread Linus Lüssing
\ for (typeof(num_dests) __batadv_forw_num_dests = num_dests; \ *__batadv_forw_num_dests; \ (*__batadv_forw_num_dests)--, (dest) += ETH_ALEN) Signed-off-by: Linus Lüssing --- checkstuff.sh | 2 +- 1 file changed, 1 inser

Re: [PATCH v3 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-27 Thread Linus Lüssing
On Tue, Dec 27, 2022 at 10:07:36AM +0100, Sven Eckelmann wrote: > ecsv/pu: checkpatch ./net/batman-adv/multicast_forw.c > - > > CHECK: Macro argument reuse 'num_dests' - possible side-effects? > #25: FILE: ./net/batman-adv/multicast_forw.

[PATCH v3 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-26 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 212 1 file changed, 212 insertions(+) diff --git a/net/batma

[PATCH v3 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-26 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 24 +- net/batman-adv/multicast_forw.c | 511 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v3 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-26 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH v3 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-26 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 +

[PATCH v3 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-26 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 249 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 26 ++-- 3 files changed, 33 insertions(+), 280

[PATCH v3 0/5] Implementation of a Stateless Multicast Packet Type

2022-12-26 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and ad

[PATCH v2 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-26 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 24 +- net/batman-adv/multicast_forw.c | 504 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v2 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-26 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 207 1 file changed, 207 insertions(+) diff --git a/net/batma

[PATCH v2 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-26 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH v2 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-26 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 +

[PATCH v2 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-26 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 248 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 25 ++-- 3 files changed, 33 insertions(+), 278

[PATCH v2 0/5] Implementation of a Stateless Multicast Packet Type

2022-12-26 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and ad

[PATCH 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-26 Thread Linus Lüssing
eight, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 207 1 file changed, 207 insertions(+) diff --git a/net/batma

[PATCH 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-26 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 24 +- net/batman-adv/multicast_forw.c | 504 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-26 Thread Linus Lüssing
handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-26 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 +

[PATCH 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-26 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 248 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 25 ++-- 3 files changed, 33 insertions(+), 278

Implementation of a Stateless Multicast Packet Type

2022-12-26 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and ad

Re: [pim] draft-ietf-6lo-multicast-registration-08 replacing MLD

2022-09-13 Thread Linus Lüssing
On Mon, Aug 08, 2022 at 10:21:05AM -0700, Stig Venaas wrote: > Hi 6lo and draft authors > > I have some concerns about this draft replacing MLD for group registration. > > Having 2 different protocols for the same thing can be problematic. > Hosts or routers may need to support both protocols. Is

Re: [RFC PATCH v3 1/1] mac80211: use AQL airtime for expected throughput.

2022-05-31 Thread Linus Lüssing
On Tue, May 31, 2022 at 12:09:22PM +0200, Baligh Gasmi wrote: > Since the integration of AQL, packet TX airtime estimation is > calculated and counted to be used for the dequeue limit. > > Use this estimated airtime to compute expected throughput for > each station. > > It will be a generic mac80

[PATCH maint] batman-adv: mcast: don't send link-local multicast to mcast routers

2021-12-31 Thread Linus Lüssing
mcast: apply optimizations for routable packets, too") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 15 ++- net/batman-adv/multicast.h | 5 +++-- net/batman-adv/soft-interface.c | 7 +-- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/

Re: Unable to get DHCP after join wlan0 WIFI mesh network

2021-11-06 Thread Linus Lüssing
On Fri, Nov 05, 2021 at 04:22:11PM -0700, Dweb Fan wrote: > 4. I follow the document > https://www.kernel.org/doc/Documentation/networking/batman-adv.txt, > but seems like unable to see batman related files/folders under > /sys/class/net/wlan0. Here is output: > $ ls /sys/class/net/wlan0 Hm, seems

Re: Unable to get DHCP after join wlan0 WIFI mesh network

2021-11-06 Thread Linus Lüssing
Hi, Glad to see that more and more people are experimenting with WiFi mesh networks. On Fri, Nov 05, 2021 at 04:22:11PM -0700, Dweb Fan wrote: > Dear all, > > Thanks for making such a great project! > > I'm following the guide from > https://github.com/binnes/WiFiMeshRaspberryPi, and setting up

[PATCHv3] batman-adv: allow netlink usage in unprivileged containers

2021-11-01 Thread Linus Lüssing
algo. Instead it is advised to use the newly introduced "batctl if create routing_algo RA_NAME" / IFLA_BATADV_ALGO_NAME to set the routing algorithm on interface creation, which already works fine in an unprivileged container. Cc: Tycho Andersen Signed-off-by: Linus Lüssing --- Chang

[PATCHv2] batman-adv: allow netlink usage in unprivileged containers

2021-10-31 Thread Linus Lüssing
algo. Instead it is advised to use the newly introduced "batctl if create routing_algo RA_NAME" / IFLA_BATADV_ALGO_NAME to set the routing algorithm on interface creation, which already works fine in an unprivileged container. Cc: Tycho Andersen Signed-off-by: Linus Lüssing --- Changelog

[PATCH] batman-adv: allow netlink usage in unprivileged containers

2021-10-31 Thread Linus Lüssing
algo. Instead it is advised to use the newly introduced "batctl if create routing_algo RA_NAME" / IFLA_BATADV_ALGO_NAME to set the routing algorithm on interface creation, which already works fine in an unprivileged container. Cc: Tycho Andersen Signed-off-by: Linus Lüssing --- Cc

Re: Dynamic DHCP server assignment and spin-up on batman-adv mesh network

2021-09-01 Thread Linus Lüssing
On Wed, Sep 01, 2021 at 09:54:36PM +0200, Linus Lüssing wrote: > On Tue, Aug 31, 2021 at 05:28:41PM -, tanner.perk...@cnftech.com wrote: > > If this is not the best place to ask questions regarding mesh networks > > utilizing the batman-adv kernel module, I apologies and ple

Re: Dynamic DHCP server assignment and spin-up on batman-adv mesh network

2021-09-01 Thread Linus Lüssing
On Tue, Aug 31, 2021 at 05:28:41PM -, tanner.perk...@cnftech.com wrote: > If this is not the best place to ask questions regarding mesh networks > utilizing the batman-adv kernel module, I apologies and please point me to > where I need to be. > > I'm looking to set up distributed mesh netwo

[PATCH v3 3/3] batman-adv: bcast: remove remaining skb-copy calls for broadcasts

2021-05-16 Thread Linus Lüssing
riteable skb we use skb_cow() to avoid sharing skb data with the skb clones in the forwarding calls. Signed-off-by: Linus Lüssing --- Changelog v3: * newly added this patch, to move skb_copy()->skb_clone() changes from PATCH 01/03 to a separate patch with its own explanation net/batm

[PATCH v3 2/3] batman-adv: bcast: avoid skb-copy for (re)queued broadcasts

2021-05-16 Thread Linus Lüssing
nes as it uses batadv_skb_head_push()->skb_cow_head(). Signed-off-by: Linus Lüssing --- Changelog v3: * newly added this patch, to move skb_copy()->skb_clone() change from PATCH 01/03 to a separate patch with its own explanation net/batman-adv/send.c | 2 +- 1 file changed, 1 insert

[PATCH v3 1/3] batman-adv: bcast: queue per interface, if needed

2021-05-16 Thread Linus Lüssing
alternative strategies for transmissions on wireless interfaces in the future (for instance sending via unicast transmissions on wireless interfaces, without queueing in batman-adv, if appropriate). Signed-off-by: Linus Lüssing --- Changelog v3: * changed all skb_clone() calls to skb_copy(),

[PATCH] batman-adv: mcast: add MRD + routable IPv4 multicast with bridges support

2021-05-15 Thread Linus Lüssing
:2), which every IPv6 multicast router is listening to. However this would also include more nodes than necessary: For instance nodes which are just a router for unicast, but not multicast would be included, too. Signed-off-by: Linus Lüssing --- Please double check the Linux version in compat-inc

Re: [PATCH v2] batman-adv: bcast: queue per interface, if needed

2021-05-14 Thread Linus Lüssing
On Fri, May 14, 2021 at 10:28:53AM +0200, Sven Eckelmann wrote: > On Tuesday, 27 April 2021 20:45:27 CEST Linus Lüssing wrote: > > - * The skb is not consumed, so the caller should make sure that the > > - * skb is freed. > > + * This call clones the given skb, hence the call

Re: [net-next v2 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-05-11 Thread Linus Lüssing
On Tue, May 11, 2021 at 12:29:41PM +0300, Nikolay Aleksandrov wrote: > [...] > > -static void br_multicast_mark_router(struct net_bridge *br, > > -struct net_bridge_port *port) > > +#if IS_ENABLED(CONFIG_IPV6) > > +struct hlist_node * > > +br_ip6_multicast_get_rport_

[net-next v2 11/11] net: bridge: mcast: export multicast router presence adjacent to a port

2021-05-09 Thread Linus Lüssing
bridge. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index b625fd6..e963de5 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge

[net-next v2 10/11] net: bridge: mcast: add ip4+ip6 mcast router timers to mdb netlink

2021-05-09 Thread Linus Lüssing
Now that we have split the multicast router state into two, one for IPv4 and one for IPv6, also add individual timers to the mdb netlink router port dump. Leaving the old timer attribute for backwards compatibility. Signed-off-by: Linus Lüssing --- include/uapi/linux/if_bridge.h | 2 ++ net

[net-next v2 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-05-09 Thread Linus Lüssing
include a multicast router timeout for both IPv4 and IPv6. Signed-off-by: Linus Lüssing --- net/bridge/br_forward.c | 8 ++ net/bridge/br_mdb.c | 10 ++ net/bridge/br_multicast.c | 197 ++ net/bridge/br_private.h | 6 +- 4 files changed, 201

[net-next v2 08/11] net: bridge: mcast: split router port del+notify for mcast router split

2021-05-09 Thread Linus Lüssing
avoid sending one for IPv4 and one for IPv6. For that the split is needed. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 40 ++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c

[net-next v2 07/11] net: bridge: mcast: prepare add-router function for mcast router split

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants move the protocol specific router list access to an ip4 wrapper function. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 59 +++ 1 file changed, 41

[net-next v2 06/11] net: bridge: mcast: prepare expiry functions for mcast router split

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants move the protocol specific timer access to an ip4 wrapper function. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 31 ++- 1 file changed, 22 insertions

[net-next v2 05/11] net: bridge: mcast: prepare is-router function for mcast router split

2021-05-09 Thread Linus Lüssing
ip6_mc_router_timer later when the split is performed. While at it also renames the "1" and "2" constants in br_multicast_is_router() to the MDB_RTR_TYPE_TEMP_QUERY and MDB_RTR_TYPE_PERM enums. Signed-off-by: Linus Lüssing --- net/bridge/br_input.c | 2 +- net/bridge/br_multicast.c |

[net-next v2 04/11] net: bridge: mcast: prepare query reception for mcast router split

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants and as the br_multicast_mark_router() will be split for that remove the select querier wrapper and instead add ip4 and ip6 variants for br_multicast_query_received(). Signed-off-by: Linus Lüssing

[net-next v2 03/11] net: bridge: mcast: prepare mdb netlink for mcast router split

2021-05-09 Thread Linus Lüssing
able put one router port entry with both the IPv4 and IPv6 multicast router info later. Signed-off-by: Linus Lüssing --- net/bridge/br_mdb.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index

[net-next v2 02/11] net: bridge: mcast: add wrappers for router node retrieval

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants and to avoid IPv6 #ifdef clutter later add two wrapper functions for router node retrieval in the payload forwarding code. Signed-off-by: Linus Lüssing --- net/bridge/br_forward.c | 15

[net-next v2 01/11] net: bridge: mcast: rename multicast router lists and timers

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants, rename the affected variable to the IPv4 version first to avoid some renames in later commits. Signed-off-by: Linus Lüssing --- net/bridge/br_forward.c | 2 +- net/bridge/br_mdb.c | 6

[PATCH net-next v2 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv

2021-05-09 Thread Linus Lüssing
Hi, The following patches are splitting the so far combined multicast router state in the Linux bridge into two ones, one for IPv4 and one for IPv6, for a more fine-grained detection of multicast routers. This avoids sending IPv4 multicast packets to an IPv6-only multicast router and avoids sendi

[PATCH v2] batman-adv: bcast: queue per interface, if needed

2021-04-27 Thread Linus Lüssing
alternative strategies for transmissions on wireless interfaces in the future (for instance sending via unicast transmissions on wireless interfaces, without queueing in batman-adv, if appropriate). Signed-off-by: Linus Lüssing --- Changelog v2: * removed the other two patches from the patchset f

  1   2   3   4   5   6   7   8   9   10   >