Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix crash on module shutdown with multiple ifaces

2011-04-29 Thread Sven Eckelmann
Linus Lüssing wrote: Ah, oki doki, didn't know about commit 5d4b5a4d and yes, a revert of that commit looks kind of similar to my patch. Commit 5d4b5a4d together with your statement confuse me a little. The commit message does not say anything about a locking dependancy issue, but seems to

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix crash on module shutdown with multiple ifaces

2011-04-27 Thread Linus Lüssing
On Sat, Apr 16, 2011 at 09:54:48AM +0200, Sven Eckelmann wrote: Linus Lüssing wrote: hardif_remove_interfaces() removes all hard interfaces from the hardif_list before freeing and cleaning up any device. However the clean up procedures in orig_hash_del_if()

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix crash on module shutdown with multiple ifaces

2011-04-16 Thread Sven Eckelmann
Sven Eckelmann wrote: Linus Lüssing wrote: hardif_remove_interfaces() removes all hard interfaces from the hardif_list before freeing and cleaning up any device. However the clean up procedures in orig_hash_del_if() (hardif_remove_interface()-hardif_disable_interface()-

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix crash on module shutdown with multiple ifaces

2011-04-15 Thread Linus Lüssing
hardif_remove_interfaces() removes all hard interfaces from the hardif_list before freeing and cleaning up any device. However the clean up procedures in orig_hash_del_if() (hardif_remove_interface()-hardif_disable_interface()- orig_hash_del_if()) need the other interfaces still to be present in