Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: B.A.T.M.A.N. V - implement hard-iface init function

2016-05-21 Thread Antonio Quartulli
On Sat, May 21, 2016 at 02:39:49PM +0200, Sven Eckelmann wrote: > On Saturday 21 May 2016 20:16:14 Antonio Quartulli wrote: > > Some fields in the hard-interface data structure are specific to the > > B.A.T.M.A.N. V protocol and have to be initialized only when such > > protocol is compiled in. > >

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: B.A.T.M.A.N. V - implement hard-iface init function

2016-05-21 Thread Sven Eckelmann
On Saturday 21 May 2016 20:16:14 Antonio Quartulli wrote: > Some fields in the hard-interface data structure are specific to the > B.A.T.M.A.N. V protocol and have to be initialized only when such > protocol is compiled in. > Instead of having a #ifdef block in the middle of the hard-interface.c >

[B.A.T.M.A.N.] [PATCHv3] batman-adv: B.A.T.M.A.N. V - implement hard-iface init function

2016-05-21 Thread Antonio Quartulli
Some fields in the hard-interface data structure are specific to the B.A.T.M.A.N. V protocol and have to be initialized only when such protocol is compiled in. Instead of having a #ifdef block in the middle of the hard-interface.c code it is better to have an algorithm private function that hides t