Re: [B.A.T.M.A.N.] Debian extra modules

2009-10-20 Thread Sven Eckelmann
Holger Levsen wrote: I've shortened Gregs mail to only have the relevant info for this list :-) Full mail is at http://lists.debian.org/debian-kernel/2009/10/msg00236.html There was an announcement some hours ago which explains the (possible) backgrounds further[1]. It looks like the packages

Re: [B.A.T.M.A.N.] basic B.A.T.M.A.N-adv setup

2009-10-20 Thread Sven Eckelmann
Francesco wrote: Hi all, i'm starting a B.A.T.M.A.N. mesh testbed, i've read some messages to find some answers but no luck. I'll try to explain what I've done and the errors i get..hope i get some help in here. From the beginning, I am using batman-adv 3.2 compiled along with batctl.

Re: [B.A.T.M.A.N.] basic B.A.T.M.A.N-adv setup

2009-10-20 Thread Sven Eckelmann
Sven Eckelmann wrote: You must give bat0 also an ip to use IPv4(/6) over it... in most cases only bat0 as it is just the hardware interface the bat0 interface is using. If you only want to test raw ethernet data over bat0 this should work. Meant that wlan0 is just the hardware interface bat0

Re: [B.A.T.M.A.N.] basic B.A.T.M.A.N-adv setup

2009-10-20 Thread Sven Eckelmann
Francesco wrote: Hi Sven, There is nothing like batman-adv 3.2. Where did you got it from? Sorry, my fault, i meant 0.3.2 release. There is no 0.3.2 release. batman-adv hasn't reached 0.2 yet. See http://downloads.open-mesh.net/batman/releases/ for the current releases of batman and

Re: [B.A.T.M.A.N.] basic B.A.T.M.A.N-adv setup

2009-10-20 Thread Sven Eckelmann
Just to highlight it: nexthops ... [B.A.T.M.A.N. Adv 0.1, MainIF/MAC: wlan0/00:0b:6b:34:88:94] batctl isn't compatible with batman-adv 0.1. It was called battool when batman-adv-kernelland 0.1 was released. Best regards, Sven signature.asc Description: This is a digitally signed

Re: [B.A.T.M.A.N.] basic B.A.T.M.A.N-adv setup

2009-10-20 Thread Sven Eckelmann
Francesco wrote: Hi Sven,now I see what was wrong, I'm really feeling so stupid.. :) It was misleading that I reached the batman-adv download page ( http://downloads.open-mesh.net/batman/stable/sources/batman-adv-kernelland/ ) browsing batman 0.3.2 download page (

[B.A.T.M.A.N.] [PATCH] Start to send originator messages when interface gets active

2009-10-21 Thread Sven Eckelmann
The module gets in a inactive state when all interfaces are down. This stops the sending of new packets. When a interface gets activated again it must reactivate the module and then start the sending of new originator messages. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv

Re: [B.A.T.M.A.N.] Debian extra modules

2009-10-29 Thread Sven Eckelmann
Holger Levsen wrote: On Dienstag, 20. Oktober 2009, Sven Eckelmann wrote: I will search for some more information what must be done to support dkms http://lists.debian.org/debian-kernel/2009/10/msg00683.html Thanks. The packages[1,2] are now in Debian unstable. You must have the headers

[B.A.T.M.A.N.] [PATCH] Mark local symbols as static

2009-11-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/aggregation.c |2 +- batman-adv-kernelland/hard-interface.c|6 +++--- batman-adv-kernelland/proc.c |2 +- batman-adv-kernelland/routing.c |4 ++-- batman-adv-kernelland

[B.A.T.M.A.N.] [PATCH] Remove unknown escape string \{

2009-11-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/proc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/batman-adv-kernelland/proc.c b/batman-adv-kernelland/proc.c index 792a006..aac3df7 100644 --- a/batman-adv-kernelland/proc.c +++ b/batman

[B.A.T.M.A.N.] [PATCH] [batctl] Prevent division by zero when no packets were send

2009-11-07 Thread Sven Eckelmann
for that corner case. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batctl/ping.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/batctl/ping.c b/batctl/ping.c index 684a84d..ca1fbf0 100644 --- a/batctl/ping.c +++ b/batctl/ping.c @@ -72,7 +72,7 @@ int ping(int argc

[B.A.T.M.A.N.] [PATCH] [batctl] Remove unreachable code in tcpdump

2009-11-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batctl/tcpdump.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/batctl/tcpdump.c b/batctl/tcpdump.c index b96984b..abf20b1 100644 --- a/batctl/tcpdump.c +++ b/batctl/tcpdump.c @@ -547,8 +547,6 @@ int tcpdump(int

Re: [B.A.T.M.A.N.] batman-adv 0.2 released

2009-11-09 Thread Sven Eckelmann
Donald Gordon wrote: That's really exciting. I have a feature request -- has there been any consideration to getting batman-adv to fragment ethernet frames, so as to get a 1500 byte MTU batman-adv network running on top of a 1500 byte MTU ethernet network? This would mean that we have to

Re: [B.A.T.M.A.N.] batman-adv 0.2 released

2009-11-09 Thread Sven Eckelmann
Marek Lindner wrote: On Monday 09 November 2009 23:08:27 Sven Eckelmann wrote: And if a router receives a to large IP packet is should send an ICMP fragmentation needed and DF set when it cannot be fragmented by the router. The problem is we keep the payload on layer 2, so that it never

Re: [B.A.T.M.A.N.] [PATCHv2] [batman-adv] Removing the big batman lock

2009-12-03 Thread Sven Eckelmann
Andrew Lunn wrote: It seems to deadlock according to https://lists.open-mesh.net/pipermail/b.a.t.m.a.n/2009-December/001938.ht ml Patch was modified by Sven Eckelmann sven.eckelm...@gmx.de to apply cleanly against r1490. Is this just modification so that it cleanly applies

[B.A.T.M.A.N.] Missing depends in staging Kconfig

2009-12-04 Thread Sven Eckelmann
Hi, just did a small test an I think you must change the Kconfig for the batman- adv for staging. I am not 100% sure what is needed, but we definitely need PACKET or otherwise batman-adv will not be able to create a raw socket. More information about that can be found in

Re: [B.A.T.M.A.N.] [PATCHv2] [batman-adv] Removing the big batman lock

2009-12-04 Thread Sven Eckelmann
Simon Wunderlich wrote: @@ -131,9 +197,12 @@ struct orig_node *get_orig_node(uint8_t *addr) INIT_LIST_HEAD(orig_node-neigh_list); memcpy(orig_node-orig, addr, ETH_ALEN); + + orig_node-lock = __SPIN_LOCK_UNLOCKED(device_client-lock); orig_node-router = NULL;

[B.A.T.M.A.N.] [PATCH] [batman-adv] Remove whitespace style errors

2009-12-10 Thread Sven Eckelmann
checkpatch.pl found different smaller errors regarding trailing whitespaces or trailing extra newlines before EOF. These should be removed to follow linux-2.6 CodingStyle. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/CHANGELOG|2 +- batman-adv-kernelland

[B.A.T.M.A.N.] [PATCH] [batman-adv] Remove NULL pointer check before calling kfree

2009-12-10 Thread Sven Eckelmann
It is safe to call kfree(NULL) which makes this extra check unneeded. It was found using checkpatch.pl from linux-2.6 Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/hard-interface.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/batman

Re: [B.A.T.M.A.N.] wireshark-batman-adv: Displaying issue with vis-packets

2009-12-14 Thread Sven Eckelmann
Linus Lüssing wrote: The second originator field of a vis client update packet looks a bit odd in wireshark. Sven :)? (have a look at the attached cap-file for an example) Thanks. This is fixed in v2009.2.0-2-g6f93aff I was also wondering about renaming this field maybe, in the beginning I

[B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Sven Eckelmann
called in process context must disable IRQs when they try to get get that lock to to prevent any reschedule due to IRQs. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/send.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Sven Eckelmann
On Thu, Dec 17, 2009 at 01:25:44PM +0100, Andrew Lunn wrote: This reminds me of something i keep intending to do, but never get around to. It would be nice to have a LOCKING.TXT document, with the following Table of Contents. 1) What locks we have and what they protect. 2) What

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Sven Eckelmann
On Thu, Dec 17, 2009 at 03:34:47PM +0100, Sven Eckelmann wrote: [...] When finding this bug, did you take any notes etc, which could contribute to such a document? [...] The documentation about the context in which each lock/function is used isn't really there for the kernel

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: receive packets directly using skbs

2009-12-23 Thread Sven Eckelmann
Simon Wunderlich wrote: +/* receive a packet with the batman ethertype coming on a hard + * interface */ +int batman_skb_recv(struct sk_buff *skb, struct net_device *dev, + struct packet_type *ptype, struct net_device *orig_dev) +{ + struct batman_packet *batman_packet; + struct

Re: [B.A.T.M.A.N.] can't start batmand

2009-12-23 Thread Sven Eckelmann
Conner, Eric wrote: Does anyone know what is the cause and/or solution to this problem? Either iptables is not installed, iptables not installed in a path which is is part of $PATH, batmand is not started as root or which is not installed/not a builtin function of the shell. Best regards,

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: receive packets directly using skbs

2009-12-23 Thread Sven Eckelmann
On Wed, Dec 23, 2009 at 09:34:17AM -0800, Gus Wirth wrote: On 12/23/2009 02:20 AM, Sven Eckelmann wrote: [snip] This is explained in Understanding Linux Network Internals, Christian Benvenuti, December 2005, O'Reilly, 2.1.5.5. Cloning and copying buffers Where did the 2.1.5.5 come

Re: [B.A.T.M.A.N.] [BULK] Re: [BULK] Re: can't start batmand

2009-12-24 Thread Sven Eckelmann
Conner, Eric wrote: [...] Now I get a second error Error can't flush routing rules: operation not supported batmand requires the kernel policy routing features enabled. How do I go about enabling these features? It is called IP: policy routing and can be found in kernels menuconfig

Re: [B.A.T.M.A.N.] [PATCHv2 no pgp] batman-adv: receive packets directly using skbs

2009-12-29 Thread Sven Eckelmann
On Mon, Dec 28, 2009 at 04:10:08PM +0100, Simon Wunderlich wrote: This patch removes the (ugly and racy) packet receiving thread and the kernel socket usage. Instead, packets are received directly by registering the ethernet type and handling skbs instead of self-allocated buffers. Some

Re: [B.A.T.M.A.N.] Changeset 1519

2009-12-31 Thread Sven Eckelmann
On Thu, Dec 31, 2009 at 10:37:29AM -0800, Gus Wirth wrote: I'm looking at changeset 1519 and have a question about the patch to routing.c On line 158 there is: if (neigh_node) but later at line 179 there is: if (!neigh_node) for essential the same functionality. Am I confused

[B.A.T.M.A.N.] Correct smaller typographical errors

2010-01-02 Thread Sven Eckelmann
After the infamous neighbo(u)rs patches, I wanted to send some more release critical fixes. :) There are just some possible problems found by Debian's lintian (or by me after searching for more typos) which could easily fixed by upstream. No big changes, but some letters exchanged. There is also

[B.A.T.M.A.N.] [PATCH 2/3] batctl: Differentiate between hyphen and minus in manpage

2010-01-02 Thread Sven Eckelmann
groff differentiate between minus signs and hyphens. The default option is to interpret '-' as hyphens (U+2010) and makes it hard to use copy and paste for options in UTF-8 environments. See http://lists.debian.org/debian-devel/2003/03/msg01481.html for more informations. Signed-off-by: Sven

[B.A.T.M.A.N.] [PATCH 3/3] batman: Correct typographical errors detected by lintian

2010-01-02 Thread Sven Eckelmann
Debian's Lintian detected different smaller typographical errors in the source code and manpages of batctl. * seperate - separate * orginator - originator * modus - mode * deamon - daemon Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman/man/batmand.8 |8 1 files

Re: [B.A.T.M.A.N.] batman-adv gateway support

2010-01-04 Thread Sven Eckelmann
predrag balorda wrote: I've done it 3 times in the last few days and nothing ever happened. Just as I wrote to the list a removal confirmation arrived. Yes, I did it for you as explained. Best regards, Sven signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: atomic variable for vis-srv activation

2010-01-15 Thread Sven Eckelmann
Marek Lindner wrote: On Monday 11 January 2010 12:57:56 you wrote: This fixes the bug discovered by Marek Lindner which did not allow turning on the vis-server before an interface has been added. With this patch we are using a global atomic variable for activating and deactiating the

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: atomic variable for vis-srv activation

2010-01-15 Thread Sven Eckelmann
Sorry for the german mail. This was intended to be off the list. I must accidentally brought that mail back to the mailinglist while playing with mailman. Best regards, Sven signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] Security on adhoc network

2010-01-17 Thread Sven Eckelmann
LAMBA Jaideep wrote: Are there any solutions currently under implementation for providing security (other than open/wep) over adhoc networks ? What kind of security do you need? Security is a big field. Maybe you just mean encryption and authentication. When you only want to make the

Re: [B.A.T.M.A.N.] Security on adhoc network

2010-01-17 Thread Sven Eckelmann
LAMBA Jaideep wrote: I tried WPA_NONE and CCMP with wpa_supplicant on both the sides with preshared keys. By doing this you are right nobody can see the data and I get encryption and authentication. But here comes a twist. Lets say I power off one node completely after initial secure session.

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-19 Thread Sven Eckelmann
Juha Ylönen wrote: I got the latest trunk up and running, some changes were required to get it to crosscompile for ARM (and 2.6.24 kernel). Same behaviour as before, device log shows a lot of activity, but laptop batman doesn't seem to be doing much anything. I tried the wireshark and got a

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-19 Thread Sven Eckelmann
Juha Ylönen wrote: As far as I can see only data from 00:22:fa:dc:9a:ce can be seen (send from us aka laptop?). Have you tested if the adhoc connection between this two devices (arm - laptop) is really working (just set up the adhoc network as usual and then give them an ip instead

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-21 Thread Sven Eckelmann
Juha Ylönen wrote: Yeah, I've been lurking there for a while, but being so much on/off from the computer lately it's been easier to email. I'll certainly begin bugging You through irc once I have time to sit down for a while..=) It would help a lot. We are currently waiting for a lot more

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-22 Thread Sven Eckelmann
Juha Ylönen wrote: This looks interesting, I've had problems with the wlan driver before but it has been quite stable for a while. Wlan chip in use is CSR UniFi 1050, with driver compiled from CSR supplied sources. Cannot find the driver at http://www.csr.com/products/UF1050_over.htm I'll

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-24 Thread Sven Eckelmann
Juha Ylönen wrote: So please test and capture * rawsend from ARM * ping between laptop and arm * a ping -s 1 between laptop and arm I hope that tests help to see were the problem really is. If the ping -s 1 works, can you please also capture a some packets of batman-adv 0.2?

Re: [B.A.T.M.A.N.] 403 Forbidden message while trying to download BMX pdf file

2010-02-10 Thread Sven Eckelmann
Marek Lindner wrote: On Monday 08 February 2010 06:51:35 Julio Cesar Puigpinos wrote: While trying to download the BMX documentation http://downloads.open-mesh.net/batman/misc/bmx.pdf I get a 403 Forbidden message. Is there another link or can it be fixed? It certainly can be fixed

Re: [B.A.T.M.A.N.] FWD: batman: potential null dereference

2010-03-08 Thread Sven Eckelmann
Dan Carpenter wrote: [...] It looks a little bit like checked with clang's static analyzer. This analyzer has problems to track constraints at all. This means that it doesn't catch the update_routes constraint orig_node-router != neigh_node. But I am also not good at tracking that kind

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-11 Thread Sven Eckelmann
Linus Lüssing wrote: - if (vis_packet-seqno - old_info-packet.seqno = 0) { + if (vis_packet-seqno - old_info-packet.seqno + = 1 7 * sizeof(vis_packet-seqno)) { Shouldn't that be 1 7 + 8 * (sizeof(vis_packet-seqno) - 1))? Otherwise you would

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Sven Eckelmann
Sven Eckelmann wrote: That must be #define seq_before(x,y) ((x - y) 1 7 + 8 * (sizeof(x) - 1)) #define seq_after(x,y) ((y - x) 1 7 + 8 * (sizeof(x) - 1)) Nearly correct but accidentally deleted a = #define seq_before(x,y) ((x - y) 1 7 + 8 * (sizeof(x) - 1)) #define seq_after(x,y) ((y

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Sven Eckelmann
Linus Lüssing wrote: Sorry still does not seem to work :). Despite testing it on a setup in batman itself I also tested it with a small c program (which does not work as expected either): But your version works? I would really doubt that when we do the same. The macro will only replace the

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Sven Eckelmann
Sven Eckelmann wrote: Now it gets real cruel, but who cares... C++ wasn't accept in the kernel, so we have to deal with it using some GNUish stuff. #define seq_before(x,y) ({typeof(x) _dummy = (x - y); \ _dummy 1u (7u + 8u * (sizeof(_dummy) - 1u));}) #define

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Sven Eckelmann
Sven Eckelmann wrote: Sven Eckelmann wrote: Now it gets real cruel, but who cares... C++ wasn't accept in the kernel, so we have to deal with it using some GNUish stuff. #define seq_before(x,y) ({typeof(x) _dummy = (x - y); \ _dummy 1u (7u + 8u * (sizeof

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Sven Eckelmann
On Fri, Mar 12, 2010 at 09:57:40PM +0100, Simon Wunderlich wrote: #define seq_before(x,y) ((int8_t) (x - y) 0) #define seq_after(x,y) seq_before(y,x) Not so much bitshifting and may a little bit easier to understand, but also not general and does not pass Svens regression test ... :(

[B.A.T.M.A.N.] [PATCH] batman-adv: Clone shared bat packets before modifying them

2010-03-14 Thread Sven Eckelmann
that these buffers aren't shared with anything else before that function tries to write into it. Otherwise it has to copy the buffers so it is save again to change them. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/routing.c | 16 1 files changed, 12

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Clone shared bat packets before modifying them

2010-03-14 Thread Sven Eckelmann
that these buffers aren't shared with anything else before that function tries to write into it. Otherwise it has to copy the buffers so it is save again to change them. Reported-by: Kevin Steen bat...@kevinsteen.net Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/routing.c

Re: [B.A.T.M.A.N.] Batman Advanced Internet Gateway

2010-04-02 Thread Sven Eckelmann
On Friday 02 April 2010 17:43:48 Clemens John wrote: on https://www.open-mesh.org/wiki/batman-adv stands, that the upcoming batman- adv 0.3 supports advanced gateway handling We are testing Batman Advanced as described in my other thread and I want to share my Internetconnection on our

Re: [B.A.T.M.A.N.] running batman-adv in a openvz VE

2010-04-04 Thread Sven Eckelmann
Sven Eckelmann wrote: OpenVZ-Containers use the same kernel as the host system and I can build and load the module on the host, but I don't know how to access /proc/net/batman-adv from within the container. The container uses a own proc-fs. Ok, that is correct. I wanted to check how

Re: [B.A.T.M.A.N.] [PATCH 4/4] Staging: batman-adv: fix whitespace style issues

2010-04-04 Thread Sven Eckelmann
to the b.a.t.m.a.n. mailing list for further discussion. Is that ok for you? Best regards, Sven Eckelmann signature.asc Description: This is a digitally signed message part.

[B.A.T.M.A.N.] [PATCHv2-maint] Staging: batman-adv: fix whitespace style issues

2010-04-04 Thread Sven Eckelmann
From: Luis de Bethencourt lui...@ubuntu.com This patch fixes the 31 unnecessary whitespaces before a quoted newline that the batman-adv files had. Signed-off-by: Luis de Bethencourt lui...@ubuntu.com [sven.eckelm...@gmx.de: Redone to apply against current version] Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCHv2-trunk] Staging: batman-adv: fix whitespace style issues

2010-04-04 Thread Sven Eckelmann
From: Luis de Bethencourt lui...@ubuntu.com This patch fixes the 31 unnecessary whitespaces before a quoted newline that the batman-adv files had. Signed-off-by: Luis de Bethencourt lui...@ubuntu.com [sven.eckelm...@gmx.de: Redone to apply against current version] Signed-off-by: Sven Eckelmann

Re: [B.A.T.M.A.N.] [PATCH 4/4] Staging: batman-adv: fix whitespace style issues

2010-04-04 Thread Sven Eckelmann
On Sunday 04 April 2010 03:45:52 Luis de Bethencourt wrote: Sorry about the conflict, thanks for redoing the changes. Where can I find the current and development branches? The development is currently done in different branches and SCMs outside the kernel. Andrew Lunn prepares a maint branch

Re: [B.A.T.M.A.N.] [PATCH 4/4] Staging: batman-adv: fix whitespace style issues

2010-04-04 Thread Sven Eckelmann
On Sunday 04 April 2010 13:10:12 you wrote: Thanks a lot for the help Sven. My patch didn't include changes to bat_sysfs.c, where are this changes coming from? Sorry if I'm missing something obvious. Correct, that was part of the redoing of your changes. bat_sysfs.c is only part of the

Re: [B.A.T.M.A.N.] [PATCH 4/4] Staging: batman-adv: fix whitespace style issues

2010-04-04 Thread Sven Eckelmann
On Sunday 04 April 2010 17:02:52 Luis de Bethencourt wrote: Sven, Should I redo the patch you sent taking out the changes that are affected by the above? No, Marek or I or someone who is faster will do the changes needed in batctl. It is high on my agenta and not really complicated. Just

[B.A.T.M.A.N.] [PATCH] batctl: Parse allowed settings for sysfs without whitespace before newline

2010-04-04 Thread Sven Eckelmann
-by: Sven Eckelmann sven.eckelm...@gmx.de --- batctl/functions.c | 18 ++ batctl/functions.h |1 + batctl/sys.c | 13 + 3 files changed, 28 insertions(+), 4 deletions(-) diff --git a/batctl/functions.c b/batctl/functions.c index 7d8be51..e5fe670 100644

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Sven Eckelmann
On Monday 05 April 2010 04:46:03 Simon Wunderlich wrote: Index: a/batman-adv-kernelland/send.c === --- a/batman-adv-kernelland/send.c(revision 1616) +++ a/batman-adv-kernelland/send.c(working copy) @@ -382,12 +382,21 @@

Re: [B.A.T.M.A.N.] Security node authentication in BATMAN network

2010-04-25 Thread Sven Eckelmann
Adrian Byszuk wrote: Hello, I'm currently working on project (part of my Bachelor work) which will use to transfer very sensitive data over the network, and I'd like to use mesh networks to transfer this data. Additionally, it should also be possible for normal people to connect to this

Re: [B.A.T.M.A.N.] [PATCH] 32bit sequence number and TTL for broadcasts

2010-04-26 Thread Sven Eckelmann
Marek Lindner wrote: On Monday 26 April 2010 04:48:13 Sven Eckelmann wrote: First thing: it doesn't compile here :( (UML), but I am quite unsure if this is a UML problem like many other things or a bigger problem it seems that it is uml specific as ATOMIC64_INIT and other thingss

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Update pointer to ethhdr after skb_copy

2010-04-26 Thread Sven Eckelmann
Marek Lindner wrote: @@ -1106,6 +1110,7 @@ int recv_unicast_packet(struct sk_buff *skb) if (!skb) return NET_RX_DROP; unicast_packet = (struct unicast_packet *) skb-data; + ethhdr = (struct ethhdr

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: 32bit sequence number and TTL for broadcasts

2010-04-29 Thread Sven Eckelmann
Sven Eckelmann wrote: [...] Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de [sven.eckelm...@gmx.de: Change atomic64_* back to atomic_*] Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- Simon Wunderlich: These changes required to increase the compatibility level once again

[B.A.T.M.A.N.] [PATCH-maint 2/2] batman-adv: Reduce max characters on a line to 80

2010-04-29 Thread Sven Eckelmann
...@gmail.com Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- device.c| 22 ++- hard-interface.c| 19 +++- main.c | 17 +- main.h |3 +- originator.c| 37 ++-- proc.c

[B.A.T.M.A.N.] [PATCH-trunk 1/2] batman-adv: Fix whitespace problems criticized by checkpatch.pl

2010-04-29 Thread Sven Eckelmann
-by: Luis de Bethencourt lui...@ubuntu.com Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/bitarray.c |2 +- batman-adv-kernelland/main.h |2 +- batman-adv-kernelland/originator.c |4 ++-- batman-adv-kernelland/vis.c|6 +++--- 4 files changed

[B.A.T.M.A.N.] [PATCH-trunk 2/2] batman-adv: Reduce max characters on a line to 80

2010-04-29 Thread Sven Eckelmann
...@gmail.com Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/bat_sysfs.c |3 +- batman-adv-kernelland/device.c| 22 --- batman-adv-kernelland/gateway_client.c| 27 + batman-adv-kernelland/gateway_common.c| 45

Re: [B.A.T.M.A.N.] [PATCH-maint 2/2] batman-adv: Reduce max characters on a line to 80

2010-04-30 Thread Sven Eckelmann
Andrew Lunn wrote: On Thu, Apr 29, 2010 at 04:22:24PM +0200, Sven Eckelmann wrote: Documentation/CodingStyle sets a strongly prefered limit of 80 characters per line in Chapter 2: Breaking long lines and strings. Strings must be broken into smaller parts and long statements must

Re: [B.A.T.M.A.N.] [PATCH-maint 2/2] batman-adv: Reduce max characters on a line to 80

2010-04-30 Thread Sven Eckelmann
Andrew Lunn wrote: - printk(KERN_ERR batman-adv:Not using interface %s (retrying later): interface not active\n, batman_if-dev); + printk(KERN_ERR batman-adv: + Not using interface %s (retrying later): + interface not active\n,

[B.A.T.M.A.N.] [PATCH-maint 2/2v2] batman-adv: Reduce max characters on a line to 80

2010-04-30 Thread Sven Eckelmann
...@gmail.com Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- device.c| 22 ++- hard-interface.c| 20 - main.c | 17 +- main.h |3 +- originator.c| 47

[B.A.T.M.A.N.] [PATCH-trunk 2/2v2] batman-adv: Reduce max characters on a line to 80

2010-04-30 Thread Sven Eckelmann
...@gmail.com Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/bat_sysfs.c |3 +- batman-adv-kernelland/device.c| 22 --- batman-adv-kernelland/gateway_client.c| 28 +- batman-adv-kernelland/gateway_common.c| 45

Re: [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit...

2010-05-01 Thread Sven Eckelmann
Andrew Lunn wrote: diff --git a/device.c b/device.c index 5f7655b..b2ecba2 100644 --- a/device.c +++ b/device.c @@ -20,6 +20,7 @@ */ #include linux/device.h +#include linux/slab.h #include main.h #include device.h #include send.h @@ -27,8 +28,6 @@ #include hash.h #include

[B.A.T.M.A.N.] [PATCH] Staging: batman-adv: send.c: Checkpatch cleanup

2010-05-01 Thread Sven Eckelmann
From: Andrea Gelmini andrea.gelm...@gelma.net drivers/staging/batman-adv/send.c:137: CHECK: multiple assignments should be avoided Signed-off-by: Andrea Gelmini andrea.gelm...@gelma.net Signed-off-by: Greg Kroah-Hartman gre...@suse.de --- drivers/staging/batman-adv/send.c |3 ++- 1 files

Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Import sparse fixes from mainline.

2010-05-01 Thread Sven Eckelmann
: fails in bat_sys.c * 2.6.21: warnings in bat_sys.c (better call it fail) * 2.6.22: warnings in bat_sys.c (better call it fail) * 2.6.23: fails * 2.6.24: fails * 2.6.25: ok * 2.6.26: ok * 2.6.27: ok * 2.6.28: ok But to your patch: Acked-by: Sven Eckelmann sven.eckelm...@gmx.de Best regards

Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Import sparse fixes from mainline.

2010-05-01 Thread Sven Eckelmann
Marek Lindner wrote: On Sunday 02 May 2010 00:34:56 Sven Eckelmann wrote: This has not real something to do with this patch (which is good), but to_net_dev was added in v2.6.20-236-g43cb76d and the README still states that we are compatible with linux 2.6.20. I think we must change

[B.A.T.M.A.N.] Merging of changes only in maint back to trunk

2010-05-03 Thread Sven Eckelmann
Hi, I worked today on a small project [1] to recreated all current features for 0.3 on top of the current changeset in maint. This would be handy when Andrew Lunn will send them to the kernel folks. I discovered several small differences between maint and master which results in slightly

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Merge CHANGELOG with 0.2.1 release

2010-05-03 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/CHANGELOG | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/batman-adv-kernelland/CHANGELOG b/batman-adv-kernelland/CHANGELOG index 8a18163..c8f9d9e 100644 --- a/batman-adv

[B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Merge README with 0.2.1 release

2010-05-03 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/README | 45 +++-- 1 files changed, 29 insertions(+), 16 deletions(-) diff --git a/batman-adv-kernelland/README b/batman-adv-kernelland/README index df21c61..4c2a6c6 100644

[B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Synchronize formating with maint

2010-05-03 Thread Sven Eckelmann
Some changes in batman-adv: Reduce max characters on a line to 80 for trunk and maint branch were made slightly different and should be synchronized for easier tracking of changes between them. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/originator.c |3

Re: [B.A.T.M.A.N.] updated README

2010-05-03 Thread Sven Eckelmann
Marek Lindner wrote: Hey, Andrew pointed out that our README would need a little bit of love. I spent some time to get the text into a decent shape. I attached the full file for a review. Let me know if you find anything. :) Sounds good, but noticed some small typos: * exmaple - example

Re: [B.A.T.M.A.N.] updated README

2010-05-03 Thread Sven Eckelmann
Marek Lindner wrote: And maybe you should increase Linux 2.6.20 to Linux 2.6.21 with your newest backporting efforts. I kept the Linux 2.6.20 in the hope that the recent patches would also make our code work on this old release. I just did not test it. Do we have reason to believe that it

Re: [B.A.T.M.A.N.] sysfs abi documentation

2010-05-09 Thread Sven Eckelmann
Marek Lindner wrote: Hi, Greg asked us to provide an ABI documentation for the files creates in the sysfs tree. Since I am respsonsible for the sysfs stuff, I felt it was my turn to draft something. Please check the attachments and let me know whether you think we can send it or not. I've

Re: [B.A.T.M.A.N.] batman patch authorship mangled

2010-05-12 Thread Sven Eckelmann
regards, Sven Eckelmann signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] [PATCH 13/26] staging:batman-adv: convert multiple /proc files to use sysfs

2010-05-12 Thread Sven Eckelmann
client/ server into that file and read the same value. So probably in the sysfs list) Best regards, Sven Eckelmann signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] [PATCH 13/26] staging:batman-adv: convert multiple /proc files to use sysfs

2010-05-12 Thread Sven Eckelmann
, Sven Eckelmann signature.asc Description: This is a digitally signed message part.

[B.A.T.M.A.N.] [PATCHv2] batman-adv: remove all rcu head initializations

2010-05-17 Thread Sven Eckelmann
...@efficios.com Signed-off-by: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Andrew Lunn and...@lunn.ch Cc: Simon Wunderlich s...@hrz.tu-chemnitz.de Cc: Marek Lindner lindner_ma...@yahoo.de Cc: Sven Eckelmann sven.eckelm...@gmx.de Signed-off-by: Greg Kroah-Hartman gre...@suse.de Signed-off-by: Sven

[B.A.T.M.A.N.] Converting from /dev to debugfs

2010-05-17 Thread Sven Eckelmann
Hi, we had decided that different files must move from sysfs to debugfs in recent discussion with gregkh. But their was also the problem that we currently use /dev/batman-adv to send special batman-adv icmp packets to the mesh. This file is maybe a problem when we want to support different

Re: [B.A.T.M.A.N.] Converting from /dev to debugfs

2010-05-18 Thread Sven Eckelmann
Sven Eckelmann wrote: Unfortunately I am not able to continue it today, but don't want to stop other people working on similar things. I will attach v0 (aka works for me, but maybe not perfect/good enough) versions of these patches to support them. Please feel free to discuss the patches. I

[B.A.T.M.A.N.] [PATCHv1 4/4] batctl: Get tables from debugfs instead of sysfs

2010-05-18 Thread Sven Eckelmann
batctl must read the tables exported by batman-adv from debugfs as the old files in /sys/class/net/bat0/mesh/ were removed to follow the sysfs guidelines. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batctl/Makefile |4 +- batctl/debug.c | 103

[B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: Move tables from sysfs to debugfs

2010-05-18 Thread Sven Eckelmann
Files which represent more than a single attribute aren't allowed in sysfs. As we have some files which aren't essential and are lists or tables aggregated from data from different places inside batman-adv, we must place them in a filesystem without such a restriction. Signed-off-by: Sven

[B.A.T.M.A.N.] [PATCH] batman-adv: Call unregister_netdev on failures to get rtnl lock

2010-05-19 Thread Sven Eckelmann
the semaphore in a error case. So we must use unregister_netdev. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/batman-adv-kernelland/main.c b/batman-adv-kernelland/main.c index cbabba6

[B.A.T.M.A.N.] [PATCH] batman-adv: Don't call free_netdev twice

2010-05-19 Thread Sven Eckelmann
Free_netdev is registered as destructor in interface_setup for every soft_device. This destructor is automatically called from unregister_netdev and we must not call it again for the freed net_device. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-adv-kernelland/main.c |3

[B.A.T.M.A.N.] [PATCHv3 3/4] batman-adv: Move tables from sysfs to debugfs

2010-05-19 Thread Sven Eckelmann
Files which represent more than a single attribute aren't allowed in sysfs. As we have some files which aren't essential and are lists or tables aggregated from data from different places inside batman-adv, we must place them in a filesystem without such a restriction. Signed-off-by: Sven

[B.A.T.M.A.N.] [PATCH] batman-adv: Don't allocate icmp packet with GFP_KERNEL

2010-05-19 Thread Sven Eckelmann
A new buffer for a packet is created when a icmp packet is received. This happens in a context with disabled irq. Thus we are not allowed to sleep or call function which might sleep. kmalloc must be called with GFP_ATOMIC instead of GFP_KERNEL to ensure that it does not sleep. Signed-off-by: Sven

[B.A.T.M.A.N.] [PATCH-maint] batman-adv: Call unregister_netdev on failures to get rtnl lock

2010-05-19 Thread Sven Eckelmann
the semaphore in a error case. So we must use unregister_netdev. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- This patch is created for maint and should be applied using `git am`. Following patches should be applied before: * batman-adv: Move device for icmp injection to debugfs * batman-adv

[B.A.T.M.A.N.] [PATCH-maint] batman-adv: Don't call free_netdev twice

2010-05-19 Thread Sven Eckelmann
Free_netdev is registered as destructor in interface_setup for every soft_device. This destructor is automatically called from unregister_netdev and we must not call it again for the free'd net_device. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- This patch is created for maint

Re: [B.A.T.M.A.N.] Converting to sysfs - maint versions

2010-05-19 Thread Sven Eckelmann
Sven Eckelmann wrote: The patches are for trunk, but I would provide backported versions when the patches are discussed and we could solve the problem in a sane way. I've backported following patches to a version which can be applied using git-am on top of the maint branch of batctl and batman

[B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Move device for icmp injection to debugfs

2010-05-19 Thread Sven Eckelmann
doesn't allow to use complete separated meshes as we rely on structures which are not part of the private data of a batman device. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- Please apply using git-am on top of batman-adv maint branch Makefile.kbuild |2 +- bat_debugfs.c

<    1   2   3   4   5   6   7   8   9   10   >