[B.A.T.M.A.N.] [PATCH 11/18] batman-adv: Prefix originator local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- originator.c | 54

[B.A.T.M.A.N.] [PATCH 12/18] batman-adv: Prefix routing local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- routing.c | 65

[B.A.T.M.A.N.] [PATCH 13/18] batman-adv: Prefix send local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- send.c | 30

[B.A.T.M.A.N.] [PATCH 14/18] batman-adv: Prefix soft-interface local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- soft-interface.c | 105

[B.A.T.M.A.N.] [PATCH 15/18] batman-adv: Prefix translation-table local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c | 540

[B.A.T.M.A.N.] [PATCH 16/18] batman-adv: Prefix unicast local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- unicast.c | 47

[B.A.T.M.A.N.] [PATCH 17/18] batman-adv: Prefix vis local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- vis.c | 201

[B.A.T.M.A.N.] [PATCH] batman-adv: Mark only locally used symbol batadv_tt_local_crc as static

2012-05-13 Thread Sven Eckelmann
29ccfec94d51f7725124786e29d023b212920661 changed the translation table code in such a way that it doesn't use the symbol tt_local_crc outside of translation-table.c Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c |2 +- translation-table.h |1 - 2 files changed

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Replace simple function like defines with functions

2012-05-13 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |5 +--- distributed-arp-table.c | 75 +-- distributed-arp-table.h |8 - main.h | 37 +++ 4 files changed, 79 insertions

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Prefix remaining function like macros with batadv_

2012-05-13 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |4 +-- bat_iv_ogm.c|6 ++-- bat_sysfs.c | 81 +-- distributed-arp-table.c |6 ++-- gateway_client.c|2 +- gateway_common.c

[B.A.T.M.A.N.] [PATCH] batman-adv: Directly print to seq_file in vis

2012-05-13 Thread Sven Eckelmann
The vis output doesn't need to be buffered in an character buffer before it can be send to the userspace program that reads from the vis debug file. Signed-off-by: Sven Eckelmann s...@narfation.org --- vis.c | 228 - 1 file changed

Re: [B.A.T.M.A.N.] [PATCH 03/18] batman-adv: Prefix bat_sysfs local static functions with batadv_

2012-05-16 Thread Sven Eckelmann
On Tuesday 15 May 2012 17:54:58 Marek Lindner wrote: On Sunday, May 13, 2012 00:33:52 Sven Eckelmann wrote: All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep

[B.A.T.M.A.N.] Remaining cleanup/prefixing patches

2012-05-16 Thread Sven Eckelmann
Hi, it seems that just too many changes were done and now all were committed in the order or the version that I send to the mailinglist. Therefore, I would ask to ignore all my remaining patches and wait for the the complete list of patches not yet committed. I will send them to this mailing

[B.A.T.M.A.N.] [PATCH 01/13] batman-adv: Prefix routing local static functions with batadv_

2012-05-16 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- routing.c | 65

[B.A.T.M.A.N.] [PATCH 02/13] batman-adv: Prefix send local static functions with batadv_

2012-05-16 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- send.c | 30

[B.A.T.M.A.N.] [PATCH 08/13] batman-adv: Mark only locally used symbol batadv_tt_local_crc as static

2012-05-16 Thread Sven Eckelmann
29ccfec94d51f7725124786e29d023b212920661 changed the translation table code in such a way that it doesn't use the symbol tt_local_crc outside of translation-table.c Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c |2 +- translation-table.h |1 - 2 files changed

[B.A.T.M.A.N.] [PATCH 09/13] batman-adv: Replace simple function like defines with functions

2012-05-16 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |5 +--- distributed-arp-table.c | 76 +-- distributed-arp-table.h |8 - main.h | 37 +++ 4 files changed, 79 insertions

[B.A.T.M.A.N.] [PATCH 10/13] batman-adv: Prefix remaining function like macros with batadv_

2012-05-16 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |4 +-- bat_iv_ogm.c|6 ++-- bat_sysfs.c | 81 +-- distributed-arp-table.c |6 ++-- gateway_client.c|2 +- gateway_common.c

[B.A.T.M.A.N.] [PATCH 11/13] batman-adv: Directly print to seq_file in vis

2012-05-16 Thread Sven Eckelmann
The vis output doesn't need to be buffered in an character buffer before it can be send to the userspace program that reads from the vis debug file. Signed-off-by: Sven Eckelmann s...@narfation.org --- vis.c | 228 - 1 file changed

[B.A.T.M.A.N.] [PATCH 12/13] batman-adv: Remove unused define BAT_ATTR_HIF_UINT

2012-05-16 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c | 47 --- 1 file changed, 47 deletions(-) diff --git a/bat_sysfs.c b/bat_sysfs.c index 336a61d..e4e4b84 100644 --- a/bat_sysfs.c +++ b/bat_sysfs.c @@ -122,53 +122,6 @@ ssize_t

[B.A.T.M.A.N.] [PATCH 13/13] batman-adv: Use typedef instead of define for type dat_addr_t

2012-05-16 Thread Sven Eckelmann
This wrong type definition was introduced in a34852f63a694e3f35eb155101120a3c6f4dd6ee Signed-off-by: Sven Eckelmann s...@narfation.org --- types.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types.h b/types.h index 6f3d6f6..73aaef9 100644 --- a/types.h +++ b/types.h

[B.A.T.M.A.N.] [PATCH] batman-adv: Revert Distributed ARP Table

2012-05-17 Thread Sven Eckelmann
table timeout * batman-adv: Distributed ARP Table - add compile option Signed-off-by: Sven Eckelmann s...@narfation.org --- This patch is for next... I repeat: this patch is for the branch next Makefile|2 - Makefile.kbuild |1 - README |3

[B.A.T.M.A.N.] [PATCH] batman-adv: Prefix bat_sysfs local static functions with batadv_

2012-05-18 Thread Sven Eckelmann
98881e49493eb1a6ae2330d861386432064b. Signed-off-by: Sven Eckelmann s...@narfation.org This is the alternative version of this patch... that keeps the functionality for ELP bat_sysfs.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bat_sysfs.c b/bat_sysfs.c index 336a61d..07fde83 100644

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Revert Distributed ARP Table

2012-05-19 Thread Sven Eckelmann
On Thursday 17 May 2012 18:23:33 Sven Eckelmann wrote: Hi, I wanted to give some additional files that should help to make the revert a little bit easier. revert-patches.tar.xz contains the separated revert-commit that produced the complete revert batman-adv: Revert Distributed ARP Table

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Remove batadv_ vararg inline functions

2012-05-20 Thread Sven Eckelmann
gcc doesn't support the inlining of functions using vararg. Sparse fails to build the source when having such functions marked using the keyword inline. This problem was introduced in 3b896e321c49e3cbbfd540f537c007db883c3900 Signed-off-by: Sven Eckelmann s...@narfation.org --- I've decided

[B.A.T.M.A.N.] [PATCH] batman-adv: Use batctl indentation of bat_packettype

2012-05-25 Thread Sven Eckelmann
The style of the indentation was changed in 206af118414355e867e725ea83bc3a2989db5a40 Signed-off-by: Sven Eckelmann s...@narfation.org --- packet.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packet.h b/packet.h index 205879e..c90219c 100644 --- a/packet.h

Re: [B.A.T.M.A.N.] hotplug.d

2012-05-27 Thread Sven Eckelmann
On Sunday 27 May 2012 03:50:30 Marek Lindner wrote: Filippo, there is an error in /etc/hotplug.d/net/99-batman-adv at line 9. The function that be called is bat_config and not config_bat Could someone fix it in latest batman-adv stable release? could you please be more precise

[B.A.T.M.A.N.] [PATCH 01/16] batman-adv: Prefix local defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c| 26 +++-- bat_sysfs.c | 112 +++--- gateway_client.c | 12 +++--- vis.c| 18 + 4 files

[B.A.T.M.A.N.] [PATCH 04/16] batman-adv: Prefix bridge_loop_avoidance defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |4 ++-- bridge_loop_avoidance.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index

[B.A.T.M.A.N.] [PATCH 06/16] batman-adv: Prefix icmp_socket defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- icmp_socket.c |2 +- icmp_socket.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/icmp_socket.c b/icmp_socket.c index 8960ee6..1f6df39 100644 --- a/icmp_socket.c

[B.A.T.M.A.N.] [PATCH 08/16] batman-adv: Prefix types defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- hard-interface.c | 11 ++- soft-interface.c |2 +- types.h |9 - 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hard-interface.c b/hard

[B.A.T.M.A.N.] [PATCH 11/16] batman-adv: Prefix main defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile|2 +- bat_debugfs.c |2 +- bat_iv_ogm.c| 101 --- bat_sysfs.c |7

[B.A.T.M.A.N.] [PATCH 12/16] batman-adv: Prefix gateway enum with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c |4 ++-- bat_sysfs.c | 14 +++--- gateway_client.c |8 gateway_common.h |8 soft-interface.c | 10 +- 5 files changed, 22

[B.A.T.M.A.N.] [PATCH 13/16] batman-adv: Prefix hard-interface enum with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c|6 +++--- bat_sysfs.c | 27 --- bridge_loop_avoidance.c |2 +- gateway_client.c|2 +- hard-interface.c

[B.A.T.M.A.N.] [PATCH 07/16] batman-adv: Prefix packet defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 20 ++-- hard-interface.c|3 ++- icmp_socket.c |4 ++-- main.c |4 ++-- packet.h| 12

[B.A.T.M.A.N.] [PATCH 14/16] batman-adv: Prefix types enum with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c|8 routing.c | 10 +- soft-interface.c|8 translation-table.c |8 types.h | 28

[B.A.T.M.A.N.] [PATCH 09/16] batman-adv: Prefix unicast defines with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- originator.c |2 +- unicast.c|2 +- unicast.h|4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/originator.c b/originator.c index bf9ec39..1980696

[B.A.T.M.A.N.] [PATCH 15/16] batman-adv: Prefix packet enum with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 48 +++-- bat_sysfs.c | 24 --- bridge_loop_avoidance.c | 34 - icmp_socket.c |8 +-- main.c

[B.A.T.M.A.N.] [PATCH 16/16] batman-adv: Prefix main enum with BATADV_

2012-06-03 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 48 +++ bat_sysfs.c | 12 ++-- bat_sysfs.h |4 ++-- bitarray.c |4

[B.A.T.M.A.N.] [PATCH 3/6] batman-adv: Prefix local sysfs struct with batadv_

2012-06-05 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c | 12 ++-- bat_sysfs.h |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/bat_sysfs.c b/bat_sysfs.c index 887c35f..56ed126 100644 --- a/bat_sysfs.c

[B.A.T.M.A.N.] [PATCH 6/6] batman-adv: Transform BATADV_LOG_BUFF(idx) into function

2012-06-05 Thread Sven Eckelmann
The linux Documentation/CodingStyle says that: * Chapter 12: inline functions are preferable to macros resembling functions * Chapter 12.2: Depending on local variables with a magic name is bad * Chapter 12.3: Macros with arguments used as l-value are bad Signed-off-by: Sven Eckelmann s

Re: [B.A.T.M.A.N.] bridging problem

2012-06-05 Thread Sven Eckelmann
On Tuesday 05 June 2012 22:09:51 Walter Robert Ditzler wrote: hi batman list, i have problem setting up batman-adv clients. i could need some help indeed. Can you please describe problems a little bit more in detail. what i want ** | eth0 bat0(wlan0) | mesh network |

Re: [B.A.T.M.A.N.] bridging problem

2012-06-06 Thread Sven Eckelmann
On Wednesday 06 June 2012 00:16:07 Walter Robert Ditzler wrote: hi sven, thank you very much for your reply, in fact my email hasn't arrived as wished! attached i send you a pdf to have a look, if you dont mind, would be very cool! so what works: 1) lan to lan bridge (10.41.200.11

[B.A.T.M.A.N.] [PATCH 1/3] batctl: Prefix packet defines with BATADV_

2012-06-06 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- packet.h | 12 ++-- ping.c | 16 tcpdump.c|8 traceroute.c |4 ++-- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git

[B.A.T.M.A.N.] [PATCH 3/3] batctl: Prefix packet structs with batadv_

2012-06-06 Thread Sven Eckelmann
Reported-by: Martin Hundebøll mar...@hundeboll.net Signed-off-by: Sven Eckelmann s...@narfation.org --- packet.h | 44 +++ ping.c |8 +++ tcpdump.c| 66 +- traceroute.c |2

Re: [B.A.T.M.A.N.] bridging problem

2012-06-06 Thread Sven Eckelmann
On Wednesday 06 June 2012 14:26:12 Walter Robert Ditzler wrote: (with nl80211) *** root@srv-ldeb-basic1:/etc/hostapd# hostapd hostapd.conf Configuration file: hostapd.conf ioctl[SIOCSIFFLAGS]: Name not unique on network nl80211 driver initialization failed. ELOOP: remaining socket: sock=5

Re: [B.A.T.M.A.N.] bridging problem

2012-06-06 Thread Sven Eckelmann
On Wednesday 06 June 2012 14:59:32 Walter Robert Ditzler wrote: sven, root@srv-ldeb-basic1:/etc/hostapd# ifconfig wlan0 down hw ether 02:34:56:78:9a:bc up SIOCSIFFLAGS: Link number out of range root@srv-ldeb-basic1:/etc/hostapd# Ok, this confuses me slightly can you just try to change the

Re: [B.A.T.M.A.N.] bridging problem

2012-06-06 Thread Sven Eckelmann
On Wednesday 06 June 2012 18:13:57 Walter Robert Ditzler wrote: hi sven, just not to mix many things my procedure bellow. i could change the mac of my mesh0 but i saw that there is a problem to bring up wlan0! The problem is that you have to change the mac of mesh0 before bringing up

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove bat_ prefix from bat_{debugfs, sysfs}.{c, h}

2012-06-10 Thread Sven Eckelmann
the main part of the path finding. All other files should not use it and therefore gets renamed. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile.kbuild|4 ++-- bat_debugfs.c = debugfs.c |2 +- bat_debugfs.h = debugfs.h |0 gateway_client.c |2

Re: [B.A.T.M.A.N.] batman-adv gw_mode and ipv6 router advertisements

2012-06-10 Thread Sven Eckelmann
On Monday 11 June 2012 01:23:00 Antonio Quartulli wrote: Are there any plans of implementing in batman-adv something analog to the mangling done on DHCPv4 packets, to RA packets as well? (the mechanism would be the inverse: instead of unicasting queries and replies, propagate to clients

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression

2012-06-10 Thread Sven Eckelmann
On Sunday 10 June 2012 22:05:40 Marek Lindner wrote: Regression was introduced with commit: 98881e49 Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Thanks for the fix. This part was in the code that I wanted to remove (but you need in your next patch). Acked-by: Sven Eckelmann s

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: fix SIF show / store uint regression

2012-06-10 Thread Sven Eckelmann
On Sunday 10 June 2012 22:05:41 Marek Lindner wrote: Regression was introduced with commit: 36709939 Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Thanks for the fix. This part was in the code that I wanted to remove (but you need in your next patch). Acked-by: Sven Eckelmann s

[B.A.T.M.A.N.] [PATCH] batctl: Revert add support for DBG_DAT log level

2012-06-11 Thread Sven Eckelmann
-by: Sven Eckelmann s...@narfation.org --- This one is for next README |1 - man/batctl.8 |2 +- sys.c|7 +-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/README b/README index 44e1ac7..b06aacf 100644 --- a/README +++ b/README @@ -344,7 +344,6

Re: [B.A.T.M.A.N.] bridging problem

2012-06-11 Thread Sven Eckelmann
On Monday 11 June 2012 15:49:24 Walter Robert Ditzler wrote: hi sven, as promised my final report :-) at the end only one question has left, but it is hardware wifi related. i have several alix hardware boxes, now all with double ath5 wlan cards. strange is sometimes when i create the vif

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix include of linux/kernel.h

2012-06-11 Thread Sven Eckelmann
This is a non-fatal include problem that was only detected by cppcheck. The regression was introduced by 4738c60318e757cf0062476e2095caa5b6970a8d Signed-off-by: Sven Eckelmann s...@narfation.org --- types.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types.h b/types.h

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix include of linux/kernel.h

2012-06-11 Thread Sven Eckelmann
On Monday 11 June 2012 16:46:46 Sven Eckelmann wrote: This is a non-fatal include problem that was only detected by cppcheck. The regression was introduced by 4738c60318e757cf0062476e2095caa5b6970a8d The correct commit id is dfaf026ffbc9e3052a14b8071cac2412c2d0f54e Kind regards, Sven

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Correctly check return value from debugfs_create_dir

2012-06-12 Thread Sven Eckelmann
the two setup functions in batadv_debugfs_add_meshif(). [1] http://www.fsl.cs.sunysb.edu/kernel-api/re464.html Signed-off-by: Martin Hundebøll mar...@hundeboll.net [s...@narfation.org: Fix conflicts with namespace patches] Signed-off-by: Sven Eckelmann s...@narfation.org --- debugfs.c | 11

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add the backbone gateway list to debugfs

2012-06-14 Thread Sven Eckelmann
On Thursday 14 June 2012 18:51:59 Simon Wunderlich wrote: This is especially useful if there are no claims yet, but we still want to know which gateways are using bridge loop avoidance in the network. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- [EDIT: forgot to rename the

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix skb-data assignment

2012-06-15 Thread Sven Eckelmann
On Thursday 14 June 2012 22:21:28 Antonio Quartulli wrote: skb_linearize(skb) possibly rearranges the skb internal data and then changes the skb-data pointer value. For this reason any other pointer in the code that was assigned skb-data before invoking skb_linearise(skb) must be re-assigned.

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Add the backbone gateway list to debugfs

2012-06-16 Thread Sven Eckelmann
On Fri, Jun 15, 2012 at 11:46:03AM +0200, Simon Wunderlich wrote: + hlist_for_each_entry_rcu(backbone_gw, node, head, hash_entry) { + last_seen_msecs = jiffies_to_msecs(jiffies - + backbone_gw-lasttime); Please

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove space before semicolon

2012-06-17 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- This one is for next... thx hash.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hash.c b/hash.c index 2b16381..0759c70 100644 --- a/hash.c +++ b/hash.c @@ -73,6 +73,6 @@ void batadv_hash_set_lock_class(struct

Re: [B.A.T.M.A.N.] [PATCHv4] batman-adv: Add the backbone gateway list to debugfs

2012-06-18 Thread Sven Eckelmann
On Mon, Jun 18, 2012 at 12:21:32PM +0200, Simon Wunderlich wrote: + msecs = msecs % 1000; + + + is_own = batadv_compare_eth(backbone_gw-orig, Why two empty lines? +static inline int batadv_bla_backbone_table_seq_print_text(struct seq_file *seq, +

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix skb-data assignment

2012-06-19 Thread Sven Eckelmann
On Tuesday 19 June 2012 00:41:40 David Miller wrote: [] You must only make stable submissions for patches that have made their way into Linus's tree. That is correct. These patches were meant to be sent as reply to the patch you pulled today (that contained the initial Cc: stable@...).

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix skb-data assignment

2012-06-19 Thread Sven Eckelmann
On Tuesday 19 June 2012 02:02:27 David Miller wrote: [] Patches you want to end up in -stable should be submitted for 'net' not 'net-next'. There is no other valid submission scheme. I know that. This is also completely right and not contested by me. I did not submit/create the pull

Re: [B.A.T.M.A.N.] batman-adv: NS-3

2012-06-19 Thread Sven Eckelmann
On Tuesday 19 June 2012 13:44:37 sebastien bindel wrote: Hello everybody, I'm a student who implementing batman-adv in the NS-3 simulator. But I have some questions. Just my opinion: I don't know about every implementation, but most of them were buggy/incomplete and had not many things to do

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix alignment after opened parentheses

2012-06-19 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- ordex: This one is important for you. Please check whether patches in batman-adv/next touch these code parts. They may be the reason that these problems were introduced and must be fixed. Therefore, I would suggest to put this patch directly

Re: [B.A.T.M.A.N.] filling debian log

2012-06-21 Thread Sven Eckelmann
On Thursday 21 June 2012 22:44:41 Walter Robert Ditzler wrote: how are you today? i just ran into a minor problem with my flashybrid box, debian 6.0.5, batman-adv 2012.1. batman-adv fills up my logs! anyone here who knows how to stop loggin or perhaps only never to miss stuff? i tried to

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix alignment after opened parentheses

2012-06-22 Thread Sven Eckelmann
On Tuesday 19 June 2012 20:26:30 Sven Eckelmann wrote: Signed-off-by: Sven Eckelmann s...@narfation.org --- ordex: This one is important for you. Please check whether patches in batman-adv/next touch these code parts. They may be the reason that these problems were introduced and must

Re: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: enable roaming packets to carry flags

2012-06-26 Thread Sven Eckelmann
On Tuesday 26 June 2012 22:00:20 Antonio Quartulli wrote: In case of client-roaming it would be useful to carry TT flags along with the client entry. Information contained in the flags could be used on the new mesh node for several reasons (e.g. particular roaming treatment). This patch

Re: [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: add reference counting for type batadv_tt_orig_list_entry

2012-06-26 Thread Sven Eckelmann
On Tuesday 26 June 2012 22:00:18 Antonio Quartulli wrote: diff --git a/translation-table.c b/translation-table.c index 245cc9a..0f02514 100644 --- a/translation-table.c +++ b/translation-table.c @@ -152,9 +152,12 @@ static void batadv_tt_orig_list_entry_free_rcu(struct rcu_head *rcu) static

Re: [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: detect not yet announced clients

2012-06-26 Thread Sven Eckelmann
On Tuesday 26 June 2012 22:00:21 Antonio Quartulli wrote: With the current TT mechanism a new client joining the network is not immediately able to communicate with other hosts because its MAC address has not been announced yet. This situation holds until the first OGM containing its joining

[B.A.T.M.A.N.] [PATCH 1/2] batctl: Don't leak information through initialized packet fields

2012-06-27 Thread Sven Eckelmann
The reserved fields in batman-adv packets are not set to a constant value. The content of these memory regions is leaked unintentionally to the network. This regression was introduced in ee319368e5d6385458345731e519640889c177c4 Signed-off-by: Sven Eckelmann s...@narfation.org --- ping.c

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Don't leak information through initialized packet fields

2012-06-27 Thread Sven Eckelmann
The reserved fields in batman-adv packets are not set to a constant value. The content of these memory regions is leaked unintentionally to the network. This regression was introduced in c7fb529996cbc47bc8243d6860dac716ae70af82 Signed-off-by: Sven Eckelmann s...@narfation.org --- soft

[B.A.T.M.A.N.] [PATCHv2 1/1] batman-adv: Don't leak information through uninitialized packet fields

2012-06-28 Thread Sven Eckelmann
The reserved fields in batman-adv packets are not set to a constant value. The content of these memory regions is leaked unintentionally to the network. This regression was introduced in c7fb529996cbc47bc8243d6860dac716ae70af82 Signed-off-by: Sven Eckelmann s...@narfation.org --- Based on next

[B.A.T.M.A.N.] [PATCHv2 2/2] batctl: Don't leak information through uninitialized packet fields

2012-06-28 Thread Sven Eckelmann
The reserved fields in batman-adv packets are not set to a constant value. The content of these memory regions is leaked unintentionally to the network. This regression was introduced in ee319368e5d6385458345731e519640889c177c4 Signed-off-by: Sven Eckelmann s...@narfation.org --- Based on next

Re: [B.A.T.M.A.N.] Question about Babel

2012-07-07 Thread Sven Eckelmann
Hi, On Saturday 07 July 2012 14:12:53 Guido Iribarren wrote: [...] First result on google for openmesh yields www.open-mesh.com which might be what you're looking for (i didn't read your hole thread) First thing: open-mesh.com != open-mesh.org (in any useful definition that comes to my mind

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Use BIT(x) macro to calculate bit positions

2012-07-08 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c | 12 +++- main.h | 18 +- packet.h | 30 +++--- 3 files changed, 31 insertions(+), 29 deletions(-) diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index e877af8..e7fcb54

[B.A.T.M.A.N.] [PATCH 2/2] batctl: Use BIT(x) macro to calculate bit positions

2012-07-08 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- main.h |1 + packet.h | 30 +++--- sys.c|8 3 files changed, 20 insertions(+), 19 deletions(-) diff --git a/main.h b/main.h index 4c8b60b..34ac4f5 100644 --- a/main.h +++ b/main.h @@ -34,5 +34,6

[B.A.T.M.A.N.] [PATCH] batman-adv: Don't break statements after assignment operator

2012-07-08 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- This patch assumes that Split batadv_priv in sub-structures for features was accepted bat_iv_ogm.c| 39 +-- bridge_loop_avoidance.c |7 +++ send.c |8

[B.A.T.M.A.N.] [PATCH] batman-adv: Reduce accumulated length of simple statements

2012-07-08 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 41 ++--- bridge_loop_avoidance.c |3 +-- gateway_client.c| 21 + routing.c |3 +-- translation-table.c | 10

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix (nearly-)kernel-doc comments for various functions

2012-07-13 Thread Sven Eckelmann
From: Ben Hutchings bhutchi...@solarflare.com Fix incorrect start markers, wrapped summary lines, missing section breaks, incorrect separators, and some name mismatches. Signed-off-by: Ben Hutchings bhutchi...@solarflare.com Signed-off-by: David S. Miller da...@davemloft.net Signed-off-by: Sven

Re: [B.A.T.M.A.N.] [PATCHv9 1/8] batman-adv: add UNICAST_4ADDR packet type

2012-07-14 Thread Sven Eckelmann
Hi, just some things that came to my mind after reading Ben Hutchings patch. On Saturday 14 July 2012 01:41:43 Antonio Quartulli wrote: +/** + * batadv_prepare_unicast_packet - encapsulate an skb with a unicast header + * + * @skb: the skb containing the payload to encapsulate + *

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Split batadv_priv in sub-structures for features

2012-07-15 Thread Sven Eckelmann
On Sunday 15 July 2012 21:26:30 Antonio Quartulli wrote: Hello Sven, some inline comments about the TT part. On Sun, Jul 08, 2012 at 06:49:06 +0200, Sven Eckelmann wrote: The structure batadv_priv grows everytime a new feature is introduced. It gets hard to find the parts of the struct

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix wrong multiline comment ending

2012-07-18 Thread Sven Eckelmann
This regression was introduced in 724d05c8215e4e8186097121595ef20b6ba601b7 Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/translation-table.c b/translation-table.c index 172d50b..37ae4a9 100644

Re: [B.A.T.M.A.N.] RFC: Migration to a new git server backend

2012-07-23 Thread Sven Eckelmann
Hi, I was just asked whether the repo urls will change. I can only say for sure that the administration URL url will be changed. But to the rest... On Sunday 22 July 2012 01:43:25 Sven Eckelmann wrote: Now the question is: Do we want to use this feature or not. We had following ideas: 1. 1

Re: [B.A.T.M.A.N.] 2012.2 OGMs over ethernet issue?

2012-07-25 Thread Sven Eckelmann
On Wed, Jul 25, 2012 at 11:11:30PM +0200, Gioacchino Mazzurco wrote: I have not followed the whole thread but i got scared from this reply I hope I misunderstood if i do on newer version of batman $batctl if add eth0 what happen batman will use this interface to do mesh or will simply

Re: [B.A.T.M.A.N.] RFC: Migration to a new git server backend

2012-07-29 Thread Sven Eckelmann
On Sunday 22 July 2012 01:43:25 Sven Eckelmann wrote: 1. 1 repository per project use only one repo for each project (batman-adv, batctl, batmand, ...) and use branch namespaces for individual users: * master, next, maint for the main stuff * ordex/ (for example ordex/dat

Re: [B.A.T.M.A.N.] Problems to add Batman-adv in wlan0 Nanostation M5

2012-08-01 Thread Sven Eckelmann
On Tuesday 31 July 2012 11:41:15 Esteban Municio wrote: Hi all I`m working on a academic develop project for improve the networks in rural areas in Peru. We are doing some test with 6 Nanostation M5 for create a mesh network. I tried Commotion software with OLSR and all was Ok. Now, we

Re: [B.A.T.M.A.N.] Batman-adv and routed subnets

2012-08-03 Thread Sven Eckelmann
On Friday 03 August 2012 11:08:37 Luca Pretto wrote: Hi folks, I really need a bit of your help! I've already spent a week on this and I can't succeed! :( I'm going to install a small mesh (12 nodes, initially) covering my city and linking some friends of mine. At the moment the equipment

Re: [B.A.T.M.A.N.] Problems with internet connection in a mesh-network, (and dhcp and wireless access)

2012-08-03 Thread Sven Eckelmann
On Thursday 02 August 2012 19:35:34 Esteban Municio wrote: Hi all I wrote recently about problems with our batman-adv mesh implementation in a development proyect in Peru: https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2012-August/007820.html Now we are having problems again. Our

Re: [B.A.T.M.A.N.] Problems with internet connection in a mesh-network, (and dhcp and wireless access)

2012-08-03 Thread Sven Eckelmann
On Friday 03 August 2012 12:41:46 Esteban Municio wrote: Solved! It was a fool thing. I needed to add /sbin/iptables -t nat -A POSTROUTING -o wan interface -j MASQUERADE to the gateway node. A L3 matter! The help came from forum.openwrt , but thanks for your patience ;-) ? I wrote that

Re: [B.A.T.M.A.N.] trouble setting up my mesh

2012-08-07 Thread Sven Eckelmann
On Tuesday 07 August 2012 10:18:13 adam wiz wrote: I am having some trouble setting up batman-adv for my mesh. I can get each access point to see the other using batctl o but I am not able to route messages between my client devices. I think there is something wrong with my bridging. [...] In

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: return proper value in case of hash_add failure

2012-08-11 Thread Sven Eckelmann
On Fri, Aug 10, 2012 at 11:09:26PM +0200, Antonio Quartulli wrote: In case of hash_add failure tt_global_add() must return 0 (which means on entry insertion). Signed-off-by: Antonio Quartulli or...@autistici.org --- This patch is based on master. This bug exists since a bit but nobody

Re: [B.A.T.M.A.N.] [RFC 1/3] batman-adv: bandwidth meter implementation

2012-08-12 Thread Sven Eckelmann
On Thursday 09 August 2012 14:15:24 Edo Monticelli wrote: The bandwith meter module is a simple, kernel-space replacement for bandwith measurements tool like iperf and netper. It is intended to approximate TCP behaviour. It is invoked through ``batctl bw: the protocol is connection oriented,

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused hlist macros in compat.h

2012-08-12 Thread Sven Eckelmann
)); \ - pos ({ prefetch(pos-next); 1; }); \ - pos = rcu_dereference(hlist_next_rcu(pos))) - #define rcu_dereference_protected(p, c) (p) #endif /* KERNEL_VERSION(2, 6, 34) */ Acked-by: Sven Eckelmann s...@narfation.org Kind regards, Sven signature.asc Description

Re: [B.A.T.M.A.N.] [RFC 1/3] batman-adv: bandwidth meter implementation

2012-08-13 Thread Sven Eckelmann
On Sunday 12 August 2012 14:20:57 Sven Eckelmann wrote: [...] Sry, disapproved. And just because I just saw it in your git branch: --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ # B.A.T.M.A.N. debugging: export CONFIG_BATMAN_ADV_DEBUG=n # B.A.T.M.A.N. bridge loop avoidance: -export

Re: [B.A.T.M.A.N.] [RFC 1/3] batman-adv: bandwidth meter implementation

2012-08-13 Thread Sven Eckelmann
On Thursday 09 August 2012 14:15:24 Edo Monticelli wrote: [...] +dst_unreach: + /* TODO not in .h + icmp_to_send-msg_type = DESTINATION_UNREACHABLE; + batadv_socket_add_packet(socket_client, icmp_to_send, packet_len); + */ [...] + goto out; /* TODO send an ack!

[B.A.T.M.A.N.] [RFC] batman-adv: Set special lockdep classes to avoid lockdep warning

2012-08-19 Thread Sven Eckelmann
[text will be added after I am awake... maybe] [Should be fix the problem found in bug 162... formerly known as 161. code stolen from macvlan... this is just a reimplementation of a solution proposed by Simon Wunderlich] Reported-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Sven

[B.A.T.M.A.N.] [PATCHv2] batctl: Clear screen using ANSI escape codes

2012-08-19 Thread Sven Eckelmann
Quartulli or...@autistici.org Signed-off-by: Sven Eckelmann s...@narfation.org --- Add comment functions.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/functions.c b/functions.c index c78e408..e095fd0 100644 --- a/functions.c +++ b/functions.c @@ -184,7 +184,8 @@ open

[B.A.T.M.A.N.] [PATCH] batman-adv: Set special lockdep classes to avoid lockdep warning

2012-08-19 Thread Sven Eckelmann
for each transmission. Reported-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Sven Eckelmann s...@narfation.org --- soft-interface.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/soft-interface.c b/soft-interface.c index 1aee7db..513d50a 100644 --- a/soft

<    6   7   8   9   10   11   12   13   14   15   >