Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: count_real_packets() in batman-adv assumes char is signed

2011-06-15 Thread Sven Eckelmann
David Howells wrote: count_real_packets() in batman-adv assumes char is signed, and returns -1 through it: net/batman-adv/routing.c: In function 'receive_bat_packet': net/batman-adv/routing.c:739: warning: comparison is always false due to limited range of data type Use int instead.

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Fix line over 80 characters

2011-06-15 Thread Sven Eckelmann
This regression was introduced in 02585b0b59becfbf14749f08069862f12bdf. Signed-off-by: Sven Eckelmann s...@narfation.org --- routing.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/routing.c b/routing.c index 3a3cfb8..7ca4b42 100644 --- a/routing.c +++ b/routing.c

[B.A.T.M.A.N.] [PATCH] batman-adv: Move compare_orig to originator.c

2011-06-15 Thread Sven Eckelmann
compare_orig is only used in context of orig_node which is managed inside originator.c. It is not necessary to keep that function inside the header originator.h. Signed-off-by: Sven Eckelmann s...@narfation.org --- originator.c |8 originator.h |8 2 files changed, 8

[B.A.T.M.A.N.] [PATCH] batman-adv: Keep interface_tx as local function

2011-06-15 Thread Sven Eckelmann
interface_tx is not used outside of soft-interface.c and thus doesn't need to be declared inside soft-interface.h Signed-off-by: Sven Eckelmann s...@narfation.org --- soft-interface.c |2 +- soft-interface.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/soft

[B.A.T.M.A.N.] [PATCH 01/12] batman-adv: Move compare_orig to originator.c

2011-06-20 Thread Sven Eckelmann
compare_orig is only used in context of orig_node which is managed inside originator.c. It is not necessary to keep that function inside the header originator.h. Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/originator.c |8 net/batman-adv/originator.h |8

[B.A.T.M.A.N.] [PATCH 02/12] batman-adv: Keep interface_tx as local function

2011-06-20 Thread Sven Eckelmann
interface_tx is not used outside of soft-interface.c and thus doesn't need to be declared inside soft-interface.h Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/soft-interface.c |2 +- net/batman-adv/soft-interface.h |1 - 2 files changed, 1 insertions(+), 2

[B.A.T.M.A.N.] [PATCH 04/12] batman-adv: Reduce usage of char

2011-06-20 Thread Sven Eckelmann
char was used in different places to store information without really using the characteristics of that data type or by ignoring the fact that char has not a well defined signedness. Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/aggregation.c|2 +- net/batman-adv

[B.A.T.M.A.N.] [PATCH 03/12] batman-adv: count_real_packets() in batman-adv assumes char is signed

2011-06-20 Thread Sven Eckelmann
instead. Signed-off-by: David Howells dhowe...@redhat.com [s...@narfation.org: Rebase on top of current version] Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/bitarray.c |4 ++-- net/batman-adv/bitarray.h |4 ++-- net/batman-adv/routing.c |8 3 files

[B.A.T.M.A.N.] pull request: batman-adv 2011-06-20

2011-06-20 Thread Sven Eckelmann
in userspace batman-adv: gateway election code refactoring batman-adv: throw uevent in userspace on gateway add/change/del event batman-adv: improved gateway tq-based selection David Howells (1): batman-adv: count_real_packets() in batman-adv assumes char is signed Sven Eckelmann

[B.A.T.M.A.N.] [PATCH 05/12] batman-adv: Unify the first 3 bytes in each packet

2011-06-20 Thread Sven Eckelmann
From: Antonio Quartulli or...@autistici.org The amount of duplicated code in the receive and routing code can be reduced when all headers provide the packet type, version and ttl in the same first bytes. Signed-off-by: Antonio Quartulli or...@autistici.org Signed-off-by: Sven Eckelmann s

[B.A.T.M.A.N.] [PATCH 07/12] batman-adv: improved roaming mechanism

2011-06-20 Thread Sven Eckelmann
destination utilising the fresher information. Thus reducing the packet drops and the connection recovery delay. Signed-off-by: Antonio Quartulli or...@autistici.org Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/hard-interface.c|4 + net/batman-adv/main.c |2

[B.A.T.M.A.N.] [PATCH 08/12] batman-adv: protect the local and the global trans-tables with rcu

2011-06-20 Thread Sven Eckelmann
From: Antonio Quartulli or...@autistici.org The local and the global translation-tables are now lock free and rcu protected. Signed-off-by: Antonio Quartulli or...@autistici.org Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman

[B.A.T.M.A.N.] [PATCH 10/12] batman-adv: gateway election code refactoring

2011-06-20 Thread Sven Eckelmann
or...@autistici.org Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/gateway_client.c | 142 +++ net/batman-adv/main.c |1 + net/batman-adv/types.h |1 + 3 files changed, 85

[B.A.T.M.A.N.] [PATCH 12/12] batman-adv: improved gateway tq-based selection

2011-06-20 Thread Sven Eckelmann
-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/gateway_client.c | 94 ++- net/batman-adv/gateway_client.h |3 +- net/batman-adv/main.h |3 +- net/batman-adv/soft-interface.c | 10

[B.A.T.M.A.N.] [PATCH 11/12] batman-adv: throw uevent in userspace on gateway add/change/del event

2011-06-20 Thread Sven Eckelmann
Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org --- net/batman-adv/gateway_client.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c index 0350c0c..6381864 100644 --- a/net

Re: [B.A.T.M.A.N.] [PATCH] MAINTAINERS: Remove Sven Eckelmann from BATMAN ADVANCED

2011-06-22 Thread Sven Eckelmann
On Tuesday 21 June 2011 14:35:15 David Miller wrote: From: Sven Eckelmann s...@narfation.org Date: Tue, 21 Jun 2011 15:13:03 +0200 I cannot speak on behalf of the batman-adv developers due to conflicts in the opinion about the ongoing development. The batman-adv module is still

[B.A.T.M.A.N.] [PATCH] batman-adv: Replace version info instead of appending them

2011-07-05 Thread Sven Eckelmann
problems and can therefore be omitted. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile |2 +- Makefile.kbuild |2 +- gateway_client.c |5 ++--- main.c |9 ++--- main.h | 11 +++ originator.c |5 ++--- 6 files changed

[B.A.T.M.A.N.] [PATCH] batctl: Replace version info instead of appending them

2011-07-05 Thread Sven Eckelmann
to identify problems and can therefore be omitted. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile |9 ++--- main.c |2 +- main.h |6 +++--- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index eee5a63..85efc30 100755

Re: [B.A.T.M.A.N.] batctl vd dot buggy

2011-07-05 Thread Sven Eckelmann
On Tuesday 05 July 2011 15:56:37 Gioacchino Mazzurco wrote: on our server we have batman-adv from 2.6.38 kernel the output of batctl vd dot results buggy eigenServer gioacchino # batctl -v batctl 2011.1.0 as you can see here http://eigenlab.org/status.php a lot of blue cluster are

Re: [B.A.T.M.A.N.] batctl vd dot buggy

2011-07-05 Thread Sven Eckelmann
On Tuesday 05 July 2011 23:29:07 Gioacchino Mazzurco wrote: Good job, but what we are trying to fix is the topology visualization we need that at moment Just looked with one eye at the stuff and it seems that the data which comes from the kernel module is not what you expect. For example

Re: [B.A.T.M.A.N.] batctl vd dot buggy

2011-07-05 Thread Sven Eckelmann
On Wednesday 06 July 2011 00:27:28 Sven Eckelmann wrote: It looks like one vis_if_list Stopped again in the middle of the sentence. It looks like vis_if_list is not traversed or empty when adding SEC and PRIMARY. Kind regards, Sven signature.asc Description: This is a digitally

Re: [B.A.T.M.A.N.] Batman packet filter function?

2011-07-13 Thread Sven Eckelmann
On Thursday 14 July 2011 12:23:42 Nik Mohamad Anas Kamarudin wrote: Hello all, I got one question here, quiet noob. How to filter BATMAN layer 2 or BATMAN-ADV packet? Maybe filtering the packet base on MAC address? I already try using iptables and ebtables, but not working. What exactly do

[B.A.T.M.A.N.] [RFC] batman-adv: Remove compat code for kernel versions 2.6.29

2011-07-17 Thread Sven Eckelmann
for kernels older than 2.6.29 will remove the dead ballast of stuff older than two years. People which need it can revert 7f1b7b837c205e413a7aa078a47ec96f0c11afa7 and this patch. Signed-off-by: Sven Eckelmann s...@narfation.org --- compat.c | 991

[B.A.T.M.A.N.] [RFC] batman-adv: Start to fiddle with compat stuff

2011-07-17 Thread Sven Eckelmann
README |2 +- compat.c |8 compat.h | 17 + soft-interface.c | 31 ++- 4 files changed, 56 insertions(+), 2 deletions(-) diff --git a/README b/README index f590c99..34fda4f 100644 --- a/README +++ b/README

Re: [B.A.T.M.A.N.] [RFC] batman-adv: Start to fiddle with compat stuff

2011-07-17 Thread Sven Eckelmann
On Sunday 17 July 2011 13:11:19 Sven Eckelmann wrote: README |2 +- compat.c |8 compat.h | 17 + soft-interface.c | 31 ++- 4 files changed, 56 insertions(+), 2 deletions(-) The sendmail killed my

Re: [B.A.T.M.A.N.] Filtering BATMAN-ADV packet

2011-07-21 Thread Sven Eckelmann
On Thursday 21 July 2011 11:33:55 Nik M. Anas Kamarudin wrote: [...] /sbin/modprobe /lib/modules/`2.6.35.13/batman-adv/batman-adv.ko /usr/sbin/batctl if add br0 /sbin/ifconfig bat0 192.168.5.41 up /sbin/ifconfig br0 192.168.5.1 up Why has br0 an IP address (and one which seems to be in the

Re: [B.A.T.M.A.N.] Filtering BATMAN-ADV packet

2011-07-21 Thread Sven Eckelmann
On Thursday 21 July 2011 15:28:18 Nik M. Anas Kamarudin wrote: I think this is misunderstanding. This method work fine on wire interface because it use ebtables to filter the batman-adv packet, and ebtables need to be use with bridge interface. And why this method don't work on wireless, is

Re: [B.A.T.M.A.N.] Filtering BATMAN-ADV packet

2011-07-21 Thread Sven Eckelmann
On Thursday 21 July 2011 17:14:28 Nik M. Anas Kamarudin wrote: AP mode? Sry, forget to tell, i using in ad-hoc mode. Maybe i explain more. I try to test batman-adv in MANET. In order to doing that, i need to make a scenario that have changing in topology. That why i need to filter some

Re: [B.A.T.M.A.N.] Filtering BATMAN-ADV packet

2011-07-21 Thread Sven Eckelmann
On Thursday 21 July 2011 11:23:11 Sven Eckelmann wrote: I already told you about it in the first mail what a solution could be. There are two other solutions use the initial idea of ebtables and bridge. Translation: I already explained a different solution in the first mail. There are two

[B.A.T.M.A.N.] [PATCH] batmand: Fix build of batgat module with linux 3.0

2011-07-23 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- This patch depends on the patches currently stored in the branch pu/nonblock_ioctl Btw. findstring sounds a little bit... error-prone linux/modules/Makefile|8 linux/modules/Makefile.kbuild |4 ++-- 2 files changed, 6

[B.A.T.M.A.N.] [PATCHv4 02/11] batman-adv: Remove private define of atomic_dec_not_zero

2011-07-27 Thread Sven Eckelmann
atomic_dec_not_zero is defined through linux/atomic.h for all architectures and batman-adv doesn't need an extra define which may collide with the global one. Signed-off-by: Sven Eckelmann s...@narfation.org Cc: Marek Lindner lindner_ma...@yahoo.de Cc: Simon Wunderlich s...@hrz.tu-chemnitz.de Cc

Re: [B.A.T.M.A.N.] Filtering BATMAN-ADV packet

2011-07-28 Thread Sven Eckelmann
On Thu, Jul 21, 2011 at 12:20:00PM +0200, Andrew Lunn wrote: [...] You might want to consider using a network simulator/emulator. Use a number of user mode linux nodes, or qemu nodes, connected together using a virtual network. You can control the packets losses, paths etc, much easier and

Re: [B.A.T.M.A.N.] per interface hop penalty

2011-07-28 Thread Sven Eckelmann
On Thu, Jul 28, 2011 at 02:31:49PM +0200, Gioacchino Mazzurco wrote: Hey all reading batman-adv documentation I have found the option hop penalty that seems quite good for example with vpn links The problem is that actual hop penalty is per node but not per interface, the fact to have per

Re: [B.A.T.M.A.N.] DNS Batmand

2011-08-02 Thread Sven Eckelmann
On Monday 01 August 2011 16:10:41 Camila Troncoso wrote: I´m working for some time with a wireless mesh. I have several devices with a basic linux inside (Openwrt) and they are running Batmand protocol. One of the mesh nodes acts as a gateway to internet, obtaining IP and DNS trough pppoe.

Re: [B.A.T.M.A.N.] Batman CPU usage

2011-08-15 Thread Sven Eckelmann
On Monday 15 August 2011 12:02:34 Max Ip wrote: The percentage values I have stated are already normalized to 800 Mhz for simplicity. For example in node B (cpu 1000 Mhz) has CPU usage 1%, I use 1% of 1000 which is 10 and now (10/800) is 1.25%. I have thus used 1.25% instead of 1%. You assume

[B.A.T.M.A.N.] batman(d|-vis) deprecated by upstream

2011-08-16 Thread Sven Eckelmann
Hi, I just wanted to inform both of you about the upstream state of the batmand [1] and batman-vis [2]. Marek Lindner stopped to actively maintain batmand a long time ago (my guess was 2009/2010... after the release of v0.3.2). The maintainer role was vacant and Elektra Wagenrad tried to be the

Re: [B.A.T.M.A.N.] A case for batman-11s

2011-08-23 Thread Sven Eckelmann
On Monday 22 August 2011 16:30:56 Javier Cardona wrote: Which brings me to the main point of my e-mail: is anyone out there interested in porting batman's path selection algorithm into open80211s? Which one? There are ~5 revisions of the algorithm (not implementations). The newest iteration

Re: [B.A.T.M.A.N.] Comments on Lifenet?

2011-08-24 Thread Sven Eckelmann
First some comment about your mail: Please don't reply to random threads to start a new topic. On Wed, Aug 24, 2011 at 02:21:47PM -0500, Jon Roland wrote: The effort presented at http://thelifenetwork.org/ seems to be a realization of much of what the BATMAN project is about. Comments? I don't

Re: [B.A.T.M.A.N.] Comments on Lifenet?

2011-08-24 Thread Sven Eckelmann
On Wed, Aug 24, 2011 at 08:03:41PM -0400, Santosh S Vempala wrote: Sven: Thanks for scrolling through the code. Have you actually tried it? Do you have any improvements to suggest? (even if you're not an expert at kernel programming) I will _not_ try to use the code before the obvious

Re: [B.A.T.M.A.N.] Comments on Lifenet?

2011-08-26 Thread Sven Eckelmann
On Friday 26 August 2011 15:32:37 Hrushi Mehendale wrote: Hi Sven, Thank you very much for your frank comments about the code. Another comment about your mail: Don't send html to the mailing list... it will be dropped. Hopefully, with help from experienced programmers such as you and many

Re: [B.A.T.M.A.N.] Comments on Lifenet?

2011-08-26 Thread Sven Eckelmann
On Friday 26 August 2011 22:14:02 Sven Eckelmann wrote: Do you have any suggestions for us to facilitate better interaction with the community, particularly to make sure LifeNet adhers to best programming practices / standards? A nasty comment would be: learn coding Just to make

Re: [B.A.T.M.A.N.] Comments on Lifenet?

2011-08-27 Thread Sven Eckelmann
On Friday 26 August 2011 21:37:29 Outback Dingo wrote: [...] Even worse, requires ant and java to even build i mean seriously? there are so many of these projects popping up all with similiar goals, best case scenerios are a coalition of like minds working to an end result Why is it a

Re: [B.A.T.M.A.N.] batman-adv and coovachilli

2011-09-03 Thread Sven Eckelmann
On Friday 02 September 2011 13:09:44 Filippo Sallemi wrote: Hi all, I've a little problem and i need a confirm from you. I have 2 mesh node (gateway) with this configuration: lan is a bridge with bat0 and wlan0 with node1 ip 10.0.1.1 netmask 255.0.0.0 and node2 ip 10.0.2.1 netmask 255.0.0.0

Re: [B.A.T.M.A.N.] lxc and batman

2011-09-14 Thread Sven Eckelmann
On Wednesday 14 September 2011 18:43:36 clow...@clownix.net wrote: Hello, I was wondering if the batman code in the kernel make batman not compatible with lxc. Lxc are the linux containers that permit to have virtual machines with the least overhead (native speed) but those machines use the

Re: [B.A.T.M.A.N.] lxc and batman

2011-09-15 Thread Sven Eckelmann
On Thursday 15 September 2011 08:40:15 clow...@clownix.net wrote: So, for the multiplication of machines in a big network, you confirm that batman-adv is not compatible with lxc. I never said that it is not compatible with lxc However something is still not clear: with one batman-adv per

Re: [B.A.T.M.A.N.] lxc and batman

2011-09-15 Thread Sven Eckelmann
On Thursday 15 September 2011 09:39:51 clow...@clownix.net wrote: All is now clear, I have no idea about how namespaces work and neither about the batman-adv instances, I am a simple user preparing for a future batman-adv demo network on a single PC. This information is what I wanted, so

Re: [B.A.T.M.A.N.] drop dhcp batman-adv

2011-09-19 Thread Sven Eckelmann
On Monday 19 September 2011 20:12:49 Gioacchino Mazzurco wrote: I am looking for a way to drop dhcp packets forwarding with batman-adv there is some way to do that ? This doesn't look like a task for batman-adv, but for ebtables/iptables. Kind regards, Sven signature.asc Description:

Re: [B.A.T.M.A.N.] New batman-advanced logo

2011-09-28 Thread Sven Eckelmann
On Wednesday 28 September 2011 10:21:57 Simon Wunderlich wrote: BTW, we will also need a vector version from the final logo, anyone volunteering? :) A vector version is not really a problem... a clean vector version would be more work ;) Kind regards, Svenattachment:

Re: [B.A.T.M.A.N.] New batman-advanced logo

2011-09-29 Thread Sven Eckelmann
On Thursday 29 September 2011 07:51:58 fboehm wrote: attached you find my first try of vectorization and simplification of the smallfeet-version. It has very low vector count but perhaps it's already too much different to the artists concept. Quite impressive work. I really like it. The wings

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Don't use EXTRA_CFLAGS to add source version

2011-09-30 Thread Sven Eckelmann
EXTRA_CFLAGS is deprecated since v2.6.23-2309-gf77bf01 and should not be used anymore to add additional flags for the c compiler. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile.kbuild |4 ++-- README |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Replace obsolete strict_strtofoo with kstrtofoo

2011-09-30 Thread Sven Eckelmann
strict_strtofoo is obsolete since v3.1-rc8-8466-g14acc55 and should be replaced with kstrtofoo. Signed-off-by: Sven Eckelmann s...@narfation.org --- Can somebody please make a test for some kernels? I don't have the stuff (and time) right now. bat_sysfs.c |4 ++-- compat.h

Re: [B.A.T.M.A.N.] Batman-adv secure

2011-10-04 Thread Sven Eckelmann
On Tuesday 04 October 2011 23:39:04 Filippo Sallemi wrote: Hi guys, I've read the open-mesh FAQ but I'm not able to resolve my problem. I understood that the mesh network is a public network and that every user have to make sure their connection is secure but i don't want that another node

Re: [B.A.T.M.A.N.] batman-adv version

2011-10-13 Thread Sven Eckelmann
On Thursday 13 October 2011 13:34:59 Gioacchino Mazzurco wrote: Yesterday I have build an openwrt image with batman adv but i see that this version is not complatible with past version, sniffing packets i see batman adv v 14 instead of 12 Now i can update all openwrt nodes but the problem is

Re: [B.A.T.M.A.N.] batman-adv version

2011-10-13 Thread Sven Eckelmann
On Thursday 13 October 2011 14:57:49 Gioacchino Mazzurco wrote: mmm batman-adv openwrt version is 2011.3.0 that seems included in 3.1 kernel but latest kernel available in gentoo is 3.0.6 the other way to install batman-adv in gentoo is the gentoo ebuild but seems more outdated 2011.1.0 :|

Re: [B.A.T.M.A.N.] batman-adv version

2011-10-13 Thread Sven Eckelmann
On Thursday 13 October 2011 14:57:49 Gioacchino Mazzurco wrote: do you think is a good idea to compile latest batman-adv and load it as module on my actual kernel ( 2.6.39 ) ? To be more precise: Use the version with the newest patches from ordex (either from the mailing list or from the maint

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

2011-10-18 Thread Sven Eckelmann
On Tuesday 18 October 2011 13:59:18 Filippo Sallemi wrote: Hi all, after an ./script/feeds update when i try to build openwrt I get an error on batman-adv package: Applying ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet. patch using plaintext: patching file

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

2011-10-18 Thread Sven Eckelmann
On Tuesday 18 October 2011 21:26:26 Filippo Sallemi wrote: Sorry Marek, but how much is stable batman.2011.3.0 ? Can I use it in production? The release itself is not as stable as we wanted. That's why we added those critical patches and will release version 2011.3.1 in the near future.

Re: [B.A.T.M.A.N.] batman-adv 2011.3.1 released

2011-10-19 Thread Sven Eckelmann
On Wednesday 19 October 2011 02:32:10 Michael Stöcker wrote: Am 19.10.2011 00:44, schrieb Marek Lindner: hallo, even if the batctl remains unchanged, could you please update the packagename to 2011.3.1? I would like to update my openwrtbuildroot-batman-adv-makefile to use the new release

Re: [B.A.T.M.A.N.] Warning - packet contains unknown ether type: 0x86dd

2011-10-21 Thread Sven Eckelmann
On Thursday 20 October 2011 21:29:44 Filippo Sallemi wrote: Hi, I dont understand why but some time my nodes show msg: Warning - packet contains unknown ether type: 0x86dd when exec batctl td wlan0. Can anyone tell me what mean? and if it is as problem how to fix. This is not a real

Re: [B.A.T.M.A.N.] pull request: batman-adv 2011-10-29

2011-10-30 Thread Sven Eckelmann
On Sunday 30 October 2011 03:07:45 David Miller wrote: [...] Make a common header: struct tt_entry_common { u8 addr[ETH_ALEN]; struct hlist_node hash_entry; }; Then use that at the beginning of both structures: struct tt_local_entry {

Re: [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: Distributed ARP Table - add snooping functions for ARP messages

2011-10-30 Thread Sven Eckelmann
On Sunday 30 October 2011 09:56:01 Antonio Quartulli wrote: In case of an ARP message going in or out the soft_iface, it is intercepted and a special action is performed. In particular the DHT helper functions previously implemented are used to store all the ARP entries belonging to the

[B.A.T.M.A.N.] Weird TTL for ICMP packets

2011-10-30 Thread Sven Eckelmann
Hi, just looked through some ICMP code in icmp_socket.c and found a little bit weird TTL: 218 if (icmp_packet-version != COMPAT_VERSION) { 219 icmp_packet-msg_type = PARAMETER_PROBLEM;

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: explain the weird TTL for ICMP packets

2011-10-30 Thread Sven Eckelmann
On Sunday 30 October 2011 16:40:46 Simon Wunderlich wrote: A comment may clear this up ... Reported-by: Sven Eckelmann s...@narfation.org Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de NAcked-by: Sven Eckelmann s...@narfation.org No, the problem is that there is a ttl field

Re: [B.A.T.M.A.N.] [PATCH] add make install

2011-11-14 Thread Sven Eckelmann
@@ -42,3 +42,6 @@ all: clean: $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean + +install: + @cp batman-adv.ko $(shell dirname $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko NAck: Sven Eckelmann s...@narfation.org Please read in the current linux sources Documentation/kbuild

Re: [B.A.T.M.A.N.] [PATCH] add make install

2011-11-14 Thread Sven Eckelmann
On Monday 14 November 2011 10:38:07 Sven Eckelmann wrote: On Monday 14 November 2011 10:11:32 Alexey Fisher wrote: Signed-off-by: Alexey Fisher bug-tr...@fisher-privat.net --- Makefile |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) [...] NAck: Sven Eckelmann s

Re: [B.A.T.M.A.N.] [PATCH] add make install

2011-11-14 Thread Sven Eckelmann
On Monday 14 November 2011 11:19:19 Alexey Fisher wrote: [...] Thank you, so you will send your patch? I prefer last version, to make testing easier. I personally don't care. Feel free to fix your patch and send a new version (but think about adding the : after install -- the character

Re: [B.A.T.M.A.N.] [PATCH 0/5] Loop-freness for B.A.T.M.A.N.

2011-11-17 Thread Sven Eckelmann
On Thursday 17 November 2011 16:15:42 Daniele Furlan wrote: This series of patches introduce a correction in tq metric and forwarding rules of ogm packets. In the current configuration routing loops scenario can emerge due to some conceptual errors such the global tq window and the

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Explicitly mark the common header structure

2011-11-20 Thread Sven Eckelmann
regressions by moving some elements around. A new structure is introduced that contains the common header and makes it easier visible that these 3 bytes have to be the same for all on-wire packets. Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 47

[B.A.T.M.A.N.] [PATCH] batctl: Return failure code when ping was not successful

2011-11-20 Thread Sven Eckelmann
to distinguish a general failure from the inability to reach another node. Reported-by: Filippo Sallemi tonyp...@gmail.com Signed-off-by: Sven Eckelmann s...@narfation.org --- main.h |2 ++ ping.c |5 - 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/main.h b/main.h

[B.A.T.M.A.N.] [RFC] batman-adv: Move build compat stuff to Makefile

2011-11-24 Thread Sven Eckelmann
Hi, I looked at the new patches from ordex and thought about using the Makefile from the kernel as the Makefile.kbuild in the standalone distribution. The Makefile is only the user friendly compatibility layer over the kbuild stuff. The problem is: The OpenWRT buildscript only uses the

Re: [B.A.T.M.A.N.] [RFC] batman-adv: Move build compat stuff to Makefile

2011-11-24 Thread Sven Eckelmann
On Thursday 24 November 2011 21:01:21 Marek Lindner wrote: Hi, I looked at the new patches from ordex and thought about using the Makefile from the kernel as the Makefile.kbuild in the standalone distribution. The Makefile is only the user friendly compatibility layer over the kbuild

Re: [B.A.T.M.A.N.] [PATCH] Remove useless condition

2011-11-24 Thread Sven Eckelmann
On Thursday 24 November 2011 14:06:01 Daniele Furlan wrote: --- What do you think about some information, reasoning, examples, Thanks, Sven signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] [RFC] batman-adv: Move build compat stuff to Makefile

2011-11-24 Thread Sven Eckelmann
On Thursday 24 November 2011 14:26:48 Andrew Lunn wrote: I would be even happier when we also could remove the '#include compat.h' from main.h somehow, but I had no good (and working) idea. Hi Sven Could you build solution using the gcc option: -include file Process file as if

Re: [B.A.T.M.A.N.] [RFC] batman-adv: Move build compat stuff to Makefile

2011-11-24 Thread Sven Eckelmann
On Thursday 24 November 2011 21:18:47 Marek Lindner wrote: On Thursday, November 24, 2011 21:01:21 Marek Lindner wrote: I looked at the new patches from ordex and thought about using the Makefile from the kernel as the Makefile.kbuild in the standalone distribution. The Makefile is only

Re: [B.A.T.M.A.N.] [PATCH] Remove useless condition

2011-11-24 Thread Sven Eckelmann
On Thursday 24 November 2011 15:25:40 Daniele Furlan wrote: 2011/11/24 Sven Eckelmann s...@narfation.org: On Thursday 24 November 2011 14:06:01 Daniele Furlan wrote: --- What do you think about some information, reasoning, examples, Ok, using letter a,b,c,k instead of: c

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add biggest_unsigned_int(x) macro

2011-11-25 Thread Sven Eckelmann
On Friday 25 November 2011 09:08:47 Marek Lindner wrote: [...] +/* Returns the biggest unsigned integer with the sizeof x */ +#define biggest_unsigned_int(x) (~(x)0) + The final conclusion of the IRC discussion might have escaped me but wasn't there supposed to be a cast somewhere ?

Re: [B.A.T.M.A.N.] [PATCHv4 1/7] batman-adv: implement an helper function to forge unicast packets

2011-11-25 Thread Sven Eckelmann
On Friday 25 November 2011 09:18:20 Andrew Lunn wrote: [...] + unicast_packet = (struct unicast_packet *)skb-data; + + unicast_packet-header.version = COMPAT_VERSION; + /* batman packet type: unicast */ + unicast_packet-header.packet_type = BAT_UNICAST; + /* set unicast ttl

[B.A.T.M.A.N.] [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Sven Eckelmann
. Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org Cc: Randy Dunlap rdun...@xenotime.net Cc: Richard Henderson r...@twiddle.net Cc: Ivan Kokshaysky i...@jurassic.park.msu.ru Cc: Matt Turner matts...@gmail.com Cc: Russell King li...@arm.linux.org.uk Cc: Tony Luck tony.l

[B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Don't automatically build in parallel

2011-12-04 Thread Sven Eckelmann
Distributions like Gentoo and Debian have policies which make it necessary to use some kind of environmental variable to control the parallel build. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/Makefile

[B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Remove OpenWRT specific makefile rules

2011-12-04 Thread Sven Eckelmann
Makefile and Makefile.kbuild are included by the linux kbuild environment to build the kernel module. Rules by other build systems could lead to hard to debug problems and therefore should be avoided. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile.kbuild |7 --- 1 files

[B.A.T.M.A.N.] [PATCH 4/4] batman-adv: Allow to enable features without editing Makefile

2011-12-04 Thread Sven Eckelmann
features in the makefile by default because the preprocessor will not have the same information. This can be changed later by a more complex configuration system that generates an own compat_autoconf.h that is included by compat.h. This header would have to Signed-off-by: Sven Eckelmann s

Re: [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: Allow to enable features without editing Makefile

2011-12-04 Thread Sven Eckelmann
On Sunday 04 December 2011 20:10:48 Sven Eckelmann wrote: [...] generates an own compat_autoconf.h that is included by compat.h. This header would have to [...] I should have checked that a line doesn't begin with #... nevertheless: define/undef all preprocessor variables used to configure

Re: [B.A.T.M.A.N.] [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Sven Eckelmann
On Sunday 04 December 2011 21:33:16 Russell King - ARM Linux wrote: [...] +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL) I think this is rather silly - all these definitions are very similar to each other. Is there really no way to put this into

Re: [B.A.T.M.A.N.] [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Sven Eckelmann
On Sunday 04 December 2011 22:18:50 Russell King - ARM Linux wrote: On Sun, Dec 04, 2011 at 10:49:10PM +0100, Sven Eckelmann wrote: On Sunday 04 December 2011 21:33:16 Russell King - ARM Linux wrote: [...] +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL

Re: [B.A.T.M.A.N.] [PATCHv5] atomic: add *_dec_not_zero

2011-12-05 Thread Sven Eckelmann
On Monday 05 December 2011 09:41:55 Benjamin Herrenschmidt wrote: On Sun, 2011-12-04 at 22:18 +, Russell King - ARM Linux wrote: .../... And really, I believe it would be a good cleanup if all the standard definitions for atomic64 ops (like atomic64_add_negative) were also defined

Re: [B.A.T.M.A.N.] Fw: Rede Mesh BatmanADV no brazil

2011-12-05 Thread Sven Eckelmann
Hi, On Mon, Dec 05, 2011 at 01:12:42PM -0200, Flavio Leonel suporte tecnico wrote: [...] HUG I HOPE YOU UNDERSTAND MY PROBLEM AND WE CAN TALK MORE Please don't take offense at my answer, but I was not able to understand 90% of the email. Could you try to find someone who speaks English... just

Re: [B.A.T.M.A.N.] TT inconsistency problem (again)

2011-12-06 Thread Sven Eckelmann
On Tuesday 06 December 2011 14:31:00 Marko Panger - AGB Lab wrote: Hi Antonio, Its a bit difficult to provide you a cap file as this is a tightly embedded device (console only) and I would have to build wireshark for it. tcpdump would also work. I will read through the logs later (or maybe

Re: [B.A.T.M.A.N.] TT inconsistency problem (again)

2011-12-06 Thread Sven Eckelmann
On Tuesday 06 December 2011 14:47:06 Marko Panger - AGB Lab wrote: I have to add that I had to modify the 'translation-table.c' file in order to build the version I'm using. I was facing unresolved symbols problems when loading the module due to the crc table. Thus, I added the crc table at

Re: [B.A.T.M.A.N.] TT inconsistency problem (again)

2011-12-06 Thread Sven Eckelmann
On Tuesday 06 December 2011 15:18:03 Marko Panger - AGB Lab wrote: Sven, Please don't mail me in private without a good reason. At least Cc b.a.t.m.a.n@lists.open-mesh.org for batman-adv related things. This is a very important info. Gigabyte is the provider of the HW and if this is related

[B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user

2011-12-06 Thread Sven Eckelmann
Users or build servers may want to enable preprocessor specific options like -D_FORTIFY_SOURCE=2 that are usually placed in CPPFLAGS. The batmand makefile should not override these options to add own preprocessor variables. Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile |2

Re: [B.A.T.M.A.N.] about batman performance

2011-12-07 Thread Sven Eckelmann
Hi, I tried to read your mail to find out what you did and why you did it, but I failed miserably. We wanted that you test a setup without batman-adv that uses static routes between nodes in adhoc mode. This would be help us to find out whether batman-adv is the reason for the bandwidth drop or

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Allow to disable features

2011-12-08 Thread Sven Eckelmann
On Thursday 08 December 2011 17:26:40 Marek Lindner wrote: On Wednesday, December 07, 2011 20:29:11 Sven Eckelmann wrote: -# uncomment the CONFIG_* line to enable the related feature -# features enabled in the target kernel configuration cannot be disabled +# changing the CONFIG_* line

Re: [B.A.T.M.A.N.] problem with mesh batman

2011-12-08 Thread Sven Eckelmann
On Wednesday 07 December 2011 19:24:08 Flavio Leonel suporte tecnico wrote: can you help me? I've got a problem. My pigan we do not reboot after the device connects to a LAN all interfaces are on the same bridge WLAN and LAN after restarting the device connected not ping the Access Point

[B.A.T.M.A.N.] [PATCH] batman-adv: Generate config compatible with kbuild macros

2011-12-09 Thread Sven Eckelmann
Linux 3.0-rc1-30-g2a11c8e introduced the macros IS_ENABLED, IS_BUILTIN and IS_MODULE that can be used to identify which state a tristate option had. The compat-autoconf.h needs to provide additional precompiler variables that these marcros can use. Signed-off-by: Sven Eckelmann s...@narfation.org

[B.A.T.M.A.N.] [PATCHv2 1/3] batman-adv: bat_socket_read missing checks

2011-12-10 Thread Sven Eckelmann
From: Paul Kot paw...@gmail.com Writing a icmp_packet_rr and then reading icmp_packet can lead to kernel memory corruption, if __user *buf is just below TASK_SIZE. Signed-off-by: Paul Kot paw...@gmail.com [s...@narfation.org: made it checkpatch clean] Signed-off-by: Sven Eckelmann s

[B.A.T.M.A.N.] [PATCHv3 3/3] batman-adv: Only write requested number of byte to user buffer

2011-12-10 Thread Sven Eckelmann
Don't write more than the requested number of bytes of an batman-adv icmp packet to the userspace buffer. Otherwise unrelated userspace memory might get overridden by the kernel. Signed-off-by: Sven Eckelmann s...@narfation.org --- icmp_socket.c |5 ++--- 1 files changed, 2 insertions(+), 3

[B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: Only write requested number of byte to user buffer

2011-12-10 Thread Sven Eckelmann
Don't write more than the requested number of bytes of an batman-adv icmp packet to the userspace buffer. Otherwise unrelated userspace memory might get overwritten by the kernel. Reported-by: Paul Kot paw...@gmail.com Signed-off-by: Sven Eckelmann s...@narfation.org --- Marek pointed out

[B.A.T.M.A.N.] [PATCH 1/3] batmand: Remove unmaintained *BSD port

2011-12-23 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- INSTALL|9 +- Makefile | 18 bsd/compat.c | 53 - bsd/kernel.c | 145 -- bsd/route.c| 224 bsd/tun.c

[B.A.T.M.A.N.] [PATCH 3/3] batmand: Fix open-mesh.org URLs

2011-12-23 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- CHANGELOG |2 +- INSTALL | 16 man/batmand.8 |2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 4a39e2d..9552e53 100644 --- a/CHANGELOG +++ b/CHANGELOG

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove date from README

2011-12-23 Thread Sven Eckelmann
doesn't provide any additional information when this file is only available in a release tarball or as part of a SCM repository. Signed-off-by: Sven Eckelmann s...@narfation.org --- README |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/README b/README index ddc9569

<    4   5   6   7   8   9   10   11   12   13   >