Re: [BackupPC-devel] [PATCH] Config variable subsitutions for RsyncArgs

2008-02-19 Thread Joe Krahn
Raman Gupta wrote: > Joe Krahn wrote: >>> From: Raman Gupta <[EMAIL PROTECTED]> - 2008-02-12 03:06 >>> >>> Attachments: rsync_varsub.patch I patched Rsync.pm to do variable >>> substitution for RsyncArgs. My use case for this is including an >>> --exclude-from parameter with a host-specific exclude

Re: [BackupPC-devel] [PATCH] Config variable subsitutions for RsyncArgs

2008-02-15 Thread Raman Gupta
Joe Krahn wrote: >> From: Raman Gupta <[EMAIL PROTECTED]> - 2008-02-12 03:06 >> >> Attachments: rsync_varsub.patch I patched Rsync.pm to do variable >> substitution for RsyncArgs. My use case for this is including an >> --exclude-from parameter with a host-specific exclude file, such >> as: > > In

Re: [BackupPC-devel] [PATCH] Config variable subsitutions for RsyncArgs

2008-02-15 Thread Joe Krahn
Instead of a special section to patch RsyncArgs, maybe the existing Rsync*Cmd substations could just be done in a way that handles this. A simple method would be to call &cmdVarSubstitute() twice. Another wayt would be to modify that subroutine to allow recursive substitutions, possibly with an ena

[BackupPC-devel] [PATCH] Config variable subsitutions for RsyncArgs

2008-02-11 Thread Raman Gupta
I patched Rsync.pm to do variable substitution for RsyncArgs. My use case for this is including an --exclude-from parameter with a host-specific exclude file, such as: $Conf{RsyncArgs} = [ [...], '--exclude-from=$confDir/pc/$host.exclude', ]; I also updated the config fi