Re: [Bacula-devel] Multiple fd plugins in one fileset: Restore problems

2008-09-29 Thread Kern Sibbald
Hello Bastian, I just committed a minor but important change to fd_plugins.c that I hope will fix the problem you ran into. Please try again, and if it dies, please send me another gdb traceback as you did previously. Thanks, Kern On Monday 29 September 2008 16:55:55 Bastian Friedrich wrote

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Kern Sibbald
Hello Marc, You have some interesting ideas. One thing to note is that you cannot do an fadvise() until the file is open, which you surely know, unless there is another form of fadvise, that I am not aware of. If you want to do comparisons of fadvise() and no fadvise() and apply the results

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Kern Sibbald
On Monday 29 September 2008 17:01:16 Brice Figureau wrote: > On Mon, 2008-09-29 at 10:12 -0400, Josh Fisher wrote: > > Brice Figureau wrote: > > > Hi, > > > > > > I was looking to the 2.4.2 SD spooling code lately (this was part of > > > understanding why despooling performances were not that good

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread David Boyes
> First a thing about what Brice said : I don't think there would be > something > to gain for bacula in using NOREUSE. It would be more for the other > programs > running concurrently with it, in order to help the file daemon not > trashing > the filesystem cache. It's also something that is incr

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Marc Cousin
Le Monday 29 September 2008 15:44:09 Kern Sibbald, vous avez écrit : > On Monday 29 September 2008 14:13:16 Brice Figureau wrote: > > Hi, > > > > I was looking to the 2.4.2 SD spooling code lately (this was part of > > understanding why despooling performances were not that good on my > > hardware)

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Brice Figureau
On Mon, 2008-09-29 at 10:12 -0400, Josh Fisher wrote: > Brice Figureau wrote: > > Hi, > > > > I was looking to the 2.4.2 SD spooling code lately (this was part of > > understanding why despooling performances were not that good on my > > hardware), when I noticed the following usage of posix_fadvis

Re: [Bacula-devel] Multiple fd plugins in one fileset: Restore problems

2008-09-29 Thread Bastian Friedrich
Hi, On Monday 29 September 2008, Kern Sibbald wrote: > - the code is still under important (heavy) development, and you didn't > specify what version of Bacula you are using. SVN snapshot from last friday; I am just now upgrading to a current snapshot (rev. 7662). > - Although the plugin interf

Re: [Bacula-devel] Multiple fd plugins in one fileset: Restore problems

2008-09-29 Thread Kern Sibbald
Hello, I can confirm that the bpipe-fd program and plugins work perfectly for me with two "Plugin = " line, both on backup and restore, and on restore without the plugin. This is on the code that is in the current SVN, but I didn't attempt to use your environment variable ... Best regards, K

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Josh Fisher
Brice Figureau wrote: > Hi, > > I was looking to the 2.4.2 SD spooling code lately (this was part of > understanding why despooling performances were not that good on my > hardware), when I noticed the following usage of posix_fadvise while > sequentially reading the spool file (despool_data): > >

Re: [Bacula-devel] Multiple fd plugins in one fileset: Restore problems

2008-09-29 Thread Kern Sibbald
Hello, Some comments: - the code is still under important (heavy) development, and you didn't specify what version of Bacula you are using. - Although the plugin interface has been changing, I have not incremented the version numbers, which means that if you do not build Bacula and the plugin

Re: [Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Kern Sibbald
On Monday 29 September 2008 14:13:16 Brice Figureau wrote: > Hi, > > I was looking to the 2.4.2 SD spooling code lately (this was part of > understanding why despooling performances were not that good on my > hardware), when I noticed the following usage of posix_fadvise while > sequentially readin

[Bacula-devel] Multiple fd plugins in one fileset: Restore problems

2008-09-29 Thread Bastian Friedrich
Hi, for some months bacula trunk code has provided plugins; I was (am) especially interested in the fd plugins which let me "dump" arbitrary types of data to the backup, including database dumps. Currently, only a single plugin, bpipe, is included in bacula; it is exactly what I need. When a

[Bacula-devel] Correct usage of posix_fadvise in SD?

2008-09-29 Thread Brice Figureau
Hi, I was looking to the 2.4.2 SD spooling code lately (this was part of understanding why despooling performances were not that good on my hardware), when I noticed the following usage of posix_fadvise while sequentially reading the spool file (despool_data): #if defined(HAVE_POSIX_FADVISE) && d