Re: [Bacula-devel] bugs in conio

2009-10-30 Thread Bob Hetzel
I'd like to chime in here and say that I agree that a default mode of insert rather than overwrite would be nice. Bob James Harper wrote: > Oops just noticed I left "mode_insert = 1" in. That's not part of the > fix, I just prefer insert mode. > > James > >> -Original Message- >> F

[Bacula-devel] another conio patch

2009-10-30 Thread James Harper
The following patch prevents adding of blank lines to command history in conio. I often hit enter at the console just to see if bacula has anything to tell me, and the blank lines in the history don't really do anyone any good I think. James diff --git a/bacula/src/console/conio.c b/bacula/src/co

Re: [Bacula-devel] bugs in conio

2009-10-30 Thread James Harper
I think this patch finally fixes it: diff --git a/bacula/src/console/conio.c b/bacula/src/console/conio.c index 157df55..9545235 100755 --- a/bacula/src/console/conio.c +++ b/bacula/src/console/conio.c @@ -640,7 +640,7 @@ insert_space(char *curline, int curline_len) { int i; - if (cp > cl

Re: [Bacula-devel] bugs in conio

2009-10-30 Thread James Harper
Oops just noticed I left "mode_insert = 1" in. That's not part of the fix, I just prefer insert mode. James > -Original Message- > From: James Harper > Sent: Friday, 30 October 2009 23:20 > To: James Harper; bacula-devel@lists.sourceforge.net > Subject: RE: [Bacula-devel] bugs in conio >

Re: [Bacula-devel] bugs in conio

2009-10-30 Thread James Harper
The patch below (excuse the possible formatting problems, but you get the idea) almost completely fixes the problem for me - I can't break it except for one thing. If you hit backspace, then delete, then the next character you type erases the '*' prompt. Bacula still must be looking at characters i

[Bacula-devel] bugs in conio

2009-10-30 Thread James Harper
I changed mode_insert in conio.c to 1 so that the default mode would be insert, and since then the console just doesn't seem to work right, at least for the first command you enter. Eg if I type: restore pool=aurora-disk Bacula would tell me something like "restorepool: is an invalid command.". Y