Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-04 Thread James Harper
The crash I describe below is caused by an off-by-one error in accurate.c... In accurate_cmd, a blank chksum is not included in the length passed to accurate_add_file, but in accurate_add_file, the blank chksum takes up one byte and so will trigger the overrun detection if the buffer happens to be

Re: [Bacula-devel] crash in 5.2.2

2011-12-04 Thread James Harper
> > I'm getting a consistent crash on one Windows 2008 R2 server: > > 05-Dec 12:50 bitdc1-fd: ABORTING due to ERROR in > /home/kern/bacula/k/bacula/src/lib/smartall.c:216 > Overrun buffer: len=9830441 addr=40d0068 allocated: > /home/kern/bacula/k/bacula/src/lib/htable.c:72 called from > /home/ker

[Bacula-devel] crash in 5.2.2

2011-12-04 Thread James Harper
I'm getting a consistent crash on one Windows 2008 R2 server: 05-Dec 12:50 bitdc1-fd: ABORTING due to ERROR in /home/kern/bacula/k/bacula/src/lib/smartall.c:216 Overrun buffer: len=9830441 addr=40d0068 allocated: /home/kern/bacula/k/bacula/src/lib/htable.c:72 called from /home/kern/bacula/k/bacula

Re: [Bacula-devel] PAGE_SIZE redefined

2011-12-04 Thread Kern Sibbald
On 12/03/2011 05:59 PM, Dan Langille wrote: > FYI, while compiling 5.2.2 on FreeBSD 8.2, I notice this. > > In case it's relevant, I'm posting it here. > > tree.c:39:1: warning: "PAGE_SIZE" redefined > In file included from /usr/include/sys/param.h:115, > from ../findlib/find.h:49