Re: [Bacula-devel] Patch: Update Volume Command

2008-03-05 Thread Eric Bollengier
Hello Allan, Your patch is looking good, i will commit it shortly. Thanks On Tuesday 04 March 2008 15:42:48 Allan Black wrote: > Kern Sibbald wrote: > > On Friday 29 February 2008 00.33:23 Allan Black wrote: > >> Eric Bollengier wrote: > >>> Good idea, but it would be much greater if this optio

Re: [Bacula-devel] Patch: Update Volume Command

2008-03-04 Thread Allan Black
Kern Sibbald wrote: On Friday 29 February 2008 00.33:23 Allan Black wrote: Eric Bollengier wrote: Good idea, but it would be much greater if this option was available in user interface (menu). Direct command line is always optional/obscure/undocumented. OK, I have done that, and the patch is

Re: [Bacula-devel] Patch: Update Volume Command

2008-02-29 Thread Allan Black
Kern Sibbald wrote: >> If that is OK, I am more than happy to go for it. > > Yes that is OK -- it is how I would have resolved the problem. I will work on that, then (and also take Eric's comments into account). When I resubmit the patch, I will include the changes I already sent, so you can thro

Re: [Bacula-devel] Patch: Update Volume Command

2008-02-29 Thread Eric Bollengier
> Eric Bollengier wrote: >> Good idea, but it would be much greater if this option was available in >> user interface (menu). Direct command line is always >> optional/obscure/undocumented. >> >> We can imagine something like >> >> update -> Volume -> RecyclePool >> 1. Default >> 2. Scratch >> 3. .

Re: [Bacula-devel] Patch: Update Volume Command

2008-02-29 Thread Kern Sibbald
On Friday 29 February 2008 00.33:23 Allan Black wrote: > Eric Bollengier wrote: > > Good idea, but it would be much greater if this option was available in > > user interface (menu). Direct command line is always > > optional/obscure/undocumented. > > > > We can imagine something like > > > > updat

Re: [Bacula-devel] Patch: Update Volume Command

2008-02-28 Thread Allan Black
Eric Bollengier wrote: > Good idea, but it would be much greater if this option was available in > user interface (menu). Direct command line is always > optional/obscure/undocumented. > > We can imagine something like > > update -> Volume -> RecyclePool > 1. Default > 2. Scratch > 3. ... > 4. *N

Re: [Bacula-devel] Patch: Update Volume Command

2008-02-28 Thread Eric Bollengier
Hi Allan, Good idea, but it would be much greater if this option was available in user interface (menu). Direct command line is always optional/obscure/undocumented. We can imagine something like update -> Volume -> RecyclePool 1. Default 2. Scratch 3. ... 4. *None* < Maybe by tweaking

[Bacula-devel] Patch: Update Volume Command

2008-02-27 Thread Allan Black
Hi, The RecyclePoolId field in the Media table has a default value of 0, which means the pool should be left unchanged when the volume is recycled. Currently, if RecyclePoolId is changed, there is no way to change it back to zero again using the director (it can be done by changing the database