Re: [Bacula-devel] Patches from NetBSD

2013-11-08 Thread Kern Sibbald
On 11/07/2013 06:42 PM, Joerg Sonnenberger wrote: > On Thu, Nov 07, 2013 at 06:17:09PM +0100, Kern Sibbald wrote: >> Hello, >> >> On 11/07/2013 10:30 AM, Joerg Sonnenberger wrote: >>> On Thu, Nov 07, 2013 at 08:11:09AM +0100, Kern Sibbald wrote: Can you tell me what bug the first patch fixes.

Re: [Bacula-devel] Patches from NetBSD

2013-11-07 Thread Kern Sibbald
Hello, On 11/07/2013 10:30 AM, Joerg Sonnenberger wrote: > On Thu, Nov 07, 2013 at 08:11:09AM +0100, Kern Sibbald wrote: >> Can you tell me what bug the first patch fixes. In my opinion, >> the second memcpy() changed is not necessary and harmless. >> The changed code, in my opinion, is a bad con

Re: [Bacula-devel] Patches from NetBSD

2013-11-06 Thread Kern Sibbald
Hello Dan, Can you tell me what bug the first patch fixes. In my opinion, the second memcpy() changed is not necessary and harmless. The changed code, in my opinion, is a bad construct. Is sizeof(*ctx) really properly defined when ctx is a struct. It would be *far* better to change it to sizeof

[Bacula-devel] Patches from NetBSD

2013-11-06 Thread Dan Langille
I was contacted on IRC by jo...@netbsd.org with a couple of patches which originate from NetBSD. Please address all questions to the patch writer, ccd on this post. I’ve pasted the patches and included a link to the raw patch. This patch fixes a bug: http://www.netbsd.org/~joerg/patch-src_lib_

[Bacula-devel] Patches to make --disable-libtool work again

2011-11-09 Thread Martin Simmons
Hi, The --disable-libtool configure option is broken in 5.2.1 and the attached patches address the issues (on FreeBSD 8 at least). bacula-5.2.1-bscan-dblibs.patch defines DB_LIBS (this is an independent bug). bacula-5.2.1-tools-lib-order.patch puts the libraries in the correct order for linking

Re: [Bacula-devel] Patches for VirtualCopy

2009-07-13 Thread Kern Sibbald
Hello, After looking over your VituralCopy code and thinking about this, I am convinced that we are going in the right direction, but possibly if we change some of the details, it will be slightly more logical for users. Our current situation is: Type=Backup Level=VirtualFull pr

Re: [Bacula-devel] Patches for FreeBSD

2009-04-11 Thread Kern Sibbald
On Sunday 12 April 2009 02:59:35 Dan Langille wrote: > Folks: > > To get Bacula 2.5.42-b2 to run on FreeBSD 7.x and 8.x, the following > patches are required. This is because a newer gcc is used on those > platforms. > > FYI: > > FreeBSD 6.3 - gcc 3.4.6 > FreeBSD 7.1 - gcc 4.2.1 > FreeBSD 8.x - gc

[Bacula-devel] Patches for FreeBSD

2009-04-11 Thread Dan Langille
Folks: To get Bacula 2.5.42-b2 to run on FreeBSD 7.x and 8.x, the following patches are required. This is because a newer gcc is used on those platforms. FYI: FreeBSD 6.3 - gcc 3.4.6 FreeBSD 7.1 - gcc 4.2.1 FreeBSD 8.x - gcc 4.2.1 (20070719) The patches relate to casting. These patches will b

Re: [Bacula-devel] patches for newer gcc

2009-01-11 Thread Kern Sibbald
On Sunday 11 January 2009 18:07:23 Dan Langille wrote: > Eric Bollengier wrote: > > Le Saturday 10 January 2009 01:02:10 Dan Langille, vous avez écrit : > >> Eric Bollengier wrote: > >>> Hello Dan, > >>> > >>> The "pthread" type is not defined on linux... (i have a pthread_t > >>> instead) And on l

Re: [Bacula-devel] patches for newer gcc

2009-01-11 Thread Eric Bollengier
Le Sunday 11 January 2009 18:07:23 Dan Langille, vous avez écrit : > Eric Bollengier wrote: > > Le Saturday 10 January 2009 01:02:10 Dan Langille, vous avez écrit : > >> Eric Bollengier wrote: > >>> Hello Dan, > >>> > >>> The "pthread" type is not defined on linux... (i have a pthread_t > >>> inste

Re: [Bacula-devel] patches for newer gcc

2009-01-11 Thread Dan Langille
Eric Bollengier wrote: > Le Saturday 10 January 2009 01:02:10 Dan Langille, vous avez écrit : >> Eric Bollengier wrote: >>> Hello Dan, >>> >>> The "pthread" type is not defined on linux... (i have a pthread_t >>> instead) And on linux, pthread_t is an integer, which seems to different >>> on freebs

Re: [Bacula-devel] patches for newer gcc

2009-01-10 Thread Eric Bollengier
Le Saturday 10 January 2009 01:02:10 Dan Langille, vous avez écrit : > Eric Bollengier wrote: > > Hello Dan, > > > > The "pthread" type is not defined on linux... (i have a pthread_t > > instead) And on linux, pthread_t is an integer, which seems to different > > on freebsd. > > > > Maybe i can use

Re: [Bacula-devel] patches for newer gcc

2009-01-09 Thread Dan Langille
Eric Bollengier wrote: > Hello Dan, > > The "pthread" type is not defined on linux... (i have a pthread_t instead) > And on linux, pthread_t is an integer, which seems to different on freebsd. > > Maybe i can use a void * cast at this place ? In addition to the casting issues, I've been unable t

Re: [Bacula-devel] patches for newer gcc

2009-01-09 Thread Dan Langille
Eric Bollengier wrote: > Hello Dan, > > The "pthread" type is not defined on linux... (i have a pthread_t instead) > And on linux, pthread_t is an integer, which seems to different on freebsd. > > Maybe i can use a void * cast at this place ? or an #ifdef based on the OS? > > Bye > > Le Frida

Re: [Bacula-devel] patches for newer gcc

2009-01-09 Thread Eric Bollengier
Hello Dan, The "pthread" type is not defined on linux... (i have a pthread_t instead) And on linux, pthread_t is an integer, which seems to different on freebsd. Maybe i can use a void * cast at this place ? Bye Le Friday 09 January 2009 19:42:18 Dan Langille, vous avez écrit : > Hi, > > In Fre

[Bacula-devel] patches for newer gcc

2009-01-09 Thread Dan Langille
Hi, In FreeBSD 7.x, we have a newer gcc, which is being extra picky about precision when casting. One of the FreeBSD porters has done some work in this area. His patches are here (and I have pasted them to the end of this message): http://www.atarininja.org/patches/bacula-server-devel.dif

Re: [Bacula-devel] Patches

2008-10-27 Thread Kern Sibbald
On Monday 27 October 2008 21:48:18 David Boyes wrote: > > > > free, > > > > no problem, but i prefere spend my time with new features and bugs > > > > hunting. > > > > > > 2nd option is to package the source diffs into RPM and APT, and > > provide > > > > those via a repository. Applying a diff is

Re: [Bacula-devel] Patches

2008-10-27 Thread David Boyes
> > > free, > > > no problem, but i prefere spend my time with new features and bugs > > > hunting. > > > > 2nd option is to package the source diffs into RPM and APT, and provide > > those via a repository. Applying a diff is a fairly simple operation, > > and people who care about most recent bin

Re: [Bacula-devel] Patches

2008-10-27 Thread Kern Sibbald
Thanks for the tips. We'll certainly consider all these ideas. Regards, Kern On Monday 27 October 2008 15:25:34 David Boyes wrote: > ne thing i am missing are patched packages, rpm and also deb packages > > > > have a mechanism to include patch files an apply during build > > process. > > > > F

Re: [Bacula-devel] Patches

2008-10-27 Thread David Boyes
ne thing i am missing are patched packages, rpm and also deb packages > > have a mechanism to include patch files an apply during build process. > > > > For most bacula users it would be much easier to apply patches by "rpm > > -U ..." or "dpkg install ...". > > Yes, but you have to build, test an

Re: [Bacula-devel] Patches

2008-10-26 Thread Yuri Timofeev
See http://www.bacula.org/en/rel-manual/Bacula_RPM_Packaging_FAQ.html and trunk/bacula/platforms/contrib-rpm directory But the answer to your question, I did not find it. I think (perhaps wrongly) that the way may be next. Download bacula-2.4.3-1.src.rpm and install. Download patch 2.4.3-cancel-

Re: [Bacula-devel] Patches

2008-10-26 Thread Kern Sibbald
On Saturday 25 October 2008 23:31:54 Yuri Timofeev wrote: > I think that bacula-announce will be enough. Yes, that seems like a reasonable compromise ... :-) > > 2008/10/25 Kern Sibbald <[EMAIL PROTECTED]>: > > 1. Change nothing (signing up for bugs and patch notification is already > > not bad).

Re: [Bacula-devel] Patches

2008-10-26 Thread Kern Sibbald
On Sunday 26 October 2008 12:38:22 Timo Neuvonen wrote: > "Kern Sibbald" <[EMAIL PROTECTED]> kirjoitti viestissä > news:[EMAIL PROTECTED] > > > On Saturday 25 October 2008 21:53:00 Ulrich Leodolter wrote: > >> On Sat, 2008-10-25 at 21:11 +0200, Eric Bollengier wrote: > >> > Le Saturday 25 October 2

Re: [Bacula-devel] Patches

2008-10-26 Thread Timo Neuvonen
"Kern Sibbald" <[EMAIL PROTECTED]> kirjoitti viestissä news:[EMAIL PROTECTED] > On Saturday 25 October 2008 21:53:00 Ulrich Leodolter wrote: >> On Sat, 2008-10-25 at 21:11 +0200, Eric Bollengier wrote: >> > Le Saturday 25 October 2008 13:41:15 Ulrich Leodolter, vous avez écrit >> > : >> > > On Sa

Re: [Bacula-devel] Patches

2008-10-26 Thread Kern Sibbald
On Saturday 25 October 2008 21:53:00 Ulrich Leodolter wrote: > On Sat, 2008-10-25 at 21:11 +0200, Eric Bollengier wrote: > > Le Saturday 25 October 2008 13:41:15 Ulrich Leodolter, vous avez écrit : > > > On Sat, 2008-10-25 at 11:32 +0200, Kern Sibbald wrote: > > > > Hello, > > > > > > > > For some

Re: [Bacula-devel] Patches

2008-10-25 Thread Yuri Timofeev
I think that bacula-announce will be enough. 2008/10/25 Kern Sibbald <[EMAIL PROTECTED]>: > > > 1. Change nothing (signing up for bugs and patch notification is already not >bad). > 2. Announce patches to the bacula-devel list > 3. Announce patches to the bacula-devel list and the bacula-use

Re: [Bacula-devel] Patches

2008-10-25 Thread Arno Lehmann
Hi, this is a summary reply to distinct parts of this discussion... I hope it doesn't get too confusing, but as I'm not a developer I believe you won't find it necessary to reply to most of my thoughts. 25.10.2008 21:53, Ulrich Leodolter wrote: > On Sat, 2008-10-25 at 21:11 +0200, Eric Bollengi

Re: [Bacula-devel] Patches

2008-10-25 Thread Ulrich Leodolter
On Sat, 2008-10-25 at 21:11 +0200, Eric Bollengier wrote: > Le Saturday 25 October 2008 13:41:15 Ulrich Leodolter, vous avez écrit : > > On Sat, 2008-10-25 at 11:32 +0200, Kern Sibbald wrote: > > > Hello, > > > > > > For some time now, I haven't really been happy with the Bacula patch > > > proced

Re: [Bacula-devel] Patches

2008-10-25 Thread Eric Bollengier
Le Saturday 25 October 2008 13:41:15 Ulrich Leodolter, vous avez écrit : > On Sat, 2008-10-25 at 11:32 +0200, Kern Sibbald wrote: > > Hello, > > > > For some time now, I haven't really been happy with the Bacula patch > > procedure. Basically, when we fix a bug (either from a bug report or > > ours

Re: [Bacula-devel] Patches

2008-10-25 Thread Yuri Timofeev
2008/10/25 Ulrich Leodolter <[EMAIL PROTECTED]>: > > > One thing i am missing are patched packages, rpm and also deb packages > have a mechanism to include patch files an apply during build process. > > For most bacula users it would be much easier to apply patches by "rpm > -U ..." or "dpkg instal

Re: [Bacula-devel] Patches

2008-10-25 Thread Ulrich Leodolter
On Sat, 2008-10-25 at 11:32 +0200, Kern Sibbald wrote: > Hello, > > For some time now, I haven't really been happy with the Bacula patch > procedure. Basically, when we fix a bug (either from a bug report or > ourselves), we usually generate a patch, post it to the bug report, if any, > and up

[Bacula-devel] Patches

2008-10-25 Thread Kern Sibbald
Hello, For some time now, I haven't really been happy with the Bacula patch procedure. Basically, when we fix a bug (either from a bug report or ourselves), we usually generate a patch, post it to the bug report, if any, and upload it to the Bacula patches area of Source Forge. Providing you a