Re: [Bacula-devel] Patches from NetBSD

2013-11-08 Thread Kern Sibbald
On 11/07/2013 06:42 PM, Joerg Sonnenberger wrote: > On Thu, Nov 07, 2013 at 06:17:09PM +0100, Kern Sibbald wrote: >> Hello, >> >> On 11/07/2013 10:30 AM, Joerg Sonnenberger wrote: >>> On Thu, Nov 07, 2013 at 08:11:09AM +0100, Kern Sibbald wrote: Can you tell me what bug the first patch fixes.

Re: [Bacula-devel] Patches from NetBSD

2013-11-07 Thread Kern Sibbald
Hello, On 11/07/2013 10:30 AM, Joerg Sonnenberger wrote: > On Thu, Nov 07, 2013 at 08:11:09AM +0100, Kern Sibbald wrote: >> Can you tell me what bug the first patch fixes. In my opinion, >> the second memcpy() changed is not necessary and harmless. >> The changed code, in my opinion, is a bad con

Re: [Bacula-devel] Patches from NetBSD

2013-11-06 Thread Kern Sibbald
Hello Dan, Can you tell me what bug the first patch fixes. In my opinion, the second memcpy() changed is not necessary and harmless. The changed code, in my opinion, is a bad construct. Is sizeof(*ctx) really properly defined when ctx is a struct. It would be *far* better to change it to sizeof

[Bacula-devel] Patches from NetBSD

2013-11-06 Thread Dan Langille
I was contacted on IRC by jo...@netbsd.org with a couple of patches which originate from NetBSD. Please address all questions to the patch writer, ccd on this post. I’ve pasted the patches and included a link to the raw patch. This patch fixes a bug: http://www.netbsd.org/~joerg/patch-src_lib_