On Sunday 29 November 2009 12:00:36 SF Markus Elfring wrote:
> > However, I am not very interested in being pedantic and "correcting"
> > things that are not impacting us or creating more work for the
> > developers.
>
> Would you like to give me an indication that a source code clean-up for
> safe
> However, I am not very interested in being pedantic and "correcting" things
> that are not impacting us or creating more work for the developers.
Would you like to give me an indication that a source code clean-up for safer
names will be an acceptable contribution for software refactoring?
Re
On Sunday 29 November 2009 08:57:36 SF Markus Elfring wrote:
> > > I suggest to change some identifiers that begin with two underscores or
> > > an underscore and an uppercase letter. - How do you think about to use
> > > the prefix "BACULA_" (instead of "_B") consistently?
> >
> > No, it is too cl
> > I suggest to change some identifiers that begin with two underscores or an
> > underscore and an uppercase letter. - How do you think about to use the
> > prefix "BACULA_" (instead of "_B") consistently?
>
> No, it is too clumbsy in my opinion.
I prefer the correct application of the C namin
> Generally, for a header file such as xx.h
> __XX_H_
> or more simply
> _XX_H_
I find this naming pattern not acceptable if it is not used for a (C) compiler
implementation. Your usage of the reserved namespace should be reconsidered.
Regards,
Markus
---
On Monday 16 November 2009 23:25:03 SF Markus Elfring wrote:
> > > Which naming patterns are acceptable to fix the involved details?
> >
> > That is a question that I don't have the time to answer without spending
> > hours looking at the code.
>
> I propose to try the search pattern "\<_(?:(?:_(.*
On Monday 16 November 2009 20:00:30 SF Markus Elfring wrote:
> Hello,
>
> I pointed out that some identifiers in the source files do not fit to the
> expected naming conventions of the C language standard because they tamper
> with the reserved namespace. http://bugs.bacula.org/view.php?id=1406
>
>
> > Which naming patterns are acceptable to fix the involved details?
>
> That is a question that I don't have the time to answer without spending
> hours
> looking at the code.
I propose to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on the source
files.
> If you have an specific pro
On Monday 16 November 2009 20:00:30 SF Markus Elfring wrote:
> Hello,
>
> I pointed out that some identifiers in the source files do not fit to the
> expected naming conventions of the C language standard because they tamper
> with the reserved namespace. http://bugs.bacula.org/view.php?id=1406
>
>
Hello,
I pointed out that some identifiers in the source files do not fit to the
expected naming conventions of the C language standard because they tamper with
the reserved namespace.
http://bugs.bacula.org/view.php?id=1406
Which naming patterns are acceptable to fix the involved details?
Reg
10 matches
Mail list logo
