Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-16 Thread Nicolae Mihalache
Thanks a lot, I will switch to version 3.0.3 as soon as it is out. In the meanwhile I was running with the my modification and so far didn't have any trouble (but I'm not using bextract). nicolae Kern Sibbald wrote: > Hello, > > On Monday 12 October 2009 04:09:16 Nicolae Mihalache wrote: > >> I

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-16 Thread Kern Sibbald
Hello, On Monday 12 October 2009 04:09:16 Nicolae Mihalache wrote: > I tried your change but VirtualFull with multiple read devices is not > working. Restore is working but it was working even without your change. Yes, I hadn't noticed one small important detail in your code :-( so my code didn'

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-11 Thread Nicolae Mihalache
I tried your change but VirtualFull with multiple read devices is not working. Restore is working but it was working even without your change. I think I know why: 1. the code from reserve.c:637 dcr = new_dcr(rctx.jcr, rctx.jcr->dcr, rctx.device->dev); always changes the write device, never the

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-11 Thread Kern Sibbald
On Sunday 11 October 2009 18:32:12 Nicolae Mihalache wrote: > Hello, I can only test tomorrow because now I have some long running > backups. OK, no problem. > > But isn't your change affecting the jcr->dcr which is the writing device? I think that is the point. jcr->dcr (should really be named

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-11 Thread Nicolae Mihalache
Hello, I can only test tomorrow because now I have some long running backups. But isn't your change affecting the jcr->dcr which is the writing device? Have you tried running a virtual full or just a restore? I guess for a restore it is working because no writing device is being used. nicolae

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-11 Thread Kern Sibbald
Hello, This is to let you know that I have tested my variation of your proposed fix for changing read devices during VirtualFull, and it seems to work fine here in our tests, so I have committed it. Just the same, I would appreciate it if you could confirm that my suggestion really does fix yo

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-11 Thread Kern Sibbald
Hello, That is *very* interesting. Thanks for looking into this. I think the code has previously worked for us because we may not have explicitly tested Migration and VirtualFull, but for restores it all works fine. Could you try one change to your fix? Remove your fix, then change line res

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-11 Thread Nicolae Mihalache
I investigated a little more and found that if I replace the line rctx.jcr->dcr = dcr = new_dcr(rctx.jcr, rctx.jcr->dcr, rctx.device->dev); with if (rctx.store->append == SD_READ) { rctx.jcr->read_dcr = dcr = new_dcr(rctx.jcr, rctx.jcr->read_dcr, rctx.device->dev); } else {

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-09 Thread Nicolae Mihalache
Kern Sibbald wrote: > > If indeed the code in reserve.c is setting an entirely new dcr pointer, then > it is unlikely the code will work. So that may be the problem you are > running into. However, in all our tests, it does seem to work providing you > have different MediaTypes for each device

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-09 Thread Kern Sibbald
On Friday 09 October 2009 15:06:36 Nicolae Mihalache wrote: > Sorry, I'm not quite sure I grasp your message. > When you refer to Storage in "Changing Storage for restore and > migration", you talk about Storage Daemon or the Storage resource in the > director? I was not very precise. I meant tha

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-09 Thread Nicolae Mihalache
Sorry, I'm not quite sure I grasp your message. When you refer to Storage in "Changing Storage for restore and migration", you talk about Storage Daemon or the Storage resource in the director? I have one Storage Daemon with three different devices and three corresponding storage resources in the

Re: [Bacula-users] [Bacula-devel] VirtualFull backup: bacula selects the wrong read device

2009-10-09 Thread Kern Sibbald
Hello, You are attempting to use a feature that is not implemented. Changing Storage for restore and migration is not implemented in any released version of Bacula. Changing of Storage for restore is implemented in 3.1.x (not yet released). However, it is unlikely that it works for migration.