Re: [PATCH v2] mmuinfo: add a command do display the result of virtual to physical translation

2012-06-25 Thread Sascha Hauer
On Fri, Jun 22, 2012 at 11:02:05AM +0200, Jan Luebbe wrote: > Signed-off-by: Jan Luebbe > --- > arch/arm/Kconfig | 10 - > arch/arm/cpu/Makefile |1 + > arch/arm/cpu/mmuinfo.c | 111 > > 3 files changed, 121 insertions(+), 1 dele

Re: [PATCH 2/3] i.MX clko: Added support for more than one CLKO outputs

2012-06-25 Thread Sascha Hauer
Hi Alexander, This patch introduces several build warnings and also has a problem with error checking. Could you update it? Thanks Sascha On Thu, Jun 07, 2012 at 05:00:50PM +0400, Alexander Shiyan wrote: > > --- > if (div != 0) { > - ret = imx_clko_set_div(div); > +

Re: [PATCH 2/2] rzx50: add poweroff support

2012-06-25 Thread Sascha Hauer
Hi Antony, This patch introduces some new build warnings in rx50_defconfig. Could you fix these? arch/mips/mach-xburst/reset-jz4750.c: In function 'poweroff': arch/mips/mach-xburst/reset-jz4750.c:68: warning: passing argument 1 of '__raw_readl' makes pointer from integer without a cast arch/mip

Re: [PATCH 2/2] rzx50: add poweroff support

2012-06-25 Thread Antony Pavlov
Ok, I'll fix it in a few hours. On 25 June 2012 11:32, Sascha Hauer wrote: > Hi Antony, > > This patch introduces some new build warnings in rx50_defconfig. Could you > fix these? > > arch/mips/mach-xburst/reset-jz4750.c: In function 'poweroff': > arch/mips/mach-xburst/reset-jz4750.c:68: warning

[PATCH] x86 linux16 command: Add missing include

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- commands/linux16.c |1 + 1 file changed, 1 insertion(+) diff --git a/commands/linux16.c b/commands/linux16.c index eccafa8..5ed3a8b 100644 --- a/commands/linux16.c +++ b/commands/linux16.c @@ -30,6 +30,7 @@ #include #include #include +#include #include

SPI chip select problem

2012-06-25 Thread Antony Pavlov
Hi! I have added spi controller driver for one of my MIPS boards and found, that there is a problem with chip select. During initialisation we call *_spi_setup() method. It switch chip select and frequency for every probing spi slave chip. But after initialisation __we never__ call this method. S

Re: SPI chip select problem

2012-06-25 Thread Johannes Stezenbach
Hi, On Mon, Jun 25, 2012 at 11:45:06AM +0400, Antony Pavlov wrote: > I have added spi controller driver for one of my MIPS boards and > found, that there is a problem with chip select. > > During initialisation we call *_spi_setup() method. It switch chip > select and frequency for every probing

[PATCH] i.MX clko: Checking for clko-line properly

2012-06-25 Thread Alexander Shiyan
This patch adds a check for the correct number of CLKO-line. Signed-off-by: Alexander Shiyan --- arch/arm/mach-imx/clko.c|6 -- arch/arm/mach-imx/speed-imx21.c |3 ++- arch/arm/mach-imx/speed-imx25.c |3 ++- arch/arm/mach-imx/speed-imx27.c |3 ++- arch/arm/mach-imx/sp

Re: SPI chip select problem

2012-06-25 Thread Antony Pavlov
On 25 June 2012 12:53, Johannes Stezenbach wrote: > Hi, > > On Mon, Jun 25, 2012 at 11:45:06AM +0400, Antony Pavlov wrote: >> I have added spi controller driver for one of my MIPS boards and >> found, that there is a problem with chip select. >> >> During initialisation we call *_spi_setup() metho

Re: SPI chip select problem

2012-06-25 Thread Johannes Stezenbach
On Mon, Jun 25, 2012 at 02:07:34PM +0400, Antony Pavlov wrote: > On 25 June 2012 12:53, Johannes Stezenbach wrote: > > On Mon, Jun 25, 2012 at 11:45:06AM +0400, Antony Pavlov wrote: > >> > >> There is the 'cs_change' flag for *_spi_transfer() method, but this > >> flag does not used at all! > > >

[PATCH] MIPS: XBurst: fix compiler warnings in reset-jz4750.c

2012-06-25 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- arch/mips/mach-xburst/reset-jz4750.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/mach-xburst/reset-jz4750.c b/arch/mips/mach-xburst/reset-jz4750.c index 4bda56c..765c033 100644 --- a/arch/mips/mach-xburst/reset-jz4750.c

[PATCH] Makefile: echo size check error to stderr

2012-06-25 Thread Sascha Hauer
To be able to see it when in my build tests stdout goes to /dev/null Signed-off-by: Sascha Hauer --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9294049..ff56591 100644 --- a/Makefile +++ b/Makefile @@ -540,7 +540,7 @@ quiet_cmd_check

[PATCH] fs/devfs.c: disallow write and erase if a partition is read-only

2012-06-25 Thread Jan Luebbe
Signed-off-by: Jan Luebbe --- fs/devfs.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/devfs.c b/fs/devfs.c index ae48451..074bb34 100644 --- a/fs/devfs.c +++ b/fs/devfs.c @@ -49,6 +49,9 @@ static int devfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t s {

[PATCH] ARM i.MX51 babbage: add mci1

2012-06-25 Thread Sascha Hauer
The iomuxer is already initialized, only need to add the device. Signed-off-by: Sascha Hauer --- arch/arm/boards/freescale-mx51-pdk/board.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boards/freescale-mx51-pdk/board.c b/arch/arm/boards/freescale-mx51-pdk/board.c index 0bb2ff

[PATCH] defaultenv/bin/init: skip autoboot if $autoboot_timeout is unset

2012-06-25 Thread Jan Luebbe
Signed-off-by: Jan Luebbe --- defaultenv/bin/init |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaultenv/bin/init b/defaultenv/bin/init index 6e85a82..f535e37 100644 --- a/defaultenv/bin/init +++ b/defaultenv/bin/init @@ -23,7 +23,7 @@ fi if [ -f /env/bin/boot_board

[PATCH] sandbox: fix 64bit build

2012-06-25 Thread Sascha Hauer
On x86_64 we need CONFIG_PHYS_ADDR_T_64BIT to make the resource sizes 64bit. The kernel has this as a Kconfig variable, but on barebox sandbox will build with whatever compiler we find, so we can't put it into Kconfig. Signed-off-by: Sascha Hauer --- arch/sandbox/include/asm/types.h |7 +

Re: [PATCH] MIPS: XBurst: fix compiler warnings in reset-jz4750.c

2012-06-25 Thread Sascha Hauer
On Mon, Jun 25, 2012 at 02:58:11PM +0400, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov Squashed into the original commit causing the warnings. Thanks Sascha > --- > arch/mips/mach-xburst/reset-jz4750.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/a

Re: [PATCH] i.MX clko: Checking for clko-line properly

2012-06-25 Thread Sascha Hauer
On Mon, Jun 25, 2012 at 12:54:58PM +0400, Alexander Shiyan wrote: > This patch adds a check for the correct number of CLKO-line. Squashed into the original commit causing the failure Thanks Sascha > > Signed-off-by: Alexander Shiyan > --- > arch/arm/mach-imx/clko.c|6 -- > ar

Re: [PATCH 1/2] Add a simple watchdog framework

2012-06-25 Thread Sascha Hauer
On Fri, Jun 22, 2012 at 11:54:02AM +0200, Juergen Beisert wrote: > This patch adds a simple wd command which can setup, trigger and stop a > watchdog > on the platform. > > +static int do_wd(int argc, char *argv[]) > +{ > + int rc; > + > + if (argc > 1) { > + if (isdigit(*argv

[PATCH 2/5] openrisc: link to libgcc

2012-06-25 Thread Sascha Hauer
To get symbols like __ashrdi3. Franck started generating these symbols from gcc assembly, which seems to be the cleaner approach. The simpler approach for now to get additional symbols is to link in libgcc, which is the same as the kernel does. Signed-off-by: Sascha Hauer Cc: Franck Jullien ---

[PATCH 5/5] x86: Add missing ffs include

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/x86/include/asm/bitops.h |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h index b43afa3..685c15f 100644 --- a/arch/x86/include/asm/bitops.h +++ b/arch/x86/include/asm/bitop

[PATCH 3/5] mips: Add missing ffs include

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/mips/include/asm/bitops.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/include/asm/bitops.h b/arch/mips/include/asm/bitops.h index 001ebf2..16deb8c 100644 --- a/arch/mips/include/asm/bitops.h +++ b/arch/mips/include/asm/bitops.h @@ -28,5 +2

[PATCH 1/5] blackfin: add __ashrdi3

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/blackfin/lib/Makefile |1 + arch/blackfin/lib/ashrdi3.c | 36 2 files changed, 37 insertions(+) create mode 100644 arch/blackfin/lib/ashrdi3.c diff --git a/arch/blackfin/lib/Makefile b/arch/blackfin/lib/Makefile in

[PATCH 4/5] nios2: Add missing ffs include

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/nios2/include/asm/bitops.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/nios2/include/asm/bitops.h b/arch/nios2/include/asm/bitops.h index ab0e3d5..87bfaa1 100644 --- a/arch/nios2/include/asm/bitops.h +++ b/arch/nios2/include/asm/bitops.h @@

[PATCH] provide ffs and __ashrdi3 for all architectures

2012-06-25 Thread Sascha Hauer
For upcoming 64bit file support we need ffs and __ashrdi3 functions for all architectures. These patches provide them. Sascha Sascha Hauer (5): blackfin: add __ashrdi3 openrisc: link to libgcc mips: Add missing ffs

Re: [PATCH 1/2] Add a simple watchdog framework

2012-06-25 Thread Juergen Beisert
Sascha Hauer wrote: > On Fri, Jun 22, 2012 at 11:54:02AM +0200, Juergen Beisert wrote: > > This patch adds a simple wd command which can setup, trigger and stop a > > watchdog on the platform. > > > > +static int do_wd(int argc, char *argv[]) > > +{ > > + int rc; > > + > > + if (argc > 1) { > >

[PATCH] print out resource_size_t correctly

2012-06-25 Thread Sascha Hauer
resource_size_t can be 32bit or 64bit depending on the architecture. Add a define for it to be able to printf a resource_size_t correctly Signed-off-by: Sascha Hauer --- commands/iomem.c |3 ++- drivers/base/driver.c |3 ++- include/linux/ioport.h |6 ++ 3 files changed, 1

Re: [PATCH 1/2] Add a simple watchdog framework

2012-06-25 Thread Sascha Hauer
On Mon, Jun 25, 2012 at 02:45:43PM +0200, Juergen Beisert wrote: > Sascha Hauer wrote: > > On Fri, Jun 22, 2012 at 11:54:02AM +0200, Juergen Beisert wrote: > > > This patch adds a simple wd command which can setup, trigger and stop a > > > watchdog on the platform. > > > > > > +static int do_wd(int

Re: [PATCH 2/5] openrisc: link to libgcc

2012-06-25 Thread Sascha Hauer
Hi Franck, Do you think this patch is ok? It was the easiest way for me to get __ashrdi3. I don't know how exactly you generated the other library functions. On Mon, Jun 25, 2012 at 02:44:38PM +0200, Sascha Hauer wrote: > To get symbols like __ashrdi3. > > Franck started generating these symbols

Re: [PATCH 1/2] Add a simple watchdog framework

2012-06-25 Thread Juergen Beisert
Hi Sascha, Sascha Hauer wrote: > [...] > > > > + > > > > + rc = watchdog_set_timeout(timeout); > > > > + if (rc == -EINVAL) { > > > > > > Why do you check for -EINVAL only? This way all other errors will be > > > silently ignored. > > > > Are you sure we must handle other failure codes

[PATCH] drivers/video: support three ways to select default video mode

2012-06-25 Thread Jan Luebbe
Currently the first entry in the board's mode list is the default. In cases where the connected panel is not fixed, it is better to configure it at runtime via the fb0.mode_name variable. This patch allows choosing between: - First mode in the board's list (old behavior) - No default mode - Def

[PATCH] drivers/nor/m25p80.c: fix erase loop for unaligned addresses

2012-06-25 Thread Jan Luebbe
In some cases with unaligned addresses the loop would not abort. Instead, use the calculated sector numbers in a for-loop. Based on a patch by Sascha Hauer . Signed-off-by: Jan Luebbe --- drivers/nor/m25p80.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/dri

[PATCH v2] drivers/net: add designware driver

2012-06-25 Thread Johannes Stezenbach
Straight forward port of Synopsys Designware ethernet driver from u-boot v2012.04.01. Signed-off-by: Johannes Stezenbach --- drivers/net/Kconfig | 16 ++ drivers/net/Makefile |1 + drivers/net/designware.c | 436 ++ drivers/net/designwa

Re: [PATCH] ARM i.MX51 babbage: add mci1

2012-06-25 Thread Robert Schwebel
On Mon, Jun 25, 2012 at 02:05:37PM +0200, Sascha Hauer wrote: > The iomuxer is already initialized, only need to add the device. > > Signed-off-by: Sascha Hauer > --- > arch/arm/boards/freescale-mx51-pdk/board.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boards/freesca

Re: [PATCH] defaultenv/bin/init: skip autoboot if $autoboot_timeout is unset

2012-06-25 Thread Sascha Hauer
On Mon, Jun 25, 2012 at 02:06:00PM +0200, Jan Luebbe wrote: > Signed-off-by: Jan Luebbe Applied, thanks Sascha > --- > defaultenv/bin/init |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/defaultenv/bin/init b/defaultenv/bin/init > index 6e85a82..f535e37 100644 > --

Re: [PATCH] fs/devfs.c: disallow write and erase if a partition is read-only

2012-06-25 Thread Sascha Hauer
On Mon, Jun 25, 2012 at 02:03:27PM +0200, Jan Luebbe wrote: > Signed-off-by: Jan Luebbe Applied, thanks. Sascha > --- > fs/devfs.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/devfs.c b/fs/devfs.c > index ae48451..074bb34 100644 > --- a/fs/devfs.c > +++ b/fs/devfs.c >

Re: [PATCH] ARM i.MX51 babbage: add mci1

2012-06-25 Thread Sascha Hauer
On Mon, Jun 25, 2012 at 06:39:30PM +0200, Robert Schwebel wrote: > On Mon, Jun 25, 2012 at 02:05:37PM +0200, Sascha Hauer wrote: > > The iomuxer is already initialized, only need to add the device. > > > > Signed-off-by: Sascha Hauer > > --- > > arch/arm/boards/freescale-mx51-pdk/board.c |1

[PATCH] remove dead rarpboot command

2012-06-25 Thread Sascha Hauer
This code is unused, remove it. Signed-off-by: Sascha Hauer --- commands/net.c | 29 - 1 file changed, 29 deletions(-) diff --git a/commands/net.c b/commands/net.c index c5c6373..665433f 100644 --- a/commands/net.c +++ b/commands/net.c @@ -35,35 +35,6 @@ #include

[PATCH] sparse fixes

2012-06-25 Thread Sascha Hauer
This series fixes a bunch of sparse warnings. Don't worry, there are still some left in the tree ;) Sascha Sascha Hauer (12): MMC i.MX esdhc: Fix sparse warnings tlsf: Use NULL instead of 0 for returning NULL pointers

[PATCH 03/12] qsort: declare strcmp_compar publically

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- include/qsort.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qsort.h b/include/qsort.h index bbb2359..d279dc2 100644 --- a/include/qsort.h +++ b/include/qsort.h @@ -4,4 +4,6 @@ void qsort(void *base, size_t nel, size_t width, int (*

[PATCH 04/12] Do not use iomem space for dev_get_mem_region

2012-06-25 Thread Sascha Hauer
It is mostly used for mmapping sdram which is no iomem. Signed-off-by: Sascha Hauer --- drivers/base/driver.c |6 +++--- include/driver.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/driver.c b/drivers/base/driver.c index 547d684..cb876fa 100644

[PATCH 08/12] net smc911x: Use __iomem for register base

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/net/smc911x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 800c188..7dddbbc 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -691,7 +691,7 @@ static int smc911x_p

[PATCH 09/12] ARM i.MX clocksource: put registers in iomem space

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/arm/mach-imx/clocksource.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-imx/clocksource.c b/arch/arm/mach-imx/clocksource.c index 4f5895c..4e77ece 100644 --- a/arch/arm/mach-imx/clocksource.c +++ b/arch/arm/m

[PATCH 01/12] MMC i.MX esdhc: Fix sparse warnings

2012-06-25 Thread Sascha Hauer
mostly by moving the registers into the correct address space. Signed-off-by: Sascha Hauer --- drivers/mci/imx-esdhc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c index ae3c805..585cab9 100644 ---

[PATCH 06/12] ARM i.MX speed: sparse fixes

2012-06-25 Thread Sascha Hauer
- Add missing #include - add global functions to mach/clock.h Signed-off-by: Sascha Hauer --- arch/arm/mach-imx/include/mach/clock.h |2 ++ arch/arm/mach-imx/speed-imx35.c|2 +- arch/arm/mach-imx/speed-imx51.c|5 +++-- arch/arm/mach-imx/speed-imx53.c|3 ++

[PATCH 02/12] tlsf: Use NULL instead of 0 for returning NULL pointers

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- common/tlsf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/tlsf.c b/common/tlsf.c index c810e8d..9515ac7 100644 --- a/common/tlsf.c +++ b/common/tlsf.c @@ -367,7 +367,7 @@ static block_header_t* search_suitable_block(poo

[PATCH 10/12] USB gadget fsl: Put registers into iomem space

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/gadget/fsl_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/fsl_udc.c b/drivers/usb/gadget/fsl_udc.c index 5b64ec2..9681812 100644 --- a/drivers/usb/gadget/fsl_udc.c +++ b/drivers/usb/gadget/fsl_udc.c @@ -5

[PATCH 07/12] USB ohci: Fix sparse warnings

2012-06-25 Thread Sascha Hauer
- put registers into iomem space - do not use 0 as NULL pointer - use dev_request_mem_region() Signed-off-by: Sascha Hauer --- drivers/usb/host/ohci-hcd.c | 40 +++- drivers/usb/host/ohci.h |2 +- 2 files changed, 8 insertions(+), 34 deletions(-) di

[PATCH 11/12] fs FAT: fix warning: Using plain integer as NULL pointer

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- fs/fat/ff.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/fat/ff.c b/fs/fat/ff.c index 2d476ee..66db1d6 100644 --- a/fs/fat/ff.c +++ b/fs/fat/ff.c @@ -1043,7 +1043,7 @@ int dir_register (/* 0:Successful, FR_DENIED:No f

[PATCH 05/12] define __user empty

2012-06-25 Thread Sascha Hauer
There is no seperate user address space, so do not generate sparse warnings for this. Signed-off-by: Sascha Hauer --- drivers/mtd/ubi/ubi-barebox.h |1 - include/linux/compiler.h |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/ubi-barebox.h b/dri

[PATCH 12/12] of: Fix usage of 0 as NULL pointer

2012-06-25 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- common/oftree.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/oftree.c b/common/oftree.c index 49758a9..677e934 100644 --- a/common/oftree.c +++ b/common/oftree.c @@ -207,7 +207,7 @@ int fdt_find_and_setprop(struct fdt_header *fdt, c

Re: [PATCH] ARM i.MX51 babbage: add mci1

2012-06-25 Thread Robert Schwebel
On Mon, Jun 25, 2012 at 07:30:41PM +0200, Sascha Hauer wrote: > On Mon, Jun 25, 2012 at 06:39:30PM +0200, Robert Schwebel wrote: > > On Mon, Jun 25, 2012 at 02:05:37PM +0200, Sascha Hauer wrote: > > > The iomuxer is already initialized, only need to add the device. > > > > > > Signed-off-by: Sasch