Re: [PATCH 2/5] ARM: at91: add missing break

2014-04-21 Thread Bo Shen
Hi Lucas Stach, On 04/22/2014 04:15 AM, Lucas Stach wrote: Otherwise SAM A5d35 would be detected as A5d36. Signed-off-by: Lucas Stach Acked-by: Bo Shen --- arch/arm/mach-at91/setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/set

Re: [PATCH 5/5] video: imx-ipu-v3: fix possible NULL ptr dereference

2014-04-21 Thread Fabio Estevam
On Mon, Apr 21, 2014 at 5:15 PM, Lucas Stach wrote: > Signed-off-by: Lucas Stach > --- > drivers/video/imx-ipu-v3/ipu-dmfc.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/imx-ipu-v3/ipu-dmfc.c > b/drivers/video/imx-ipu-v3/ipu-dmfc.c > index 7b

[PATCH 2/5] ARM: at91: add missing break

2014-04-21 Thread Lucas Stach
Otherwise SAM A5d35 would be detected as A5d36. Signed-off-by: Lucas Stach --- arch/arm/mach-at91/setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c index 7a7de9804556..076d0812b356 100644 --- a/arch/arm/mach-at91/setup.c +++ b/arc

[PATCH 4/5] video: displaytimings: remove two broken error messages

2014-04-21 Thread Lucas Stach
The error messages would dereference the just checked NULL ptr. As those messages don't add much value without further info just remove them. Signed-off-by: Lucas Stach --- drivers/video/of_display_timing.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video

[PATCH 5/5] video: imx-ipu-v3: fix possible NULL ptr dereference

2014-04-21 Thread Lucas Stach
Signed-off-by: Lucas Stach --- drivers/video/imx-ipu-v3/ipu-dmfc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/video/imx-ipu-v3/ipu-dmfc.c b/drivers/video/imx-ipu-v3/ipu-dmfc.c index 7b54e25001c6..61704f4a9c06 100644 --- a/drivers/video/imx-ipu-v3/ipu-d

[PATCH 3/5] imx-image: don't leak file handle

2014-04-21 Thread Lucas Stach
Signed-off-by: Lucas Stach --- scripts/imx/imx-image.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c index 1d935be7561d..f4890c44d7fa 100644 --- a/scripts/imx/imx-image.c +++ b/scripts/imx/imx-image.c @@ -528,7 +52

[PATCH 1/5] treewide: fix signedness mixups in printf format specifiers

2014-04-21 Thread Lucas Stach
This most likely doesn't fix any real bugs, but it's the right thing to do and reduces the noise level with static checkers. Signed-off-by: Lucas Stach --- arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c | 2 +- arch/arm/boards/guf-cupid/board.c | 2 +- arch/arm/boards/phytec-p

Re: Beaglebone white: Kernel doesn't start with barebox-2014.03.0

2014-04-21 Thread Lucas Stach
Am Mittwoch, den 16.04.2014, 22:02 +0200 schrieb Uwe Kleine-König: > On Wed, Apr 16, 2014 at 05:35:52PM +0200, Lucas Stach wrote: > > Hi Rolf, > > > > Am Dienstag, den 15.04.2014, 13:28 +0200 schrieb Rolf Evers-Fischer: > > > Dear all, > > > after update to barebox-2014.03.0, the kernel on my beag

[PATCH v2 1/2] don't cast negative error codes to unsigned size_t

2014-04-21 Thread Lucas Stach
The cast prevents us from doing proper error checking. Signed-off-by: Lucas Stach --- v2: use ssize_t instead of plain int --- common/uimage.c | 6 +++--- include/image.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common/uimage.c b/common/uimage.c index 7fbef8688e62..

[PATCH v2 2/2] commands: uimage: remove redundant error message

2014-04-21 Thread Lucas Stach
uimage_verify already prints an error message if the CRC is wrong. Romove the never reached redundant message in the caller. Signed-off-by: Lucas Stach --- commands/uimage.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/commands/uimage.c b/commands/uimage.c index 345