Re: [PATCH 6/8] i.MX: serial: Convert i.MX51 and i.MX6 to use 'setup_uart_ll'

2015-05-03 Thread Sascha Hauer
On Sat, May 02, 2015 at 07:26:18PM -0700, Andrey Smirnov wrote: > Signed-off-by: Andrey Smirnov > --- > > Two boards -- 'guf-santaro' and 'eltec-hipercam' -- were not > converted to use this function because they enable low-level UART > regardless of the value of CONFIG_DEGUG_LL and so converting

Re: [PATCH 5/8] i.MX: serial: Add setup_uart_ll function

2015-05-03 Thread Sascha Hauer
On Sat, May 02, 2015 at 07:26:17PM -0700, Andrey Smirnov wrote: > It appears that all i.MX based boards that support early debug output > inevitably do exactly the same thing with the registers of the UART > peripheral. So to avoid code duplication distill that functionality > into dedicated subrou

Re: [PATCH 4/8] i.MX51: babbage: Implement CONFIG_DEBUG_LL

2015-05-03 Thread Sascha Hauer
On Sat, May 02, 2015 at 07:26:16PM -0700, Andrey Smirnov wrote: > Implement bits of configuraion needed to configure early debug output > support. > > Signed-off-by: Andrey Smirnov > --- > arch/arm/boards/freescale-mx51-babbage/lowlevel.c | 58 > +++ > arch/arm/mach-imx/incl

Re: Regression on next (Re: [PATCH 3/3] driver: Call bus->remove instead of driver->remove)

2015-05-03 Thread Sascha Hauer
Hi Ezequiel, On Sat, May 02, 2015 at 01:50:42PM -0300, Ezequiel Garcia wrote: > Hi Sascha, > > On 03/17/2015 03:25 AM, Sascha Hauer wrote: > > In devices_shutdown we should call the busses remove function > > which in turn calls the drivers remove function. Otherwise for > > example PCI devices n

Re: [PATCH 01/13] net: phy: Support Marvell 88E1318S PHY

2015-05-03 Thread Sebastian Hesselbarth
On 03.05.2015 11:50, Sebastian Hesselbarth wrote: On 02.05.2015 22:28, Ezequiel Garcia wrote: On 05/02/2015 01:53 PM, Ezequiel Garcia wrote: On 04/09/2015 10:03 PM, Sebastian Hesselbarth wrote: This adds support for the Marvell 88E1318S Gigabit Ethernet PHY. Signed-off-by: Sebastian Hesselbar

Re: [PATCH v2 1/8] imx-image: Correctly fill image size in prepended header

2015-05-03 Thread Marc Kleine-Budde
On 05/04/2015 12:24 AM, Andrey Smirnov wrote: [...] >> > @@ -178,8 +183,11 @@ static int add_header_v2(void *buf, int offset, > uint32_t loadaddr, uint32_t imag >> > struct imx_flash_header_v2 *hdr; >> > int dcdsize = curdcd * sizeof(uint32_t); >> > >> > - if (add_barebox_header) >>

Re: [PATCH v2 1/8] imx-image: Correctly fill image size in prepended header

2015-05-03 Thread Marc Kleine-Budde
On 05/03/2015 11:55 PM, Andrey Smirnov wrote: > If called with '-b' option 'imx-image' tool prepends barebox header to > the image, but the tool does not fill the data at image size offset > correctly. Fix that. > > Signed-off-by: Andrey Smirnov > --- > > This patch supercedes the one sent earli

[PATCH v2 1/8] imx-image: Correctly fill image size in prepended header

2015-05-03 Thread Andrey Smirnov
If called with '-b' option 'imx-image' tool prepends barebox header to the image, but the tool does not fill the data at image size offset correctly. Fix that. Signed-off-by: Andrey Smirnov --- This patch supercedes the one sent earlier titled: "[PATCH 1/8] Makefile.lib: Fix i.MX image size aft

[PATCH v2 7/8] bootstrap_read_devfs(): Remove all partitions upon function completion

2015-05-03 Thread Andrey Smirnov
Bootstrap_read_devfs does not remove the devices it creates during the course of its execution which might be considered as a resource leak. Remedy that by adding the code to remove those devices upon function completion. Signed-off-by: Andrey Smirnov --- Changes since v1: - Fix a compile time

[PATCH v2 3/8] bootstrap_read_devfs(): Check for errors from devfs_add_partition()

2015-05-03 Thread Andrey Smirnov
Check for errors returned by devfs_add_partition() and bail if there are any. Signed-off-by: Andrey Smirnov --- Changes since v1: - Fix a compile time error that snuck in during the time the diff was being split into multiple patches lib/bootstrap/devfs.c | 11 +-- 1 file changed,

[PATCH v2 5/8] bootstrap_read_devfs(): Fix potential memory leak

2015-05-03 Thread Andrey Smirnov
In case of a failure in one of the cdev_* functions original version of bootstrap_read_devfs would not release memory allocated for barebox header or memory allocated for the image. This commit fixes this by adding resource deallocation code. Signed-off-by: Andrey Smirnov --- Changes since v1:

Re: [PATCH 1/8] Makefile.lib: Fix i.MX image size after generation

2015-05-03 Thread Andrey Smirnov
On Sun, May 3, 2015 at 1:28 PM, Marc Kleine-Budde wrote: > On 05/03/2015 10:13 PM, Andrey Smirnov wrote: >> If called with '-b' option 'imx-image' tool prepends barebox header to >> the image, but the tool does not fill the data at image size offset >> correctly. Call 'fix_size', right after 'imx-

Re: [PATCH 1/8] Makefile.lib: Fix i.MX image size after generation

2015-05-03 Thread Marc Kleine-Budde
On 05/03/2015 10:13 PM, Andrey Smirnov wrote: > If called with '-b' option 'imx-image' tool prepends barebox header to > the image, but the tool does not fill the data at image size offset > correctly. Call 'fix_size', right after 'imx-image' to fix that. What about fixing the tool instead? The im

[PATCH 7/8] bootstrap_read_devfs(): Remove all partitions upon function completion

2015-05-03 Thread Andrey Smirnov
Bootstrap_read_devfs does not remove the devices it creates during the course of its execution which might be considered as a resource leak. Remedy that by adding the code to remove those devices upon function completion. Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs.c | 11 ++-

[PATCH 1/8] Makefile.lib: Fix i.MX image size after generation

2015-05-03 Thread Andrey Smirnov
If called with '-b' option 'imx-image' tool prepends barebox header to the image, but the tool does not fill the data at image size offset correctly. Call 'fix_size', right after 'imx-image' to fix that. Signed-off-by: Andrey Smirnov --- scripts/Makefile.lib | 3 ++- 1 file changed, 2 insertions

[PATCH 3/8] bootstrap_read_devfs(): Check for errors from devfs_add_partition()

2015-05-03 Thread Andrey Smirnov
Check for errors returned by devfs_add_partition() and bail if there are any. Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/bootstrap/devfs.c b/lib/bootstrap/devfs.c index 82c7d21..de274a0 100644 --- a/

[PATCH 6/8] bootstrap_read_devfs(): Check for errors from dev_add_bb_dev()

2015-05-03 Thread Andrey Smirnov
Check for errors returned by dev_add_bb_dev() and bail if there are any. Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/bootstrap/devfs.c b/lib/bootstrap/devfs.c index f7f91d6..359981e 100644 --- a/lib/b

[PATCH 8/8] bootstrap: Warn if image size in BB header is zero

2015-05-03 Thread Andrey Smirnov
Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/bootstrap/devfs.c b/lib/bootstrap/devfs.c index d7b5185..d071eb3 100644 --- a/lib/bootstrap/devfs.c +++ b/lib/bootstrap/devfs.c @@ -58,8 +58,12 @@ static unsigned i

[PATCH 5/8] bootstrap_read_devfs(): Fix potential memory leak

2015-05-03 Thread Andrey Smirnov
In case of a failure in one of the cdev_* functions original version of bootstrap_read_devfs would not release memory allocated for barebox header or memory allocated for the image. This commit fixes this by adding resource deallocation code. Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs

[PATCH 2/8] bootstrap: Fix potential memory leak in 'read_image_head'

2015-05-03 Thread Andrey Smirnov
Original version of 'read_image_head' would not free the memory allocated for barebox header in cases of any failure. Fix this by adding a dedicated resourse de-allocation code path. Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletion

[PATCH 4/8] bootstrap_read_devfs(): Close file after we are done with it

2015-05-03 Thread Andrey Smirnov
Signed-off-by: Andrey Smirnov --- lib/bootstrap/devfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/bootstrap/devfs.c b/lib/bootstrap/devfs.c index de274a0..4176819 100644 --- a/lib/bootstrap/devfs.c +++ b/lib/bootstrap/devfs.c @@ -120,6 +120,8 @@ void* bootstrap_read_devfs(char *de

[PATCH] Documentation: booting linux: improve doc text

2015-05-03 Thread Robert Schwebel
Signed-off-by: Robert Schwebel --- Documentation/user/booting-linux.rst | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Documentation/user/booting-linux.rst b/Documentation/user/booting-linux.rst index 5ef1254..ad32907 100644 --- a/Documentation/user/booting-lin

Re: [PATCH 01/13] net: phy: Support Marvell 88E1318S PHY

2015-05-03 Thread Sebastian Hesselbarth
On 02.05.2015 22:28, Ezequiel Garcia wrote: On 05/02/2015 01:53 PM, Ezequiel Garcia wrote: On 04/09/2015 10:03 PM, Sebastian Hesselbarth wrote: This adds support for the Marvell 88E1318S Gigabit Ethernet PHY. Signed-off-by: Sebastian Hesselbarth [...] With this commit, the Openblocks A6 PH