Re: [PATCH 4/6] i.MX6: pci: Replace magic number with a named constant

2016-01-07 Thread Sascha Hauer
On Thu, Jan 07, 2016 at 10:04:14AM +0100, Lucas Stach wrote: > Am Donnerstag, den 31.12.2015, 21:58 -0800 schrieb Andrey Smirnov: > > Signed-off-by: Andrey Smirnov > > Reviewed-by: Lucas Stach Applied this one and the other two pci patches. Sascha -- Pengutronix e.K.

Re: [PATCH] usb: chipidea-imx: check return value of regulator_get()

2016-01-07 Thread Sascha Hauer
On Thu, Jan 07, 2016 at 10:55:00AM +0100, Lucas Stach wrote: > From: David Jander > > The VBUS regulator is optional for the chipidea-imx glue, so it must > be checked if regulator_get provided a valid regulator handle before > trying to enable the regulator. > > Signed-off-by: David Jander > S

Re: [PATCH] PCI: imx6: properly shut down core when leaving barebox

2016-01-07 Thread Sascha Hauer
On Thu, Jan 07, 2016 at 10:40:23AM +0100, Lucas Stach wrote: > As the i.MX6 PCIe core doesn't have a software reachable reset > wired up, it's hard for any driver to get the core into a known > good state. > > To make it easier for whatever software follows barebox, bring > back the core into a sa

Re: [PATCH v2 2/3] crypto: add RSA support

2016-01-07 Thread Sascha Hauer
On Thu, Jan 07, 2016 at 10:03:10PM +, Trent Piepho wrote: > On Wed, 2016-01-06 at 18:01 +0100, Marc Kleine-Budde wrote: > > + > > +static void rsa_convert_big_endian(uint32_t *dst, const uint32_t *src, int > > len) > > +{ > > + int i; > > + > > + for (i = 0; i < len; i++) > > + d

Re: [PATCH] of_path: Make partition names work again

2016-01-07 Thread Sascha Hauer
On Thu, Jan 07, 2016 at 06:31:45PM +, Trent Piepho wrote: > There's already a patch in barebox-next that fixes this bug, 985e773. > It doesn't delete the patname: parsing code, but does add a number of > comments that this patch doesn't. Indeed, it's not tool long ago, I should habe remembered

Re: [PATCH v2 2/3] crypto: add RSA support

2016-01-07 Thread Trent Piepho
On Wed, 2016-01-06 at 18:01 +0100, Marc Kleine-Budde wrote: > + > +static void rsa_convert_big_endian(uint32_t *dst, const uint32_t *src, int > len) > +{ > + int i; > + > + for (i = 0; i < len; i++) > + dst[i] = fdt32_to_cpu(src[len - 1 - i]); > +} > + > +struct rsa_public_ke

Re: [PATCH] of_path: Make partition names work again

2016-01-07 Thread Trent Piepho
There's already a patch in barebox-next that fixes this bug, 985e773. It doesn't delete the patname: parsing code, but does add a number of comments that this patch doesn't. On Thu, 2016-01-07 at 12:27 +0100, Sascha Hauer wrote: > The device-path "partname:" mechanism is broken by: > > 75b6827 of

Re: [PATCH 3/3] bootm: add initial FIT support

2016-01-07 Thread Jan Lübbe
On Di, 2016-01-05 at 14:50 +0100, Marc Kleine-Budde wrote: > >> > +static int fit_open_configuration(struct fit_handle *handle, int > num) > >> > +{ > >> > + struct device_node *conf_node = NULL, *sig_node; > >> > + char unit_name[10]; > >> > + const char *unit, *desc; > >> > +

Re: [PATCH 3/3] bootm: add initial FIT support

2016-01-07 Thread Jan Lübbe
On Mi, 2016-01-06 at 17:09 +0100, Marc Kleine-Budde wrote: [...] > >> + /* > >> + * Put oftree/initrd close behind compressed kernel image to avoid > >> + * placing it outside of the kernels lowmem. > >> + */ > >> + if (handle->initrd_size) { > >> + data->initrd_address = PAGE_ALIG

[PATCH] PCI: imx6: properly shut down core when leaving barebox

2016-01-07 Thread Lucas Stach
As the i.MX6 PCIe core doesn't have a software reachable reset wired up, it's hard for any driver to get the core into a known good state. To make it easier for whatever software follows barebox, bring back the core into a safe state before leaving barebox. Signed-off-by: Lucas Stach --- This pa

Re: [PATCH 6/6] i.MX6: pci: Avoid aborts when asserting PCIe reset

2016-01-07 Thread Lucas Stach
Am Donnerstag, den 31.12.2015, 21:58 -0800 schrieb Andrey Smirnov: > When booting Barebox in the HW environment where PCIe core has been > used but not properly shut down, writing to PCIE_PL_PFLR in > imx6_pcie_assert_core_reset would cause data abort exception. > > The problem can be easily repro

Re: [PATCH 4/6] i.MX6: pci: Replace magic number with a named constant

2016-01-07 Thread Lucas Stach
Am Donnerstag, den 31.12.2015, 21:58 -0800 schrieb Andrey Smirnov: > Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach > --- > drivers/pci/pci-imx6.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-imx6.c b/drivers/pci/pci-imx6.c > index eaa5f0e