Re: [PATCH v2 01/10] net: ath79: add ag71xx Ethernet driver

2017-09-13 Thread Sascha Hauer
On Wed, Sep 13, 2017 at 04:15:57PM +0200, Oleksij Rempel wrote: > +static void ag71xx_ether_halt(struct eth_device *edev) > +{ > + struct ag71xx *priv = edev->priv; > + struct device_d *dev = priv->dev; > + uint64_t start; > + > + ag71xx_wr(priv, AG71XX_REG_RX_CTRL, 0); > + star

Re: [PATCH 1/5] commands: nv: argc cannot be < 1

2017-09-13 Thread Sascha Hauer
On Wed, Sep 13, 2017 at 02:23:28PM +0200, Enrico Jorns wrote: > argc == 1 will only contain the name of the program itself which must be > present when invoking nv command code. This reasoning is not quite right. You miss the argc -= optind above the argc < 1 test. In fact in patch 4/5 you re-add

[PATCH v2 01/10] net: ath79: add ag71xx Ethernet driver

2017-09-13 Thread Oleksij Rempel
From: Yegor Yefremov Signed-off-by: Yegor Yefremov Signed-off-by: Antony Pavlov Signed-off-by: Oleksij Rempel --- arch/mips/mach-ath79/include/mach/ar71xx_regs.h | 12 + drivers/net/Kconfig | 7 + drivers/net/Makefile| 1 + drivers/

[PATCH v2 07/10] add phy: ar8327 driver

2017-09-13 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- drivers/net/phy/Kconfig | 5 + drivers/net/phy/Makefile | 1 + drivers/net/phy/ar8327.c | 280 +++ 3 files changed, 286 insertions(+) create mode 100644 drivers/net/phy/ar8327.c diff --git a/drivers/net/phy/Kconf

[PATCH v2 06/10] MIPS: dts: tl_wdr4300: remove RO flag from barebox partition

2017-09-13 Thread Oleksij Rempel
we need it RW for barebox updates. Signed-off-by: Oleksij Rempel --- arch/mips/dts/ar9344_tl_wdr4300.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/dts/ar9344_tl_wdr4300.dts b/arch/mips/dts/ar9344_tl_wdr4300.dts index c784e6cb4..139717a6b 100644 --- a/arch/mips/dts/ar9344_tl_w

[PATCH v2 08/10] MIPS: dts: tl_wdr4300: rename it to tl_wdr4300 v1.7

2017-09-13 Thread Oleksij Rempel
The minor version of TP-Link are usually big enough that it need extra vendor partition on the flash with additional configurations like PLL, CPU and RAM freqs. Visually I was able to confirm at least different SPI Flash and RAM chips. Signed-off-by: Oleksij Rempel --- arch/mips/configs/tplink-

[PATCH v2 05/10] MIPS: dts: tl_wdr4300: add alias for spiflash

2017-09-13 Thread Oleksij Rempel
to unify the naming with TP-Link TL-MR3020. Signed-off-by: Oleksij Rempel --- arch/mips/dts/ar9344_tl_wdr4300.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/dts/ar9344_tl_wdr4300.dts b/arch/mips/dts/ar9344_tl_wdr4300.dts index 5a4a6f379..c784e6cb4 100644 --- a/arch/mips/dts/a

[PATCH v2 04/10] MIPS: dts: tl_wdr4300: enable mac0

2017-09-13 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- arch/mips/dts/ar9344_tl_wdr4300.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/mips/dts/ar9344_tl_wdr4300.dts b/arch/mips/dts/ar9344_tl_wdr4300.dts index b02c1d730..5a4a6f379 100644 --- a/arch/mips/dts/ar9344_tl_wdr4300.dts +++ b/arch/mips/dts/

[PATCH v2 02/10] add ar9331.dtsi and enable mac0

2017-09-13 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- arch/mips/dts/ar9331.dtsi | 12 arch/mips/dts/tplink-mr3020.dts | 5 + 2 files changed, 17 insertions(+) create mode 100644 arch/mips/dts/ar9331.dtsi diff --git a/arch/mips/dts/ar9331.dtsi b/arch/mips/dts/ar9331.dtsi new file mode 100644

[PATCH v2 09/10] MIPS: tplink-wdr4300_defconfig: add network support

2017-09-13 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- arch/mips/configs/tplink-wdr4300_defconfig | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/mips/configs/tplink-wdr4300_defconfig b/arch/mips/configs/tplink-wdr4300_defconfig index b5be221f6..46093d243 100644 --- a/arch/mips/co

[PATCH v2 00/10] provide ethernet support for ar9344 and ar9331

2017-09-13 Thread Oleksij Rempel
changes v2: - merge all ag71xx in to one patch - make sere all new driver use dev_* instead of printk - rework miibus functions. - use it_timedout instead of own implementation - add comments to the patches. Oleksij Rempel (9): add ar9331.dtsi and enable mac0 MIPS: dts: ar9344: add mac0 n

[PATCH v2 03/10] MIPS: dts: ar9344: add mac0 node

2017-09-13 Thread Oleksij Rempel
this node is supported by ag71xx driver Signed-off-by: Oleksij Rempel --- arch/mips/dts/ar9344.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/mips/dts/ar9344.dtsi b/arch/mips/dts/ar9344.dtsi index 0838e8d7f..858751112 100644 --- a/arch/mips/dts/ar9344.dtsi +++ b/arch/m

[PATCH v2 10/10] MIPS: dts: ar9344: add APB bus

2017-09-13 Thread Oleksij Rempel
and move nodes which belong to APB. Signed-off-by: Oleksij Rempel --- arch/mips/dts/ar9344.dtsi | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/arch/mips/dts/ar9344.dtsi b/arch/mips/dts/ar9344.dtsi index 858751112..3e105174d 100644

[PATCH] commands: nv: adjust command help

2017-09-13 Thread Enrico Jorns
Help did not point out that -r option requires n arguments and did not mention support for removing variables in help text. Signed-off-by: Enrico Jorns --- Noticed this change would also be required to round out the prior changes for option parsing. commands/nv.c | 8 1 file changed,

[PATCH 0/5] Fixes for nv command handling

2017-09-13 Thread Enrico Jorns
This series adds a couple of fixes and enhancement in option parsing and error handling for the 'nv' command. Enrico Jorns (5): commands: nv: argc cannot be < 1 commands: nv: call nvvar_print() only if no argument is given commands: nv: assure error code will be returned when an error oc

[PATCH 4/5] commands: nv: fail if required var arguments are missing

2017-09-13 Thread Enrico Jorns
Signed-off-by: Enrico Jorns --- commands/nv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/commands/nv.c b/commands/nv.c index d391f9e6b4..bb13ed1db0 100644 --- a/commands/nv.c +++ b/commands/nv.c @@ -56,6 +56,11 @@ static int do_nv(int argc, char *argv[]) argc -= optind;

[PATCH 1/5] commands: nv: argc cannot be < 1

2017-09-13 Thread Enrico Jorns
argc == 1 will only contain the name of the program itself which must be present when invoking nv command code. Signed-off-by: Enrico Jorns --- commands/nv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/commands/nv.c b/commands/nv.c index 37cdb96647..eb396bfd9b 100644 --- a/commands/nv.

[PATCH 3/5] commands: nv: assure error code will be returned when an error occurred

2017-09-13 Thread Enrico Jorns
Due to iteration over possibly multiple variables, the return value of an individual call to nvvar_remove() / nvvar_add() gets lost. This will result in do_nv() returning success (0) if any variable processing failed as long as processing of the last variable succeeded. Processing will not be abo

[PATCH 5/5] common: globvar: let nvvar_remove() report non-existing variable

2017-09-13 Thread Enrico Jorns
The former implementation did not allow to detect whether the call to nvvar_remove() succeeded or failed and always returned 0. This changes the implementation to return 0 only if a variable with the given name was found and return ENOENT otherwise. Signed-off-by: Enrico Jorns --- common/global

[PATCH 2/5] commands: nv: call nvvar_print() only if no argument is given

2017-09-13 Thread Enrico Jorns
Printing the nv variables (before performing any modification!) is useless and irritating. Signed-off-by: Enrico Jorns --- commands/nv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/commands/nv.c b/commands/nv.c index eb396bfd9b..b141198a93 100644 --- a/commands/n